so.git
5 years agoMerge "fixed sonar issue in SDNCConnector.java"
Byung-Woo Jun [Thu, 30 Aug 2018 11:22:41 +0000 (11:22 +0000)]
Merge "fixed sonar issue in SDNCConnector.java"

5 years agoMerge "fixed sonar issue in SDNCRestClient.java"
Byung-Woo Jun [Thu, 30 Aug 2018 11:22:10 +0000 (11:22 +0000)]
Merge "fixed sonar issue in SDNCRestClient.java"

5 years agoMerge "fixed sonar issue in SDNCCallBackAdapterService"
Byung-Woo Jun [Thu, 30 Aug 2018 11:22:01 +0000 (11:22 +0000)]
Merge "fixed sonar issue in SDNCCallBackAdapterService"

5 years agoMerge "fixed sonar issue in SDNCAdapterService.java"
Byung-Woo Jun [Thu, 30 Aug 2018 11:21:51 +0000 (11:21 +0000)]
Merge "fixed sonar issue in SDNCAdapterService.java"

5 years agoMerge "fixed sonar issue in R__CloudConfigMigration.java"
Byung-Woo Jun [Thu, 30 Aug 2018 11:21:42 +0000 (11:21 +0000)]
Merge "fixed sonar issue in R__CloudConfigMigration.java"

5 years agoFix the readthedocs 77/63777/2
seshukm [Thu, 30 Aug 2018 10:39:54 +0000 (18:39 +0800)]
Fix the readthedocs

Fix to Increase the modularity of the api in readthedocs

Issue-ID: SO-675
Change-Id: I4d3f9845b85a3e0f1bd1936877c54844379b6fee
Signed-off-by: seshukm <seshu.kumar.m@huawei.com>
5 years agofixed sonar issue in SDNCConnector.java 89/63589/2
Sandeep J [Wed, 29 Aug 2018 20:20:45 +0000 (01:50 +0530)]
fixed sonar issue in SDNCConnector.java

fixed sonar issue as detailed in SO-935

Issue-ID: SO-935
Change-Id: Ifdde63670b78acfa8ba84a0130dcd4f4f4649e72
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agofixed sonar issue in BPRestCallback.java 87/63587/2
Sandeep J [Wed, 29 Aug 2018 20:13:56 +0000 (01:43 +0530)]
fixed sonar issue in BPRestCallback.java

fixed sonar issue as detailed in SO-934

Issue-ID: SO-934
Change-Id: I6f87ea6c61e81e0241702b20bcc2688a4a9d5d6a
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agofixed sonar issue in SDNCRestClient.java 85/63585/1
Sandeep J [Wed, 29 Aug 2018 20:05:32 +0000 (01:35 +0530)]
fixed sonar issue in SDNCRestClient.java

fixed sonar issue detailed in SO-933

Issue-ID: SO-933
Change-Id: I8d522f51689568c19da491f0c7272fc9551df9d1
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agofixed sonar issue in SDNCCallBackAdapterService 81/63581/1
Sandeep J [Wed, 29 Aug 2018 19:52:19 +0000 (01:22 +0530)]
fixed sonar issue in SDNCCallBackAdapterService

fixed sonar issue mentioned in jira ticket no SO-932

Issue-ID: SO-932
Change-Id: I9493b09d12446daed1cf43801308d13052232452
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agofixed sonar issue in SDNCAdapterService.java 77/63577/1
Sandeep J [Wed, 29 Aug 2018 19:45:39 +0000 (01:15 +0530)]
fixed sonar issue in SDNCAdapterService.java

fixed sonar issue mentioned in jira SO-914

Issue-ID: SO-914
Change-Id: I4893bce5dbdd5e0bc524dc0ead0dc41f246afca4
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agofixed sonar issue in R__CloudConfigMigration.java 75/63575/1
Sandeep J [Wed, 29 Aug 2018 19:38:00 +0000 (01:08 +0530)]
fixed sonar issue in R__CloudConfigMigration.java

fixed sonar issues mentioned in Jira ticket SO-931

Issue-ID: SO-931
Change-Id: I31ec20e4958a11f25050eadd42ce0edc56e042d4
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoRemove staging repo from pom 63/63563/1
Rob Daugherty [Wed, 29 Aug 2018 18:27:39 +0000 (14:27 -0400)]
Remove staging repo from pom

The use of the staging repo to fulfill build dependencies was eliminated
over a year ago.

Change-Id: Id8a62325659b2e682a21a02e3361eb517101f6b9
Issue-ID: SO-930
Signed-off-by: Rob Daugherty <rd472p@att.com>
5 years ago Sonar reported Vulnerability in AAIObjectMapper 15/63515/1
GOPINATH MATHIVANAN [Wed, 29 Aug 2018 14:52:13 +0000 (20:22 +0530)]
 Sonar reported Vulnerability in AAIObjectMapper

Fixed Sonar reported Vulnerability in AAIObjectMapper file

Issue-ID: SO-929
Change-Id: I8b47a7c80bf35007e2f48efb447cdb5fa60beadc
Signed-off-by: GOPINATH MATHIVANAN <gopinath.mathivanan@in.ibm.com>
5 years agoMerge "Added GenericVnfHealthCheckBB, tasks, and tests"
Rob Daugherty [Wed, 29 Aug 2018 13:57:06 +0000 (13:57 +0000)]
Merge "Added GenericVnfHealthCheckBB, tasks, and tests"

5 years agoMerge "fixed sonar issues in NetworkAdaptorNotify_Service"
Byung-Woo Jun [Wed, 29 Aug 2018 11:26:11 +0000 (11:26 +0000)]
Merge "fixed sonar issues in NetworkAdaptorNotify_Service"

5 years agoMerge "fixed sonar issue in SDNCAdapterService.java"
Byung-Woo Jun [Wed, 29 Aug 2018 11:25:30 +0000 (11:25 +0000)]
Merge "fixed sonar issue in SDNCAdapterService.java"

5 years agofixed sonar issue in SDNCAdapterService.java 51/62951/3
Sandeep J [Sun, 26 Aug 2018 21:36:08 +0000 (03:06 +0530)]
fixed sonar issue in SDNCAdapterService.java

resolved sonar issue desribed in Jira id: SO-914

Issue-ID: SO-914
Change-Id: Icc79a36d665ca950ddcd289dd239b8aa3360db37
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agofixed sonar issues in NetworkAdaptorNotify_Service 45/62945/4
Sandeep J [Sun, 26 Aug 2018 21:02:45 +0000 (02:32 +0530)]
fixed sonar issues in NetworkAdaptorNotify_Service

Reorder the modifiers to comply with the Java Language Specification

Issue-ID: SO-911
Change-Id: I74ebc31679f1e8169c07b2f42b9f7e86d4134621
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoFix for the license issue 57/63357/2
seshukm [Wed, 29 Aug 2018 02:57:45 +0000 (10:57 +0800)]
Fix for the license issue

Issue-ID: SO-915

Change-Id: I8212e0723924b56d77be8f26536a5e69823418a1
Signed-off-by: seshukm <seshu.kumar.m@huawei.com>
5 years agoUse managed guava version 83/62783/3
Gary Wu [Fri, 24 Aug 2018 22:30:22 +0000 (15:30 -0700)]
Use managed guava version

Use centrally managed guava version specified in
oparent.  Includes upgrade to oparent 1.2.0.

This change was submitted by script and may include
additional whitespace or formatting changes.

Change-Id: I4da3f582e347da62f9d6fe8d6f20c147d493b8a0
Issue-ID: INT-619
Signed-off-by: Gary Wu <gary.i.wu@huawei.com>
5 years agoMerge "Converted ServiceInstances to catalog db client"
Rob Daugherty [Tue, 28 Aug 2018 20:45:31 +0000 (20:45 +0000)]
Merge "Converted ServiceInstances to catalog db client"

5 years agoMerge "added unit test for decoded keys"
Rob Daugherty [Tue, 28 Aug 2018 20:44:09 +0000 (20:44 +0000)]
Merge "added unit test for decoded keys"

5 years agoMerge "fixed double encoding issue"
Rob Daugherty [Tue, 28 Aug 2018 20:44:01 +0000 (20:44 +0000)]
Merge "fixed double encoding issue"

5 years agoAdded GenericVnfHealthCheckBB, tasks, and tests 23/63323/1
Brittany Plummer (bp896r) [Tue, 28 Aug 2018 19:58:07 +0000 (15:58 -0400)]
Added GenericVnfHealthCheckBB, tasks, and tests

Issue-ID: SO-777
Change-Id: I8a46f1802feb18ab4df098472fef5373ac42208b
Signed-off-by: Brittany Plummer (bp896r) <bp896r@att.com>
5 years agoConverted ServiceInstances to catalog db client 73/63273/2
Benjamin, Max (mb388a) [Tue, 28 Aug 2018 14:23:08 +0000 (10:23 -0400)]
Converted ServiceInstances to catalog db client

- Fixed issues related to created Date Format, enabled required Test
- Fixed issues related to queryParam names, enabled required Test
- Fixed issues related to queryParam names
-  Improving coverage for catalogDbClient by another 10% (its 78% now)
-  Improving coverage for catalogDbClient by another 10%. There is a
failing test which will be explored shortly
-  Improving coverage for catalogDbClient, adding some tests and their
basic asserts
- merging with dev and resolving the compilation issue arising due to it
- Removing some TODO introduced in code for incremental pushes
- Fixing failing unit test cases with the build
- Refactoring done for code change in catalogDBClient
- merged changes with development branch
- Modified unit tests for Catalogdb Client related code
- Modified unit tests for Catalogdb Client related code
- Fixed some of the repository code for retrieving single resource
- Modified unit tests for Catalogdb Client related code
- Modified unit tests for Catalogdb Client related code
- Modified unit tests for Catalogdb Client related code
- Removed @Param from repositories and added -Parameters argument in
maven compile plugin
...

Change-Id: Ieeb7bcc21a573465e485fedfbbe771c8b89db3f8
Issue-ID: SO-925
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
5 years agofixed incorrect groovy method call 69/63269/1
Benjamin, Max (mb388a) [Tue, 28 Aug 2018 13:55:49 +0000 (09:55 -0400)]
fixed incorrect groovy method call

Added missing pers to isEmpty and also added relationship present check
to prevent null pointer.

Change-Id: I7f184c428694e55b75f255d517a53aac7be82aab
Issue-ID: SO-924
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
5 years agofixed double encoding issue 65/63265/1
Benjamin, Max (mb388a) [Tue, 28 Aug 2018 13:52:58 +0000 (09:52 -0400)]
fixed double encoding issue

Changed the way customer and serviceType are extracted to prevent
double encoding.

Change-Id: I409da51a10ec38623b321985e25b5390ff4fa5d6
Issue-ID: SO-923
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
5 years agoadded unit test for decoded keys 59/63259/1
Benjamin, Max (mb388a) [Tue, 28 Aug 2018 13:48:38 +0000 (09:48 -0400)]
added unit test for decoded keys

unit test to demonstrate that uri values are decoded

Change-Id: Idd90e02f9c794b7ebf6755a4dbd834fb29be40ad
Issue-ID: SO-922
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
5 years agoMerge "Fixed Sonar isssue"
Seshu Kumar M [Tue, 28 Aug 2018 07:51:34 +0000 (07:51 +0000)]
Merge "Fixed Sonar isssue"

5 years agoAdd subscriptionServiceType variable to vCPE BPMN 29/63129/1
Marcus G K Williams [Mon, 27 Aug 2018 20:31:06 +0000 (13:31 -0700)]
Add subscriptionServiceType variable to vCPE BPMN

Made subscriptionServiceType available for
homing flows

Issue-ID: SO-667
Change-Id: I75c38473ae4302d1cdeb57265ab737668a897133
Signed-off-by: Marcus G K Williams <marcus.williams@intel.com>
5 years agoFixed Sonar isssue 09/63209/1
GOPINATH MATHIVANAN [Mon, 27 Aug 2018 18:41:05 +0000 (00:11 +0530)]
Fixed Sonar isssue

Fixed Sonar issue by adding a logge message in the catch block of
exception.

Issue-ID: SO-917
Change-Id: I6163d5bd0706d1b426b9dd3cbdc709d2418a1e70
Signed-off-by: GOPINATH MATHIVANAN <gopinath.mathivanan@in.ibm.com>
5 years agofixed sonar issues in MsoRequestsDbAdapterImpl 49/62949/3
Sandeep J [Sun, 26 Aug 2018 21:24:34 +0000 (02:54 +0530)]
fixed sonar issues in MsoRequestsDbAdapterImpl

fixed sonar issue: Define a constant instead of duplicating literal 3
times.

Issue-ID: SO-913
Change-Id: I12e2d60d9841cf3600ac7e4c822027c9af19c3b6
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoMerge "is sniro request is initial or speed change"
Rob Daugherty [Mon, 27 Aug 2018 14:14:04 +0000 (14:14 +0000)]
Merge "is sniro request is initial or speed change"

5 years agoMerge "fixed sonar issue in QeruServiceNetworks.java"
Seshu Kumar M [Mon, 27 Aug 2018 13:50:07 +0000 (13:50 +0000)]
Merge "fixed sonar issue in QeruServiceNetworks.java"

5 years agoMerge "fixed sonar issue in CatalogDbAdaptorRest.java"
Seshu Kumar M [Mon, 27 Aug 2018 13:49:44 +0000 (13:49 +0000)]
Merge "fixed sonar issue in CatalogDbAdaptorRest.java"

5 years agoMerge "fixed sonar issue in MsoNetworkAdapterAsyncImpl"
Rob Daugherty [Mon, 27 Aug 2018 13:48:20 +0000 (13:48 +0000)]
Merge "fixed sonar issue in MsoNetworkAdapterAsyncImpl"

5 years agoMerge "fixed sonar issue in R_CloudConfigMigration.java"
Rob Daugherty [Mon, 27 Aug 2018 13:29:40 +0000 (13:29 +0000)]
Merge "fixed sonar issue in R_CloudConfigMigration.java"

5 years agoMerge "request db access converted to rest"
Rob Daugherty [Mon, 27 Aug 2018 13:28:30 +0000 (13:28 +0000)]
Merge "request db access converted to rest"

5 years agoMerge "Added actions to common APIH package"
Seshu Kumar M [Mon, 27 Aug 2018 09:34:20 +0000 (09:34 +0000)]
Merge "Added actions to common APIH package"

5 years agoMerge "Use serviceSubsriptionType in OOF Homing Request"
Seshu Kumar M [Mon, 27 Aug 2018 05:27:34 +0000 (05:27 +0000)]
Merge "Use serviceSubsriptionType in OOF Homing Request"

5 years agofixed sonar issue in MsoNetworkAdapterAsyncImpl 39/62939/2
Sandeep J [Sun, 26 Aug 2018 20:34:22 +0000 (02:04 +0530)]
fixed sonar issue in MsoNetworkAdapterAsyncImpl

fixed sonar issues

Issue-ID: SO-909
Change-Id: If2a1ef898dfba15420f5deb245809cc8eeb6bdce
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agofixed sonar issue in CatalogDbAdaptorRest.java 35/62935/1
Sandeep J [Sun, 26 Aug 2018 20:15:58 +0000 (01:45 +0530)]
fixed sonar issue in CatalogDbAdaptorRest.java

removed unsused imports

Issue-ID: SO-908
Change-Id: Ib730929e8f255274bf85124ca7a8fcc31b95b051
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agofixed sonar issue in QeruServiceNetworks.java 33/62933/1
Sandeep J [Sun, 26 Aug 2018 20:09:02 +0000 (01:39 +0530)]
fixed sonar issue in QeruServiceNetworks.java

removed unused import at line 31

Issue-ID: SO-907
Change-Id: If7cbb9ab074a6e7477dbf1b3eff02f372b75b59f
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agofixed sonar issue in R_CloudConfigMigration.java 31/62931/1
Sandeep J [Sun, 26 Aug 2018 19:57:57 +0000 (01:27 +0530)]
fixed sonar issue in R_CloudConfigMigration.java

fixed sonar issue: Remove the declaration of thrown exception
'com.fasterxml.jackson.core.JsonParseException' which is a subclass of
'java.io.IOException: line 81

Issue-ID: SO-906
Change-Id: If18c2b6e0769d95dc56c9dbac5c1d5219e95955c
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoUse serviceSubsriptionType in OOF Homing Request 29/62429/1
Marcus G K Williams [Fri, 24 Aug 2018 21:46:07 +0000 (14:46 -0700)]
Use serviceSubsriptionType in OOF Homing Request

SO maps "instanceName" to "serviceName" field
in the Homing Request, however OOF is expecting
'subscriptionServiceType'

Issue-ID: SO-667
Change-Id: I3faa6cc600b6515d9c6e01e18cb289104f3976fc
Signed-off-by: Marcus G K Williams <marcus.williams@intel.com>
5 years agoMerge "converted test to dynamic port"
Marcus Williams [Fri, 24 Aug 2018 21:51:02 +0000 (21:51 +0000)]
Merge "converted test to dynamic port"

5 years agoMerge "Do not log stack trace when http not found occurs"
Marcus Williams [Fri, 24 Aug 2018 20:08:58 +0000 (20:08 +0000)]
Merge "Do not log stack trace when http not found occurs"

5 years agoMerge "Created Ref Data tbl for controllerSelection"
Marcus Williams [Fri, 24 Aug 2018 20:05:47 +0000 (20:05 +0000)]
Merge "Created Ref Data tbl for controllerSelection"

5 years agoconverted test to dynamic port 73/62373/1
Benjamin, Max (mb388a) [Fri, 24 Aug 2018 17:10:42 +0000 (13:10 -0400)]
converted test to dynamic port

Change-Id: Iab26b24d9178685061cde7de7f78562f17d20e78
Issue-ID: SO-905
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
5 years agoAdded actions to common APIH package 61/62361/1
Brittany Plummer (bp896r) [Fri, 24 Aug 2018 15:19:02 +0000 (11:19 -0400)]
Added actions to common APIH package

Added scaleOut to common APIH Action enums

Change-Id: I94f3d6b68d8890dd41aa4bd9ff51e5ecd2253383
Issue-ID: SO-904
Signed-off-by: Brittany Plummer (bp896r) <bp896r@att.com>
5 years agoMerge "retired flows no longer in use"
Rob Daugherty [Fri, 24 Aug 2018 14:11:45 +0000 (14:11 +0000)]
Merge "retired flows no longer in use"

5 years agoMerge "correct return values of asBean"
Rob Daugherty [Fri, 24 Aug 2018 14:10:20 +0000 (14:10 +0000)]
Merge "correct return values of asBean"

5 years agorequest db access converted to rest 41/62341/1
Benjamin, Max (mb388a) [Fri, 24 Aug 2018 13:23:29 +0000 (09:23 -0400)]
request db access converted to rest

[MSO-5031]_updated_JUnits_to_assert_request_body_for_requestDb_client
Marking JPARepositories as Remote Rest repositories for
TenantIsolationRunnable class | Minor refactoring
Add request DB Config to ATT specific ASDC controller test yaml
Adding requestDB Endpoint to yaml so as to pass the tests of asdc
controller
Adding requestDB Endpoint to yaml so as to pass the tests
Adding requestDB Endpoint to yaml so as to pass the tests
Handling the build failure due to mock mismatch
Handling the build failure due to conflicting beans and additional
minor refactoring
Handling the build failure due to conflicting beans
Adding RequestDB endpoint to yaml files for running tests
Removing non-entity classes from ClassURLMapper class
Marking JPARepositories as Remote Rest repositories for
TenantIsolationRunnable class | Fixing minor Bug
Marking JPARepositories as Remote Rest repositories for
TenantIsolationRunnable class | Fixing junits
Marking JPARepositories as Remote Rest repositories for
TenantIsolationRunnable class | Fixing
getMultipleOperationalEnvServiceModelStatus
Marking JPARepositories as Remote Rest repositories for
TenantIsolationRunnable class | Fixing Junits
Marking JPARepositories as Remote Rest repositories for RequestsDBHelper
Marking JPARepositories as Remote Rest repositories for
TenantIsolationRunnable class | Moving RequestsDbClient to requestdb
package
Marking JPARepositories as Remote Rest repositories for
TenantIsolationRunnable class | Fixing Junits
Marking JPARepositories as Remote Rest repositories for
TenantIsolationRunnable class | Initial Checkin

Change-Id: I4053919e98afb8db962511be0a3318b1bf8af88a
Issue-ID: SO-903
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
5 years agoDo not log stack trace when http not found occurs 39/62339/1
Benjamin, Max (mb388a) [Fri, 24 Aug 2018 13:18:07 +0000 (09:18 -0400)]
Do not log stack trace when http not found occurs

do not log stack trace when http not found occurs

Change-Id: Ia0638eba7f8d9544dae21290c836c7be1e05ac2e
Issue-ID: SO-902
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
5 years agoretired flows no longer in use 37/62337/1
Benjamin, Max (mb388a) [Fri, 24 Aug 2018 13:13:17 +0000 (09:13 -0400)]
retired flows no longer in use

corrected spelling for migration sql file
delete 1802-style flow, MSO to create l3network in AAI
Revert "retire 1802-style flow, MSO to create l3network in AAI"
retire 1802-style flow, MSO to create l3network in AAI

Change-Id: I0a63d086891565c2346424a3d1b49ce974f5db24
Issue-ID: SO-901
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
5 years agocorrect return values of asBean 33/62333/1
Benjamin, Max (mb388a) [Fri, 24 Aug 2018 13:08:49 +0000 (09:08 -0400)]
correct return values of asBean

More adds of Optional<> to other ServiceInstance objects.
Change to add the Optional<> to the ServiceInstance object.

Change-Id: Ie486122412f9ad3d88ba0cf9df41ec226a4b8982
Issue-ID: SO-900
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
5 years agoaairesultwrapper is now actually serializable 29/62329/1
Benjamin, Max (mb388a) [Fri, 24 Aug 2018 13:02:47 +0000 (09:02 -0400)]
aairesultwrapper is now actually serializable

added in a proper serialization and deserialization test
addressed any comments from pull
added in a serialization test for AAIResultWrapper and updated one of
the null returns
change jsonBody in AAIResultWrapper back to String

Change-Id: Iffa5661f129cc26d69dfaa966cd265c67903cf21
Issue-ID: SO-899
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
5 years agoRename asdc-controller docker image 95/62195/2
Rob Daugherty [Thu, 23 Aug 2018 19:38:17 +0000 (15:38 -0400)]
Rename asdc-controller docker image

OOM would like it to be called onap/so/sdc-controller.

Change-Id: Ifa37b4fa62f214a1ff56e31c4f4f4eca5b4566fc
Issue-ID: SO-897
Signed-off-by: Rob Daugherty <rd472p@att.com>
5 years agoCreated Ref Data tbl for controllerSelection 71/60371/4
Prema Bhatt [Fri, 10 Aug 2018 22:54:13 +0000 (15:54 -0700)]
Created Ref Data tbl for controllerSelection

RD: I rebased this and fixed the unit tests.

Issue-ID: SO-763
Change-Id: Ie5f6a708cffbc70a9481afd35db3047fe44cb088
Signed-off-by: Prema Bhatt <pb6115@att.com>
Signed-off-by: Rob Daugherty <rd472p@att.com>
5 years agoProd fixes August 21st 83/62183/1
Benjamin, Max (mb388a) [Thu, 23 Aug 2018 18:50:49 +0000 (14:50 -0400)]
Prod fixes August 21st

changes required for unit tests to pass again
Changes sniro homing BB license demand to be a named array per sniro
defect.
boolean checks must now account for null
fixed compilation issues in code
updated tests and removed primatives from bbobjects
upgraded to A&AI dependency with Boolean

Change-Id: I5f3e69c0ad24d2c3e4591568467bad861abd0261
Issue-ID: SO-896
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
5 years agoMerge "write update status of BBs progress"
Rob Daugherty [Thu, 23 Aug 2018 16:17:18 +0000 (16:17 +0000)]
Merge "write update status of BBs progress"

5 years agoMerge "Do not serialize AAIResultWrapper"
Rob Daugherty [Thu, 23 Aug 2018 14:18:55 +0000 (14:18 +0000)]
Merge "Do not serialize AAIResultWrapper"

5 years agoMerge "removed classes no longer in use"
Rob Daugherty [Thu, 23 Aug 2018 14:18:41 +0000 (14:18 +0000)]
Merge "removed classes no longer in use"

5 years agoMerge "Changed RequestFactory for Catalog DB client"
Rob Daugherty [Thu, 23 Aug 2018 14:18:28 +0000 (14:18 +0000)]
Merge "Changed RequestFactory for Catalog DB client"

5 years agoMerge "created generic HttpLookupUri class"
Rob Daugherty [Thu, 23 Aug 2018 14:07:13 +0000 (14:07 +0000)]
Merge "created generic HttpLookupUri class"

5 years agoMerge "Renamed migration from version 4.2 to 4.3"
Rob Daugherty [Thu, 23 Aug 2018 14:06:21 +0000 (14:06 +0000)]
Merge "Renamed migration from version 4.2 to 4.3"

5 years agoMerge "Prod fixes August 18th"
Rob Daugherty [Thu, 23 Aug 2018 13:51:56 +0000 (13:51 +0000)]
Merge "Prod fixes August 18th"

5 years agoMerge "get service type and customer id from uri keys"
Rob Daugherty [Thu, 23 Aug 2018 13:51:05 +0000 (13:51 +0000)]
Merge "get service type and customer id from uri keys"

5 years agoMerge "fixed filter of configuration flow calls"
Rob Daugherty [Thu, 23 Aug 2018 13:31:09 +0000 (13:31 +0000)]
Merge "fixed filter of configuration flow calls"

5 years agoMerge "update field in service decomp object"
Rob Daugherty [Thu, 23 Aug 2018 13:30:04 +0000 (13:30 +0000)]
Merge "update field in service decomp object"

5 years agoremoved classes no longer in use 21/62121/1
Benjamin, Max (mb388a) [Thu, 23 Aug 2018 13:07:59 +0000 (09:07 -0400)]
removed classes no longer in use

Change create configuration to use yang service instance and removed
AAIServiceInstance pojo.

Change-Id: I2420503f1a00c2dc64b6021aad8e42aa2080eb98
Issue-ID: SO-895
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
5 years agoDo not serialize AAIResultWrapper 19/62119/1
Benjamin, Max (mb388a) [Thu, 23 Aug 2018 13:06:09 +0000 (09:06 -0400)]
Do not serialize AAIResultWrapper

fixed a broken building block bpmn test
removed serialization of result wrapper

Change-Id: I24a9b325e5543cb11b0dee4ae3a1e6957469e87a
Issue-ID: SO-894
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
5 years agois sniro request is initial or speed change 17/62117/1
Benjamin, Max (mb388a) [Thu, 23 Aug 2018 13:02:40 +0000 (09:02 -0400)]
is sniro request is initial or speed change

Changed logic to determine if sniro request is initial or speed change.

Change-Id: I36eeea8860855bf5226560dcc2722a2c27723ef9
Issue-ID: SO-893
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
5 years agoChanged RequestFactory for Catalog DB client 15/62115/1
Benjamin, Max (mb388a) [Thu, 23 Aug 2018 12:55:54 +0000 (08:55 -0400)]
Changed RequestFactory for Catalog DB client

- Missed some files, the repository isn't required now that we
dont fetch the identity service directly
- Fixing review comments and removing the unused import
- Fixing the build :) Now that cloudSite has a 1-1 relationship with
cloudidentity, there shouldn't be a need to query the identity on its
own unless the site is missing Refactored some code to use site to
fetch identity as a composition
- Changing the catalogDb client to use
HttpComponentsClientHttpRequestFactory instead of
SimpleClientHttpRequestFactory, the later would lead to a IOException
(FileNotFoundException specifically) whenever a 40X type of a response
code is returned from the spring rest endpoint. Adding some tests for
the catalogDbClient which earlier got missed in handover. Also fixing
another issue with cloudSite repository which was not fetching data
correctly. Fixed a repository which was added initially but later the
same went missing (Not sure how)

Change-Id: I72506865c4c5f7fd07a6031c146a4aba1a96c2c8
Issue-ID: SO-892
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
5 years agoRenamed migration from version 4.2 to 4.3 11/62111/1
Benjamin, Max (mb388a) [Thu, 23 Aug 2018 12:52:04 +0000 (08:52 -0400)]
Renamed migration from version 4.2 to 4.3

renamed migration from 4.2 to 4.3 to avoid collision

Change-Id: Ie7ecb089555c5150d3e66d9e6de62f8228d1d373
Issue-ID: SO-891
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
5 years agowrite update status of BBs progress 91/62091/1
Benjamin, Max (mb388a) [Thu, 23 Aug 2018 12:48:58 +0000 (08:48 -0400)]
write update status of BBs progress

added in the missing bpmn file change
add implementation to update status of BBs progress

Change-Id: If913b4e4da2a548e7b5660be947721cb17c60d3f
Issue-ID: SO-890
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
5 years agoget service type and customer id from uri keys 87/62087/1
Benjamin, Max (mb388a) [Thu, 23 Aug 2018 12:44:41 +0000 (08:44 -0400)]
get service type and customer id from uri keys

Added logic to get service type and customer id from uri keys for sdnc request.

Change-Id: I3b0c4b88737e2ad6fc573d335addff221d06e885
Issue-ID: SO-889
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
5 years agofixed filter of configuration flow calls 85/62085/1
Benjamin, Max (mb388a) [Thu, 23 Aug 2018 12:41:08 +0000 (08:41 -0400)]
fixed filter of configuration flow calls

fix filtering of configuration flow calls

Change-Id: I80f25d1b78b7268f92cb78b70f350ede100fe35e
Issue-ID: SO-888
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
5 years agoupdate field in service decomp object 81/62081/1
Benjamin, Max (mb388a) [Thu, 23 Aug 2018 12:31:42 +0000 (08:31 -0400)]
update field in service decomp object

removed duplicate json test file and updated existing
update ServiceDecompoition serviceNetworks field

Change-Id: Iea3dc7efe4edb8ba32e45772fd9d77d9e7fc0ef6
Issue-ID: SO-887
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
5 years agofix sonar critcal issues in R_CloudConfigMigration 69/62069/1
Sandeep J [Thu, 23 Aug 2018 11:43:42 +0000 (17:13 +0530)]
fix sonar critcal issues in R_CloudConfigMigration

added specific excpetions instead of generic ones

Issue-ID: SO-886
Change-Id: Ib0f2e655a6e58b8dc142233679a53c15b373f117
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agofixed sonar issue in CatalogQueryExceptionCommon 41/62041/1
Sandeep J [Thu, 23 Aug 2018 10:05:21 +0000 (15:35 +0530)]
fixed sonar issue in CatalogQueryExceptionCommon

fixed sonar issue: removed unused import

Issue-ID: SO-883
Change-Id: Ie9117601c7d64974067b5ab81ccb8a58d4a2fdc5
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoMerge "fixed sonar issues in MsoNetworkAdapterAsyncImpl"
Byung-Woo Jun [Thu, 23 Aug 2018 03:09:53 +0000 (03:09 +0000)]
Merge "fixed sonar issues in MsoNetworkAdapterAsyncImpl"

5 years agoMerge "resolved sonar issue in QueryServiceMacroHolder"
Byung-Woo Jun [Thu, 23 Aug 2018 03:09:48 +0000 (03:09 +0000)]
Merge "resolved sonar issue in QueryServiceMacroHolder"

5 years agofixed sonar issues in MsoNetworkAdapterAsyncImpl 25/61925/1
Sandeep J [Wed, 22 Aug 2018 22:42:20 +0000 (04:12 +0530)]
fixed sonar issues in MsoNetworkAdapterAsyncImpl

removed useless assignment of local variable "sMap" at lines
646,664,684. And, also removed keyset with entryset at line 650

Issue-ID: SO-882
Change-Id: I31a1a0c2c7aa4d65466125bda6948765326994eb
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoresolved sonar issue in QueryServiceMacroHolder 21/61921/1
Sandeep J [Wed, 22 Aug 2018 22:19:10 +0000 (03:49 +0530)]
resolved sonar issue in QueryServiceMacroHolder

removed the commented lines of code as per issue raised by SONAR

Issue-ID: SO-881
Change-Id: Ic25a7418df06c7b7da2c60bec9dc4adbc97d902b
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoadded unit test for class 57/61657/2
Benjamin, Max (mb388a) [Tue, 21 Aug 2018 18:43:36 +0000 (14:43 -0400)]
added unit test for class

Adding unit tests for the infraactiverepositorycustomcontroller
and fixing an issue found while adding the test

Change-Id: Ic177f75c995ee789902dc9ad1b7df0e997b998c9
Issue-ID: SO-876
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
5 years agoMerge "removed problematic swagger dependency"
Marcus Williams [Wed, 22 Aug 2018 16:48:28 +0000 (16:48 +0000)]
Merge "removed problematic swagger dependency"

5 years agoMerge "updated ServiceInstance POJO"
Marcus Williams [Wed, 22 Aug 2018 16:46:17 +0000 (16:46 +0000)]
Merge "updated ServiceInstance POJO"

5 years agoProd fixes August 18th 75/61875/1
Benjamin, Max (mb388a) [Wed, 22 Aug 2018 16:10:23 +0000 (12:10 -0400)]
Prod fixes August 18th

fixed compilation issues and all unit tests now pass
fix condition that checks for vnf in list to set homing flags
fix resource name variable being null
Skip volume group search for alacarte VF Module creation, since that group is expected to be specified on the input
Remove temporary change to JUnit for creation of volume group.
Add mapping of isBaseVfModule setting to AAIObjectMapper for vfModule.
adding a unit test for hte issue which was fixed
Explicitly return heatStackId variable from VnfAdapter subprocess
Fixing an issue with the workflow processor/asynresource which may lead to
apihandler leaving the active_Request table record in_progress while the bpmn quits the processing due to the error.

Change-Id: I7587193fcb5251f50370d72a1e4c10d112a1c72f
Issue-ID: SO-879
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
5 years agoremoved problematic swagger dependency 45/61845/1
Benjamin, Max (mb388a) [Wed, 22 Aug 2018 13:33:08 +0000 (09:33 -0400)]
removed problematic swagger dependency

removed swagger dependency which was causing issues

Change-Id: I1e840f7ea9a45547c2562ce628c38f7c7e065e65
Issue-ID: SO-880
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
5 years agoMerge "update install and configure document"
Chuanyu Chen [Wed, 22 Aug 2018 09:39:57 +0000 (09:39 +0000)]
Merge "update install and configure document"

5 years agoupdate install and configure document 93/61793/1
seshukm [Wed, 22 Aug 2018 07:49:51 +0000 (15:49 +0800)]
update install and configure document

Issue-ID: SO-675

Change-Id: I157d04c2bebf3771df22792d9c7856ffa99d8393
Signed-off-by: seshukm <seshu.kumar.m@huawei.com>
5 years agoMerge "sonar try-with-resources"
Seshu Kumar M [Wed, 22 Aug 2018 05:39:33 +0000 (05:39 +0000)]
Merge "sonar try-with-resources"

5 years agoMerge "openstack_adapter container fails to start"
Marcus Williams [Tue, 21 Aug 2018 23:32:59 +0000 (23:32 +0000)]
Merge "openstack_adapter container fails to start"

5 years agoopenstack_adapter container fails to start 89/61689/1
Rob Daugherty [Tue, 21 Aug 2018 22:42:55 +0000 (18:42 -0400)]
openstack_adapter container fails to start

The reported problem occurs because the openstack-adapters app
is attempting to do a migration on top of a migration already
performed by the catalog-db app.

I'm adding these options to flyway in openstack-adapters:
  baseline-on-migrate: true
  validate-on-migrate: false

Another issue is that the java-based CloudConfig migration class
was looking for CloudConfig data only in the application.yaml
file in the classpath.  It was not looking for CloudConfig data
in the override file.  I've changed this logic to look in the
override file first and then in application.yaml.  Ideally, these
sources would be merged, but I don't see a reasonable way to do it.

Change-Id: I7ba07c1f8f00b4c628e825393ee31502950fe592
Issue-ID: SO-868
Signed-off-by: Rob Daugherty <rd472p@att.com>
5 years agoupdated ServiceInstance POJO 63/61663/1
Benjamin, Max (mb388a) [Tue, 21 Aug 2018 18:54:06 +0000 (14:54 -0400)]
updated ServiceInstance POJO

added new fields to pojo for groovy compatibility

Change-Id: If88a9b51d506d6937bbd431c641410cc4ba07c9e
Issue-ID: SO-878
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
5 years agocreated generic HttpLookupUri class 61/61661/1
Benjamin, Max (mb388a) [Tue, 21 Aug 2018 18:48:46 +0000 (14:48 -0400)]
created generic HttpLookupUri class

created generic HttpLookupUri abstract class

Change-Id: Ie45d620af77fb58c0a7b469aba4a10f274b0de59
Issue-ID: SO-877
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
5 years agoprod bug fixes august 12th 55/61655/1
Benjamin, Max (mb388a) [Tue, 21 Aug 2018 18:30:07 +0000 (14:30 -0400)]
prod bug fixes august 12th

Set generalBuildingBlock variable on execution to
pass heatStackId updates to the calling process.

Pass CloudParams to SDNC on Create request

Pass cloudParams to VNF Adapter on VF Module
creation too.

Change-Id: I523cde0edb1412fc12e1d7a13c91c77869b505fd
Issue-ID: SO-875
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
5 years agofixed sonar issue in WebSecurityConfigImpl.java 27/61627/1
Sandeep J [Tue, 21 Aug 2018 15:04:34 +0000 (20:34 +0530)]
fixed sonar issue in WebSecurityConfigImpl.java

fixed the sonar issue in the file at line 39

Issue-ID: SO-874
Change-Id: Ic187fa42e81a503e99ff71ab9ab971c21aa82cd3
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>