Seshu Kumar M [Wed, 28 Feb 2018 07:45:13 +0000 (07:45 +0000)]
Merge "Support csar object query"
Seshu Kumar M [Wed, 28 Feb 2018 07:43:56 +0000 (07:43 +0000)]
Merge "Add recipe params for bpmn call"
Seshu Kumar M [Wed, 28 Feb 2018 06:14:28 +0000 (06:14 +0000)]
Merge "Remove the unnecessary toString"
Seshu Kumar M [Wed, 28 Feb 2018 06:11:19 +0000 (06:11 +0000)]
Merge "Removed System.out.println from catch clause"
Seshu Kumar M [Wed, 28 Feb 2018 06:09:23 +0000 (06:09 +0000)]
Merge "Adding Junit"
Seshu Kumar M [Wed, 28 Feb 2018 06:08:40 +0000 (06:08 +0000)]
Merge "Adding Junit"
DeWayne Filppi [Tue, 27 Feb 2018 15:51:23 +0000 (15:51 +0000)]
Merge "Make use of getOrDefault"
c00149107 [Tue, 27 Feb 2018 09:09:18 +0000 (17:09 +0800)]
Support csar object query
Support csar object query, for model driven work flow.
Change-Id: I7207ad8081244d1c38fcdc9ee161d9d1204fdb4a
Issue-ID: SO-451
Signed-off-by: c00149107 <chenchuanyu@huawei.com>
c00149107 [Tue, 27 Feb 2018 01:43:05 +0000 (09:43 +0800)]
Add recipe params for bpmn call
Add recipe params for bpmn call, to improve recipe enhancement.
Change-Id: If9f2bff3f27ced62e814afcb918c863a527363e6
Issue-ID: SO-449
Signed-off-by: c00149107 <chenchuanyu@huawei.com>
Munir Ahmad [Tue, 27 Feb 2018 01:58:16 +0000 (20:58 -0500)]
Make use of getOrDefault
Change-Id: Ic73b58835a7964cb2fd88415f55b03ff79ad33ff
Issue-ID: SO-437
Signed-off-by: Munir Ahmad <munir.ahmad@bell.ca>
Munir Ahmad [Tue, 27 Feb 2018 01:40:23 +0000 (20:40 -0500)]
Removed System.out.println from catch clause
Change-Id: I957a2f8026ccfb88305461b9524ae861f958b27e
Issue-ID: SO-437
Signed-off-by: Munir Ahmad <munir.ahmad@bell.ca>
Munir Ahmad [Sat, 24 Feb 2018 18:12:56 +0000 (13:12 -0500)]
Make use of append instead of string concatenation
Change-Id: I94ad658026f165ba8b5a74352095188a27ee50e5
Issue-ID: SO-437
Signed-off-by: Munir Ahmad <munir.ahmad@bell.ca>
Munir Ahmad [Sat, 24 Feb 2018 17:52:03 +0000 (12:52 -0500)]
Remove the unnecessary toString
Change-Id: I32f5d3674583db900f7aa9b45af9fba0f8d9c06c
Issue-ID: SO-437
Signed-off-by: Munir Ahmad <munir.ahmad@bell.ca>
Sumapriya [Mon, 26 Feb 2018 10:59:57 +0000 (16:29 +0530)]
Adding Junit
Adding Junit for SDNCAdapterCallbackRequest.java
Sonar Link:
https://sonar.onap.org/code?id=org.openecomp.so%3Aso&selected=org.openecomp.so.adapters%3Amso-sdnc-adapter%3Asrc%2Fmain%2Fjava%2Forg%2Fopenecomp%2Fmso%2Fadapters%2Fsdnc%2Fclient%2FSDNCAdapterCallbackRequest.java
Change-Id: I8c84a7aadeeccb4288c89b026d5d815f97f7f9dd
Issue-ID: SO-447
Signed-off-by: Sumapriya <SS00493505@techmahindra.com>
AS00465059 [Mon, 26 Feb 2018 10:48:51 +0000 (16:18 +0530)]
Adding Junit
Junit for CallbackHeader.java
Sonar link:
https://sonar.onap.org/code?id=org.openecomp.so%3Aso&selected=org.openecomp.so.adapters%3Amso-sdnc-adapter%3Asrc%2Fmain%2Fjava%2Forg%2Fopenecomp%2Fmso%2Fadapters%2Fsdnc%2Fclient%2FCallbackHeader.java
Change-Id: Ic539c486d703f8376257b8bbc2166a3054c8007e
Issue-ID: SO-446
Signed-off-by: AS00465059 <AS00465059@techmahindra.com>
Seshu Kumar M [Mon, 26 Feb 2018 08:05:01 +0000 (08:05 +0000)]
Merge "Remove the unnecessary plus zero"
Seshu Kumar M [Mon, 26 Feb 2018 08:03:49 +0000 (08:03 +0000)]
Merge "Add the correct literal ending for long"
Seshu Kumar M [Mon, 26 Feb 2018 07:07:32 +0000 (07:07 +0000)]
Merge "Swap while loops with foreach where applicable"
Seshu Kumar M [Mon, 26 Feb 2018 07:04:25 +0000 (07:04 +0000)]
Merge "Add ARIA subtree to build"
Seshu Kumar M [Mon, 26 Feb 2018 06:58:20 +0000 (06:58 +0000)]
Merge "Unit test coverage"
Seshu Kumar M [Mon, 26 Feb 2018 06:57:27 +0000 (06:57 +0000)]
Merge "Support more Generic workflow for voLTE"
Munir Ahmad [Sat, 24 Feb 2018 17:50:45 +0000 (12:50 -0500)]
Remove the unnecessary plus zero
Change-Id: I86b43e8c8b9f4352c71d7d7073f8a345c7c9024c
Issue-ID: SO-437
Signed-off-by: Munir Ahmad <munir.ahmad@bell.ca>
Munir Ahmad [Sat, 24 Feb 2018 17:48:29 +0000 (12:48 -0500)]
Add the correct literal ending for long
Change-Id: I23744d6110c92aed98613aa5febb27abab033a34
Issue-ID: SO-437
Signed-off-by: Munir Ahmad <munir.ahmad@bell.ca>
Munir Ahmad [Sat, 24 Feb 2018 17:42:55 +0000 (12:42 -0500)]
Swap while loops with foreach where applicable
Change-Id: Id3b54e8192f0e60657aa4c50af56c1ef98fbff5e
Issue-ID: SO-437
Signed-off-by: Munir Ahmad <munir.ahmad@bell.ca>
Munir Ahmad [Sat, 24 Feb 2018 17:39:14 +0000 (12:39 -0500)]
Remove wrapping of primitive values in objects
Change-Id: I67b1229c7c8d0d82b94857f64a6547d9f57d16b8
Issue-ID: SO-437
Signed-off-by: Munir Ahmad <munir.ahmad@bell.ca>
Munir Ahmad [Sat, 24 Feb 2018 17:34:32 +0000 (12:34 -0500)]
Swap StringBuffer with StringBuilder everywhere
Change-Id: Ia1f8d3ebc4026179bf08cdb0bd71c4480b8481df
Issue-ID: SO-437
Signed-off-by: Munir Ahmad <munir.ahmad@bell.ca>
Munir Ahmad [Sat, 24 Feb 2018 17:24:11 +0000 (12:24 -0500)]
Swap for loop in favor of foreach
Change-Id: I04b3691abd958a1455f55b8b295a7f08998b8692
Issue-ID: SO-437
Signed-off-by: Munir Ahmad <munir.ahmad@bell.ca>
Munir Ahmad [Sat, 24 Feb 2018 17:20:27 +0000 (12:20 -0500)]
Replace explicit type with dimond everywhere
Change-Id: I2443c6d0f7dae2bf153da46b77bc95bba1c495c1
Issue-ID: SO-437
Signed-off-by: Munir Ahmad <munir.ahmad@bell.ca>
Munir Ahmad [Sat, 24 Feb 2018 17:15:43 +0000 (12:15 -0500)]
Make use of lambda for comparator
Change-Id: Iff3cf5202d754c926b010e1d1dd82418b42ae241
Issue-ID: SO-437
Signed-off-by: Munir Ahmad <munir.ahmad@bell.ca>
dfilppi [Thu, 22 Feb 2018 06:27:06 +0000 (06:27 +0000)]
Add ARIA subtree to build
Change-Id: I59a7038c00527330458458b6164cdf14ef8c82fe
Issue-ID: SO-444
Signed-off-by: DeWayne Filppi <dewayne@cloudify.co>
sanchitap [Fri, 23 Feb 2018 11:21:57 +0000 (16:51 +0530)]
Unit test coverage
Unit test coverage for
VduBlueprint.java
Sonar
link:https://sonar.onap.org/code?id=org.openecomp.so%3Aso&selected=org.openecomp.so.adapters%3Amso-vnf-adapter%3Asrc%2Fmain%2Fjava%2Forg%2Fopenecomp%2Fmso%2Fvdu%2Futils%2FVduBlueprint.java
Change-Id: I7e1fa874557449bf87fde0b9daca52f98239da2d
Issue-ID: SO-442
Signed-off-by: sanchitap <sanchita@techmahindra.com>
Lukasz Muszkieta [Thu, 22 Feb 2018 09:25:39 +0000 (10:25 +0100)]
add junit for cloud wrappers
Change-Id: I699b10ee2cb6e8b57ca56e8a9baae8aa41000540
Issue-ID: SO-430
Signed-off-by: Lukasz Muszkieta <lukasz.muszkieta@nokia.com>
c00149107 [Fri, 23 Feb 2018 08:10:56 +0000 (16:10 +0800)]
Support more Generic workflow for voLTE
Support more Generic workflow for voLTE
Change-Id: I44509eaa6a5db7e9fb02df8edaa0a4a50e5d1d49
Issue-ID: SO-438
Signed-off-by: c00149107 <chenchuanyu@huawei.com>
Seshu Kumar M [Fri, 23 Feb 2018 04:38:05 +0000 (04:38 +0000)]
Merge "ARIA REST client bugs"
Seshu Kumar M [Fri, 23 Feb 2018 04:37:04 +0000 (04:37 +0000)]
Merge "Support more Generic workflow for voLTE"
Arthur Martella [Thu, 22 Feb 2018 19:24:40 +0000 (14:24 -0500)]
Port SO artifacts to ONAP folder structure
Change-Id: Ib7aea4df7e6a31cf5e1e6513b89bed6f878537af
Issue-ID: SO-372
Signed-off-by: Arthur Martella <amartell@research.att.com>
Seshu Kumar M [Thu, 22 Feb 2018 06:26:57 +0000 (06:26 +0000)]
Merge "Boolean constructor call"
Seshu Kumar M [Thu, 22 Feb 2018 06:25:21 +0000 (06:25 +0000)]
Merge "Make use of addAll instead of loop"
Seshu Kumar M [Thu, 22 Feb 2018 06:09:06 +0000 (06:09 +0000)]
Merge "Swap String concatenation with StringBuilder"
Seshu Kumar M [Thu, 22 Feb 2018 06:05:00 +0000 (06:05 +0000)]
Merge "Remove redundant toString"
Seshu Kumar M [Thu, 22 Feb 2018 05:40:38 +0000 (05:40 +0000)]
Merge "Replace Collection.sort with List.sort"
Seshu Kumar M [Thu, 22 Feb 2018 05:10:53 +0000 (05:10 +0000)]
Merge "Select recipe for create service"
c00149107 [Thu, 22 Feb 2018 01:46:14 +0000 (09:46 +0800)]
Support more Generic workflow for voLTE
Support more Generic workflow for voLTE
Change-Id: I0005fffdb420709b597739173fa894981ac9c74e
Issue-ID: SO-438
Signed-off-by: c00149107 <chenchuanyu@huawei.com>
c00149107 [Thu, 22 Feb 2018 01:42:25 +0000 (09:42 +0800)]
Select recipe for create service
Select recipe for create service
Change-Id: I4109c775aef14d2621777bef3a6891b8a6cb8a05
Issue-ID: SO-438
Signed-off-by: c00149107 <chenchuanyu@huawei.com>
dfilppi [Wed, 21 Feb 2018 22:34:16 +0000 (22:34 +0000)]
ARIA REST client bugs
Change-Id: Ie3f1846589b5563707f4ab71406900c4f12ba0be
Issue-ID: SO-440
Signed-off-by: DeWayne Filppi <dewayne@cloudify.co>
Munir Ahmad [Wed, 21 Feb 2018 21:53:34 +0000 (16:53 -0500)]
Boolean constructor call
Change-Id: Ic5a16598b1f1ac4f53ab651064b872316abafde0
Issue-ID: SO-437
Signed-off-by: Munir Ahmad <munir.ahmad@bell.ca>
Munir Ahmad [Wed, 21 Feb 2018 21:50:36 +0000 (16:50 -0500)]
Make use of addAll instead of loop
Change-Id: Ia3afb3ecfec21e81982c4838bf019cc8e3ef55c1
Issue-ID: SO-437
Signed-off-by: Munir Ahmad <munir.ahmad@bell.ca>
Munir Ahmad [Wed, 21 Feb 2018 21:44:58 +0000 (16:44 -0500)]
Swap String concatenation with StringBuilder
Change-Id: I5c43d3267e5f75623bcc837e27c57a6ad6aa8877
Issue-ID: SO-437
Signed-off-by: Munir Ahmad <munir.ahmad@bell.ca>
Munir Ahmad [Wed, 21 Feb 2018 21:40:26 +0000 (16:40 -0500)]
Remove redundant toString
Change-Id: If039248f233e3aa53733aa1a888b571836ca9406
Issue-ID: SO-437
Signed-off-by: Munir Ahmad <munir.ahmad@bell.ca>
Munir Ahmad [Wed, 21 Feb 2018 21:25:03 +0000 (16:25 -0500)]
Replace Collection.sort with List.sort
Change-Id: Ie7f81c79ac334e5783c4b7f6e1f45e454e215cda
Issue-ID: SO-437
Signed-off-by: Munir Ahmad <munir.ahmad@bell.ca>
Seshu Kumar M [Wed, 21 Feb 2018 10:49:50 +0000 (10:49 +0000)]
Merge "Added unittests for ApplicationControllerSupport"
Seshu Kumar M [Wed, 21 Feb 2018 09:59:31 +0000 (09:59 +0000)]
Merge "add junit for AuthenticationMethodFactory"
Seshu Kumar M [Wed, 21 Feb 2018 09:57:48 +0000 (09:57 +0000)]
Merge "Sonar:Critical"
Seshu Kumar M [Wed, 21 Feb 2018 09:57:15 +0000 (09:57 +0000)]
Merge "Adding Junit "
Seshu Kumar M [Wed, 21 Feb 2018 09:56:30 +0000 (09:56 +0000)]
Merge "Optimize number of MsoLogger instances"
biniek [Tue, 20 Feb 2018 10:49:09 +0000 (11:49 +0100)]
Added unittests for ApplicationControllerSupport
Change-Id: Id128e23a545de353e13a18b85ac23dbdd685f2bf
Issue-ID: SO-374
Signed-off-by: biniek <lukasz.biniek@nokia.com>
AS00465059 [Wed, 21 Feb 2018 05:48:19 +0000 (11:18 +0530)]
Sonar:Critical
Fixing MsoCommonUtils.java
MsoCommonUtils.java: L130 L145
Link: https://sonar.onap.org/issues/search#resolved=false|severities=MAJOR|rules=squid%3AS2293|assignees=__me__
Location:src/main/java/org/openecomp/mso/openstack/utils/MsoCommonUtils.java
Change-Id: I120d35a9c06f56dd82b50f248062fc38e60c0819
Issue-ID: SO-401
Signed-off-by: AS00465059 <AS00465059@techmahindra.com>
Seshu Kumar M [Wed, 21 Feb 2018 05:15:07 +0000 (05:15 +0000)]
Merge "Added unittests"
dfilppi [Tue, 20 Feb 2018 23:27:13 +0000 (23:27 +0000)]
Added ability to PUT binary CSAR
Change-Id: Ib1dcad8b557cd543ecbf37c5e5947250ee0eb01e
Issue-ID: SO-429
Signed-off-by: DeWayne Filppi <dewayne@cloudify.co>
AS00465059 [Tue, 20 Feb 2018 07:07:52 +0000 (12:37 +0530)]
Adding Junit
Junit for SDNCAdapterRequest.java
Change-Id: I570ce3381b967e184601535558413826a5c0baf2
Issue-ID: SO-431
Signed-off-by: AS00465059 <AS00465059@techmahindra.com>
dfilppi [Fri, 16 Feb 2018 18:26:23 +0000 (18:26 +0000)]
Add Vdu plugin support
Change-Id: Icd47c120fff9c7ccc782c8c946b698c3f4a72ac0
Issue-ID: SO-428
Signed-off-by: DeWayne Filppi <dewayne@cloudify.co>
Usaraswat [Thu, 15 Feb 2018 15:51:41 +0000 (10:51 -0500)]
Optimize number of MsoLogger instances
Each call to getMsoLogger creates a new instance of MsoLogger
which is a potential memory leak
Change-Id: Ib0dda3abbf45d8633b4c8a2d49aa9d5c87e12931
Issue-ID: LOG-174
Signed-off-by: Usaraswat <saraswat.urwashi@amdocs.com>
biniek [Thu, 15 Feb 2018 10:44:11 +0000 (11:44 +0100)]
Added unittests
Added unittests for ResponseExecptionMapperImpl and refactored one test for CompleteMsoProcessTest
Issue-ID: SO-374
Signed-off-by: biniek <lukasz.biniek@nokia.com>
Change-Id: I359daf14d2a913829721fff3f2d340c6e893aa13
Signed-off-by: biniek <lukasz.biniek@nokia.com>
dfilppi [Wed, 14 Feb 2018 20:28:34 +0000 (20:28 +0000)]
Fixed build.
Change-Id: I48e69958b08767c14085fef5e9befb4b7f9a5875
Issue-ID: SO-426
Signed-off-by: DeWayne Filppi <dewayne@cloudify.co>
Seshu Kumar M [Sun, 11 Feb 2018 12:22:44 +0000 (12:22 +0000)]
Merge "Fix some Sonar Blocker issues in apihandler/common"
Seshu Kumar M [Fri, 9 Feb 2018 14:13:46 +0000 (14:13 +0000)]
Merge "add junit for MsoHeatEnvironmentEntry"
subhash kumar singh [Fri, 9 Feb 2018 13:40:20 +0000 (13:40 +0000)]
Imporve test coverage for RequestDatabase
Import test coverate for requestDatabase.
Change-Id: Idc25f9758ca4c4e03460642e9e2460f0b126726e
Issue-ID: SO-360
Signed-off-by: subhash kumar singh <subhash.kumar.singh@huawei.com>
Shashank Kumar Shankar [Mon, 5 Feb 2018 19:41:43 +0000 (11:41 -0800)]
Fix some Sonar Blocker issues in apihandler/common
Some sonar code fixes are done in this patch.
https://sonar.onap.org/issues/search#issues=AV3BntKO5bp_wwmIVCLv
https://sonar.onap.org/issues/search#issues=AV5mhwQk32hFUzlqebFJ
https://sonar.onap.org/issues/search#issues=AV3BntKc5bp_wwmIVCMJ
https://sonar.onap.org/issues/search#issues=AV3BntKi5bp_wwmIVCMK
https://sonar.onap.org/issues/search#issues=AV3BntKu5bp_wwmIVCMQ
https://sonar.onap.org/issues/search#issues=AV3BntK35bp_wwmIVCMX
https://sonar.onap.org/issues/search#issues=AV5mhwRN32hFUzlqebFQ
https://sonar.onap.org/issues/search#issues=AV3BntLG5bp_wwmIVCMc
https://sonar.onap.org/issues/search#issues=AV3BntLR5bp_wwmIVCMh
Change-Id: I3ba77adec1951fb7153ed640eb1ea0a4a3ed3e6b
Issue-ID: SO-165
Signed-off-by: Shashank Kumar Shankar <shashank.kumar.shankar@intel.com>
Seshu Kumar M [Thu, 8 Feb 2018 15:54:17 +0000 (15:54 +0000)]
Merge "Sonar:Critical"
Lukasz Muszkieta [Thu, 8 Feb 2018 12:00:12 +0000 (13:00 +0100)]
add junit for AuthenticationMethodFactory
Change-Id: I115792b73c62c50362a39fe45936fe294fe575dc
Issue-ID: SO-414
Signed-off-by: Lukasz Muszkieta <lukasz.muszkieta@nokia.com>
Seshu Kumar M [Thu, 8 Feb 2018 09:46:28 +0000 (09:46 +0000)]
Merge "refactoring - add Optional"
Manamohan Satapathy [Thu, 8 Feb 2018 04:43:40 +0000 (10:13 +0530)]
Sonar:Critical
Define and throw a dedicated exception instead of using a generic one:L39 L41 L43
Link: https://sonar.onap.org/component_issues/index?id=org.openecomp.so%3Aso#resolved=false|severities=CRITICAL|fileUuids=AV5mhvcK32hFUzlqebDQ
Location:src/main/java/org/openecomp/mso/client/aai/AAIRestClient.java
Change-Id: I606ff51c58ef22975222fc7fda04aab4680ac2de
Issue-ID: SO-399
Signed-off-by: Manamohan Satapathy <MS00534989@techmahindra.com>
Lukasz Muszkieta [Fri, 2 Feb 2018 17:06:01 +0000 (18:06 +0100)]
add junit for MsoHeatEnvironmentEntry
Change-Id: Ibc2b9562de8fbfdb60ee09add404bd3923431501
Issue-ID: SO-360
Signed-off-by: Lukasz Muszkieta <lukasz.muszkieta@nokia.com>
Seshu Kumar M [Wed, 7 Feb 2018 10:27:01 +0000 (10:27 +0000)]
Merge "Sonar blocker issue - closeableHttpClient"
liboNet [Mon, 5 Feb 2018 21:29:12 +0000 (05:29 +0800)]
Sonar blocker issue - closeableHttpClient
user the try-with-resource method to fix issue
https://sonar.onap.org/issues/search#issues=AV-B6Uh2-08if2a6r-Va
and https://sonar.onap.org/issues/search#issues=AV-B6Uh2-08if2a6r-Vb
Change-Id: I70a6424307e88c28a7290ed23d13888ef55c3aa3
Issue-ID: SO-165
Signed-off-by: Zhu Libo <libo.zhu@intel.com>
Seshu Kumar M [Wed, 7 Feb 2018 09:52:50 +0000 (09:52 +0000)]
Merge "Get Msb Ip from env parameter"
c00149107 [Wed, 7 Feb 2018 03:46:46 +0000 (11:46 +0800)]
Get Msb Ip from env parameter
Get Msb Ip from env parameter instead of config file.
Change-Id: I86e1664ffb4f817d70631f870c49a773bf04cc04
Issue-ID: SO-410
Signed-off-by: c00149107 <chenchuanyu@huawei.com>
Seshu Kumar M [Tue, 6 Feb 2018 12:09:38 +0000 (12:09 +0000)]
Merge "Sonar:Critical"
Seshu Kumar M [Tue, 6 Feb 2018 11:52:48 +0000 (11:52 +0000)]
Merge "Added unittests for RollbackData"
Seshu Kumar M [Tue, 6 Feb 2018 11:51:56 +0000 (11:51 +0000)]
Merge "Refactor of DecomposeJsonUtils class."
Sumapriya Sarvepalli [Tue, 6 Feb 2018 11:00:19 +0000 (16:30 +0530)]
Sonar:Critical
Define and throw a dedicated exception instead of using a generic one
ApplicationControllerClient.java:L79 L121 L132
Link: https://sonar.onap.org/account/issues#resolved=false|rules=squid%3AS00112
Location:src/main/java/org/openecomp/mso/client/appc/ApplicationControllerClient.java
Change-Id: Iba0d52ad2310fed17bb1012611e4ca0bf0ae2180
Issue-ID: SO-400
Signed-off-by: Sumapriya Sarvepalli <SS00493505@TechMahindra.com>
Seshu Kumar M [Tue, 6 Feb 2018 07:13:48 +0000 (07:13 +0000)]
Merge "Sonar:Major"
biniek [Wed, 31 Jan 2018 11:59:37 +0000 (12:59 +0100)]
Added unittests for RollbackData
Change-Id: I3c6f3b204e3cea6acce643f023f73561765226ee
Issue-ID: SO-374
Signed-off-by: biniek <lukasz.biniek@nokia.com>
Lukasz Muszkieta [Tue, 30 Jan 2018 13:02:49 +0000 (14:02 +0100)]
add junit for StackInfo
Change-Id: I80e60b590d761c30fd2c71e259c2b4f5cf53b508
Issue-ID: SO-360
Signed-off-by: Lukasz Muszkieta <lukasz.muszkieta@nokia.com>
Seshu Kumar M [Wed, 31 Jan 2018 09:31:07 +0000 (09:31 +0000)]
Merge "Sonar:Major"
Seshu Kumar M [Wed, 31 Jan 2018 09:30:35 +0000 (09:30 +0000)]
Merge "Sonar:Major"
Seshu Kumar M [Wed, 31 Jan 2018 09:23:42 +0000 (09:23 +0000)]
Merge "Sonar:Major"
Seshu Kumar M [Wed, 31 Jan 2018 08:49:16 +0000 (08:49 +0000)]
Merge "Same Service names under two different Customers"
Sumapriya Sarvepalli [Wed, 31 Jan 2018 07:04:53 +0000 (12:34 +0530)]
Sonar:Major
The diamond operator (<>) should be used
OrchestrationRequests.java:L163
Link: https://sonar.onap.org/issues/search#resolved=false|severities=MAJOR|rules=squid%3AS2293|assignees=__me__
Location:OrchestrationRequests.java:L163
Change-Id: I2b3241d46d72b9ad52f2009dc7746cf4a3f456ea
Issue-ID: SO-397
Signed-off-by: Sumapriya Sarvepalli <SS00493505@TechMahindra.com>
Manamohan Satapathy [Tue, 30 Jan 2018 12:14:33 +0000 (17:44 +0530)]
Sonar:Major
Add the @Override annotation above this method signature:L145
Issue-ID: SO-395
Link: https://sonar.onap.org/component_issues/index?id=org.openecomp.so%3Aso#resolved=false|severities=MAJOR|rules=squid%3AS1161
Location:src/main/java/org/openecomp/mso/bpmn/core/domain/JsonWrapper.java
Change-Id: Ifb0d6ee37ec3b935326d7aed7cc50e8b79aa0df5
Signed-off-by: Manamohan Satapathy <MS00534989@techmahindra.com>
Seshu Kumar M [Tue, 30 Jan 2018 12:01:21 +0000 (12:01 +0000)]
Merge "Sonar:Major"
Seshu Kumar M [Tue, 30 Jan 2018 11:58:53 +0000 (11:58 +0000)]
Merge "Default Recipe Mapping for Service"
Manamohan Satapathy [Tue, 30 Jan 2018 06:28:12 +0000 (11:58 +0530)]
Sonar:Major
Add the @Override annotation above this method signature.java:L92
Issue-ID: SO-394
Link: https://sonar.onap.org/component_issues/index?id=org.openecomp.so%3Aso#resolved=false|severities=MAJOR|rules=squid%3AS1161
Location:src/main/java/org/openecomp/mso/bpmn/core/RollbackData.java
Change-Id: Ib3d56f82b1a21df201fe2f9558f2b33004033c7e
Signed-off-by: Manamohan Satapathy <MS00534989@techmahindra.com>
Azhar Sardar Sayyed [Tue, 30 Jan 2018 06:26:34 +0000 (11:56 +0530)]
Sonar:Major
Add the @Override annotation
LoggingAndURNMappingPlugin.java:L326
Sonar Link:https://sonar.onap.org/component_issues/index?id=org.openecomp.so%3Aso#resolved=false|severities=MAJOR|rules=squid%3AS1161
Location:LoggingAndURNMappingPlugin.java:L326
Change-Id: I047385bdf582a8c07998243ce25f9f669ce20765
Issue-ID: SO-396
Signed-off-by: Azhar Sardar Sayyed <AS00465059@TechMahindra.com>
Seshu Kumar M [Mon, 29 Jan 2018 15:05:48 +0000 (15:05 +0000)]
Merge "add JUnit for NetworkInfo"
Seshu Kumar M [Mon, 29 Jan 2018 15:02:57 +0000 (15:02 +0000)]
Merge "Unittest refactoring."
biniek [Tue, 23 Jan 2018 13:43:24 +0000 (14:43 +0100)]
Refactor of DecomposeJsonUtils class.
Change-Id: I72b779eb17ffb901266de605eb2eda49f13bd03e
Issue-ID: SO-374
Signed-off-by: biniek <lukasz.biniek@nokia.com>
Lukasz Muszkieta [Mon, 8 Jan 2018 11:40:46 +0000 (12:40 +0100)]
refactoring - add Optional
change possible null return value to Optional
Change-Id: I70bf78a51b901a74932b00d1d8735bef5eeacef7
Issue-ID: SO-360
Signed-off-by: Lukasz Muszkieta <lukasz.muszkieta@nokia.com>
Sumapriya Sarvepalli [Mon, 29 Jan 2018 10:07:18 +0000 (15:37 +0530)]
Sonar:Major
The diamond operator (<>) should be used
NsParameters.java:L38
Issue-ID: SO-392
Link: https://sonar.onap.org/issues/search#resolved=false|severities=MAJOR|rules=squid%3AS2293|assignees=__me__
Location:src/main/java/org/openecomp/mso/adapters/vfc/model/NsParameters.java
Change-Id: I12ec3ceb4b7da8c5cccc0e01205addce6c2c0d1e
Signed-off-by: Sumapriya Sarvepalli <SS00493505@TechMahindra.com>
Seshu Kumar M [Mon, 29 Jan 2018 06:23:20 +0000 (06:23 +0000)]
Merge changes Ie0f9c31f,I1fbe5516,I4beee70d,Ib9c5dad0,I80eb6d4f
* changes:
Improve UT for catalog db
Improve UT for catalog db
Improve UT for catalog db
Improve UT for catalog db
Improve UT for catalog db
Code Review / so.git / log