Code Review / sdc.git / log
? search:
summary | shortlog | log | commit | commitdiff | review | tree
first ⋅ prev ⋅ next
sdc.git
6 years agoFix for csit 95/28195/3
commit | commitdiff | tree
Yuli Shlosberg [Mon, 15 Jan 2018 15:32:30 +0000 (17:32 +0200)]
Fix for csit

update docker_run
add pass suite

Change-Id: Id8e91aa18123f9e3d8d0705bae78b128bbb3a790
Issue-ID: SDC-608
Signed-off-by: Yuli Shlosberg <ys9693@att.com>
6 years agoAdding owner id to onboarding tiles 79/28179/2
commit | commitdiff | tree
svishnev [Mon, 15 Jan 2018 12:44:48 +0000 (14:44 +0200)]
Adding owner id to onboarding tiles

Issue-ID: SDC-930
Change-Id: If8e66f45f088950acfef8dd7a5a43eb97d0de9ab
Signed-off-by: svishnev <shlomo-stanisla.vishnevetskiy@amdocs.com>
6 years agoContributor can also submit fix 83/28183/1
commit | commitdiff | tree
svishnev [Mon, 15 Jan 2018 13:55:53 +0000 (15:55 +0200)]
Contributor can also submit fix

Issue-ID: SDC-931
Change-Id: Ic2f67552614e8236b3e19a6a205b699e36947968
Signed-off-by: svishnev <shlomo-stanisla.vishnevetskiy@amdocs.com>
6 years agoFix for csit 71/28171/2
commit | commitdiff | tree
Yuli Shlosberg [Mon, 15 Jan 2018 09:51:21 +0000 (11:51 +0200)]
Fix for csit

update docker_run
add pass suite

Change-Id: Ided3f606a59eb24589c1de494cafe29ea6af3486
Issue-ID: SDC-608
Signed-off-by: Yuli Shlosberg <ys9693@att.com>
6 years agoMove CompositionEntityDataManager to vsp-mgr 97/27297/3
commit | commitdiff | tree
talig [Mon, 15 Jan 2018 07:27:43 +0000 (09:27 +0200)]
Move CompositionEntityDataManager to vsp-mgr

Change-Id: I71d9126e6d32b57a0b7d8b93952992423632ef37
Issue-ID: SDC-873
Signed-off-by: talig <talig@amdocs.com>
6 years agoMinor refactor of logging API 19/28119/1
commit | commitdiff | tree
vempo [Sun, 14 Jan 2018 14:01:12 +0000 (16:01 +0200)]
Minor refactor of logging API

Change-Id: I926ba95c7145eb98aade3f9009a252ad995a346d
Issue-ID: SDC-772
Signed-off-by: vempo <vitaliy.emporopulo@amdocs.com>
6 years agoReact version upgrade 33/27833/2
commit | commitdiff | tree
svishnev [Thu, 11 Jan 2018 12:39:45 +0000 (14:39 +0200)]
React version upgrade

Issue-ID: SDC-894
Change-Id: I7c200a4b0b1d09a8fec638906db4258cafe252b5
Signed-off-by: svishnev <shlomo-stanisla.vishnevetskiy@amdocs.com>
6 years agoRemoved addDir method which is not used 11/27811/3
commit | commitdiff | tree
vempo [Wed, 10 Jan 2018 15:57:39 +0000 (17:57 +0200)]
Removed addDir method which is not used

Since this method is a package private method which is not used we
decided to delete it.

Change-Id: If2b303f97746b458b6d4c0e4e320fef3fc4962ae
Issue-ID: SDC-886
Signed-off-by: vempo <vitaliy.emporopulo@amdocs.com>
Signed-off-by: ya107f <ya107f@intl.att.com>
6 years agoFix ToscaFileOutputServiceCsarImplTest 53/27953/2
commit | commitdiff | tree
Abhai Singh [Thu, 11 Jan 2018 11:26:57 +0000 (16:56 +0530)]
Fix ToscaFileOutputServiceCsarImplTest

Above mentioned test class has tests with shared state
and can fail unexpectedly during parallel execution.

Change-Id: I97772caaba60afca15f62166ba3b1c1d939bcc14
Issue-ID: SDC-904
Signed-off-by: Abhai Singh <Abhai.Singh@amdocs.com>
6 years agoDeleted no longer needed logging files 25/27825/2
commit | commitdiff | tree
vempo [Wed, 10 Jan 2018 13:12:22 +0000 (15:12 +0200)]
Deleted no longer needed logging files

Change-Id: I0a214f9572c3acabc374154ffcaca71308dfd26b
Issue-ID: SDC-772
Signed-off-by: vempo <vitaliy.emporopulo@amdocs.com>
6 years agoRemoved SLF4J from logging API 55/27855/1
commit | commitdiff | tree
vempo [Wed, 10 Jan 2018 19:30:05 +0000 (21:30 +0200)]
Removed SLF4J from logging API

Change-Id: Icc1ae76ff3945d9965e2beafb2fe53fe911d0d4c
Issue-ID: SDC-772
Signed-off-by: vempo <vitaliy.emporopulo@amdocs.com>
6 years agoZipOutputStream Cleanup 37/27637/4
commit | commitdiff | tree
ya107f [Mon, 8 Jan 2018 12:04:44 +0000 (14:04 +0200)]
ZipOutputStream Cleanup

Enclose ZipOutputStream handling with try with resources block for
proper stream cleanup.

Change-Id: I2565ef411519f127208a4f966001edf735cb68c0
Signed-off-by: ya107f <ya107f@intl.att.com>
Issue-ID: SDC-886
Signed-off-by: vempo <vitaliy.emporopulo@amdocs.com>
6 years agoFail to Export VLM 21/27721/2
commit | commitdiff | tree
shrek2000 [Tue, 9 Jan 2018 14:00:28 +0000 (16:00 +0200)]
Fail to Export VLM

Timestamps had null value, invalid json caused exceptions
Issue-ID: SDC-892

Change-Id: Iab117dd76cd51c3cd5fa62a59f55b18e265c58bf
Signed-off-by: shrek2000 <orenkle@amdocs.com>
6 years agoFixed Lifefcycle operation issue 15/27815/2
commit | commitdiff | tree
amitjai [Wed, 10 Jan 2018 09:32:59 +0000 (15:02 +0530)]
Fixed Lifefcycle operation issue

Artifact Process Entity is not populating with all filed hence nullpointer exception while writing artifact file.

Change-Id: Ie26982471c25fc6c1a38bbe8a0e07efa7b33577d
Issue-ID: SDC-896
Signed-off-by: amitjai <amitjai@amdocs.com>
6 years agoMerged two MDC related classes 05/27805/2
commit | commitdiff | tree
vempo [Wed, 10 Jan 2018 08:01:27 +0000 (10:01 +0200)]
Merged two MDC related classes

Change-Id: I0efda7c99972ce133e2a4045b1ac07fe062d6445
Issue-ID: SDC-772
Signed-off-by: vempo <vitaliy.emporopulo@amdocs.com>
6 years agoRemoved unused code in logger 17/27817/1
commit | commitdiff | tree
vempo [Wed, 10 Jan 2018 09:44:21 +0000 (11:44 +0200)]
Removed unused code in logger

Change-Id: I04da65e3470d6444dd77a52a7c8371811d0941b6
Issue-ID: SDC-772
Signed-off-by: vempo <vitaliy.emporopulo@amdocs.com>
6 years agoFix sonar issues - ExternalArtifactEnricher 27/27627/2
commit | commitdiff | tree
siddharth0905 [Mon, 8 Jan 2018 08:12:28 +0000 (13:42 +0530)]
Fix sonar issues - ExternalArtifactEnricher

marked one variable as constant

Change-Id: I9365af2de48e6c9e46a890aca2ebff99ae42ac94
Issue-ID: SDC-343
Signed-off-by: siddharth0905 <siddharth.singh4@amdocs.com>
6 years agoFix sonar issues - ConfigurationManager 15/27615/3
commit | commitdiff | tree
siddharth0905 [Mon, 8 Jan 2018 06:35:36 +0000 (12:05 +0530)]
Fix sonar issues - ConfigurationManager

Made changes as per comments and replied to one comment

Change-Id: If20c5a61ffdb4887b9baa4c049cabdf67c350fa3
Issue-ID: SDC-343
Signed-off-by: siddharth0905 <siddharth.singh4@amdocs.com>
6 years agosonar fix - Stack 39/27639/2
commit | commitdiff | tree
shrek2000 [Mon, 8 Jan 2018 14:08:42 +0000 (16:08 +0200)]
sonar fix - Stack

Stack is thread safe. For this code block ArrayDeque is good enough.
Issue-ID: SDC-888

Change-Id: Ieddb750ae08626ba73f1e5c92f630a0ba7fe447c
Signed-off-by: shrek2000 <orenkle@amdocs.com>
6 years agoUI support for Togglz flow 91/27591/3
commit | commitdiff | tree
svishnev [Mon, 8 Jan 2018 13:21:46 +0000 (15:21 +0200)]
UI support for Togglz flow

Issue-ID: SDC-881
Change-Id: I4423d1ee115003aff0bd9d988b25a8260811928b
Signed-off-by: svishnev <shlomo-stanisla.vishnevetskiy@amdocs.com>
6 years agoAdd Togglz REST API 89/27589/9
commit | commitdiff | tree
vempo [Tue, 9 Jan 2018 12:25:08 +0000 (14:25 +0200)]
Add Togglz REST API

Supporting REST API, and Javascript for Togglz
Issue-ID: SDC-881

Change-Id: I026d3f190cb95c8943a85b26dfbcd13e856abe64
Signed-off-by: shrek2000 <orenkle@amdocs.com>
(cherry picked from commit 5a33f027cd2bc4253d5ebb7a71889ead65d095b2)
Signed-off-by: vempo <vitaliy.emporopulo@amdocs.com>
6 years agoAdded logging context service, refactoring 93/27593/9
commit | commitdiff | tree
vempo [Mon, 8 Jan 2018 18:59:19 +0000 (20:59 +0200)]
Added logging context service, refactoring

Change-Id: Ib040d4579107b60c8da2c7a6da829f49c1cd8dd4
Issue-ID: SDC-772
Signed-off-by: vempo <vitaliy.emporopulo@amdocs.com>
6 years agoFix sonar issues - ConsolidationTypesConnectivity 17/27617/2
commit | commitdiff | tree
siddharth0905 [Mon, 8 Jan 2018 07:16:22 +0000 (12:46 +0530)]
Fix sonar issues - ConsolidationTypesConnectivity

Private constructor and changed HashMap->EnumMap

Change-Id: I9739ecd2726cdca8815c700a242b0036c011b9c0
Issue-ID: SDC-343
Signed-off-by: siddharth0905 <siddharth.singh4@amdocs.com>
6 years agoFix sonar issues - JsonUtil 31/27631/2
commit | commitdiff | tree
siddharth0905 [Mon, 8 Jan 2018 09:06:29 +0000 (14:36 +0530)]
Fix sonar issues - JsonUtil

Private constructor and Changed StringBuffer to StringBuilder

Change-Id: I5fdd520654c0ba00f54c66f2d4a96e60ee2b496e
Issue-ID: SDC-343
Signed-off-by: siddharth0905 <siddharth.singh4@amdocs.com>
6 years agoChange variable names to catalog 89/27689/2
commit | commitdiff | tree
ilanap [Mon, 8 Jan 2018 13:50:18 +0000 (15:50 +0200)]
Change variable names to catalog

Change-Id: Iaa4f2143840de47feaf25d110144cd762f6ff8ec
Issue-ID: SDC-887
Signed-off-by: ilanap <ilanap@amdocs.com>
6 years agoFix sonar issues - CassandraSessionFactory 09/27609/2
commit | commitdiff | tree
siddharth0905 [Mon, 8 Jan 2018 06:35:36 +0000 (12:05 +0530)]
Fix sonar issues - CassandraSessionFactory

Rearrange code

Change-Id: I076403fd22790fd0e64fc51d3118e5a436941b61
Issue-ID: SDC-343
Signed-off-by: siddharth0905 <siddharth.singh4@amdocs.com>
6 years agoFixed sonar issues - ToscaAnalyzerServiceImpl 37/27037/5
commit | commitdiff | tree
sheetalm [Sun, 7 Jan 2018 17:06:47 +0000 (19:06 +0200)]
Fixed sonar issues - ToscaAnalyzerServiceImpl

Resolve code review comments.Fixed cyclomatic complexity and nested
try/if/else issues. Corrected Copyright. Added junit for changes done
as part of sonar fix.

Change-Id: If7ecc53acd82c49ab5ca73f0330a792fc1fc6d5c
Issue-ID: SDC-343
Signed-off-by: sheetalm <sheetal.mudholkar@amdocs.com>
6 years agoexpose timeout setting 29/27629/3
commit | commitdiff | tree
Michael Lando [Mon, 8 Jan 2018 08:52:07 +0000 (10:52 +0200)]
expose timeout setting

expose setting of time out in env.json
remove the hard codeing of password in the configuration,
cs password is set using the envjson.

Change-Id: I09cc1f99914f444900e6b73d2ae438c72527ba2c
Issue-ID: SDC-833
Signed-off-by: Michael Lando <ml636r@att.com>
6 years agoRefactored - VendorSoftwareProductsImpl 37/27337/3
commit | commitdiff | tree
mojahidi [Thu, 4 Jan 2018 07:08:04 +0000 (12:38 +0530)]
Refactored  - VendorSoftwareProductsImpl

Refactored as per given comment

Change-Id: I6f075390f2ffdb16c80844e0ab809c3ed59478fb
Issue-ID: SDC-343
Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
6 years agoImprove ConfigurationUtils class 87/27587/2
commit | commitdiff | tree
shrek2000 [Sun, 7 Jan 2018 14:00:19 +0000 (16:00 +0200)]
Improve ConfigurationUtils class

Making getArrayClass more readable
Issue-ID: SDC-879
Change-Id: I64d261a736056aacd5b1410a0ffa70bb8fee2eed
Signed-off-by: shrek2000 <orenkle@amdocs.com>
6 years agoFix swagger basepath 95/27595/1
commit | commitdiff | tree
Tal Gitelman [Sun, 7 Jan 2018 17:06:47 +0000 (19:06 +0200)]
Fix swagger basepath

Change-Id: I59263971e1c46096663322ecb2937a79c084cf10
Issue-ID: SDC-534
Signed-off-by: Tal Gitelman <tg851x@intl.att.com>
6 years agoFix issue Null pointer exception 07/27407/3
commit | commitdiff | tree
amitjai [Thu, 4 Jan 2018 13:22:19 +0000 (18:52 +0530)]
Fix issue Null pointer exception

If feature group list is empty or null we should ignore check.

Change-Id: I6fcf20501353f6f32ad166a6096074f4f393dd00
Issue-ID: SDC-876
Signed-off-by: amitjai <amitjai@amdocs.com>
6 years agoEnable vsp manager unit tests 83/27583/2
commit | commitdiff | tree
talig [Sun, 7 Jan 2018 08:30:35 +0000 (10:30 +0200)]
Enable vsp manager unit tests

Change-Id: I2f57c0d8206b94d502132e0a8a6f811328a794c6
Issue-ID: SDC-860
Signed-off-by: talig <talig@amdocs.com>
6 years agoDeleted - ComponentUploadsImpl 17/27517/1
commit | commitdiff | tree
mojahidi [Fri, 5 Jan 2018 10:16:52 +0000 (15:46 +0530)]
Deleted  - ComponentUploadsImpl

Deleted commented class

Change-Id: I1279755a1e9eaf2a6f92901c7586cacbe68734fe
Issue-ID: SDC-343
Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
6 years agoDelete redundant test and mocks 77/27377/2
commit | commitdiff | tree
talig [Thu, 4 Jan 2018 11:41:40 +0000 (13:41 +0200)]
Delete redundant test and mocks

Change-Id: I86fb039161a14f3d0dccc124fcc9b6f585912859
Issue-ID: SDC-860
Signed-off-by: talig <talig@amdocs.com>
6 years agoRemove enter/exit debug #8 51/27451/5
commit | commitdiff | tree
vempo [Thu, 4 Jan 2018 21:22:28 +0000 (23:22 +0200)]
Remove enter/exit debug #8

Change-Id: Ib075b5b42498bfe8d7fc0368e078adeead340e34
Issue-ID: SDC-875
Signed-off-by: vempo <vitaliy.emporopulo@amdocs.com>
6 years agoRemove enter/exit debug #7 49/27449/5
commit | commitdiff | tree
vempo [Thu, 4 Jan 2018 16:46:27 +0000 (18:46 +0200)]
Remove enter/exit debug #7

Change-Id: Iae9f758442a7f656a8f5ed76404106cd14ef985e
Issue-ID: SDC-875
Signed-off-by: vempo <vitaliy.emporopulo@amdocs.com>
6 years agoRemove enter/exit debug #3 41/27441/4
commit | commitdiff | tree
vempo [Thu, 4 Jan 2018 16:45:51 +0000 (18:45 +0200)]
Remove enter/exit debug #3

Change-Id: If2ea8d16a1fd1867b4b314290fdcfaeafef93c19
Issue-ID: SDC-875
Signed-off-by: vempo <vitaliy.emporopulo@amdocs.com>
6 years agoFixing sonar qube issues 03/27403/3
commit | commitdiff | tree
shrikantawachar [Thu, 4 Jan 2018 14:27:04 +0000 (19:57 +0530)]
Fixing sonar qube issues

Refactored the code as per review comment in DefaultExceptionMapper.java file.

Change-Id: I23c43e52e444cbd26b9c6bcf1c060f0f8b8f8204
Issue-ID: SDC-343
Signed-off-by: shrikantawachar <shrikant.awachar@amdocs.com>
6 years agoRemove enter/exit debug #10 55/27455/2
commit | commitdiff | tree
vempo [Thu, 4 Jan 2018 16:46:54 +0000 (18:46 +0200)]
Remove enter/exit debug #10

Change-Id: I5d3e97ba5fe050e5420e02c92cddca6742e55c5e
Issue-ID: SDC-875
Signed-off-by: vempo <vitaliy.emporopulo@amdocs.com>
6 years agoRemove enter/exit debug #5 45/27445/2
commit | commitdiff | tree
vempo [Thu, 4 Jan 2018 16:46:09 +0000 (18:46 +0200)]
Remove enter/exit debug #5

Change-Id: I756f8fc8ae24fe7840e9189274ea749c5555dc78
Issue-ID: SDC-875
Signed-off-by: vempo <vitaliy.emporopulo@amdocs.com>
6 years agoRemove enter/exit debug #4 43/27443/2
commit | commitdiff | tree
vempo [Thu, 4 Jan 2018 16:46:01 +0000 (18:46 +0200)]
Remove enter/exit debug #4

Change-Id: I99cef676015533d9cfe66f5a5371da49856500dc
Issue-ID: SDC-875
Signed-off-by: vempo <vitaliy.emporopulo@amdocs.com>
6 years agoRemove enter/exit debug #2 39/27439/2
commit | commitdiff | tree
vempo [Thu, 4 Jan 2018 16:45:43 +0000 (18:45 +0200)]
Remove enter/exit debug #2

Change-Id: Id1bbe1c57c08271991b10053f778d6473cd27a01
Issue-ID: SDC-875
Signed-off-by: vempo <vitaliy.emporopulo@amdocs.com>
6 years agoRemove enter/exit debug #9 53/27453/2
commit | commitdiff | tree
vempo [Thu, 4 Jan 2018 16:46:45 +0000 (18:46 +0200)]
Remove enter/exit debug #9

Change-Id: I8a6fb5be912834fc0c684c6ba5d076bec00fc92c
Issue-ID: SDC-875
Signed-off-by: vempo <vitaliy.emporopulo@amdocs.com>
6 years agoRemove enter/exit debug #1 37/27437/2
commit | commitdiff | tree
vempo [Thu, 4 Jan 2018 16:45:34 +0000 (18:45 +0200)]
Remove enter/exit debug #1

Change-Id: I1271f6b0beb8c45881d90b08763d08892092e7d3
Issue-ID: SDC-875
Signed-off-by: vempo <vitaliy.emporopulo@amdocs.com>
6 years agoRemove enter/exit debug #6 47/27447/1
commit | commitdiff | tree
vempo [Thu, 4 Jan 2018 16:46:18 +0000 (18:46 +0200)]
Remove enter/exit debug #6

Change-Id: Ic9d9ebfabc52c6d1bd785e6b0f9d1ecc177f996e
Issue-ID: SDC-875
Signed-off-by: vempo <vitaliy.emporopulo@amdocs.com>
6 years agoFixing sonar qube issues 17/27417/2
commit | commitdiff | tree
shrikantawachar [Thu, 4 Jan 2018 14:27:04 +0000 (19:57 +0530)]
Fixing sonar qube issues

Fixed minor issue and updated license header in MappingBase file. One major issue warning of converting MappingBase from abstract class to interface has not fixed because it involes changes in lot of other files whereever MappingBase is used or referred.

Change-Id: I5c2fe8d0ec1a21ea0fd931b45f2f9804d81de498
Issue-ID: SDC-343
Signed-off-by: shrikantawachar <shrikant.awachar@amdocs.com>
6 years agoFixing sonar qube issues 97/27397/3
commit | commitdiff | tree
shrikantawachar [Thu, 4 Jan 2018 13:11:55 +0000 (18:41 +0530)]
Fixing sonar qube issues

Fixed major issue in StringWrapperResponse file , updated license header.

Change-Id: Iba74d0398caa60c12914f42d5c3f09fe95c3f109
Issue-ID: SDC-343
Signed-off-by: shrikantawachar <shrikant.awachar@amdocs.com>
6 years agoFixing sonar qube issues 99/27399/2
commit | commitdiff | tree
shrikantawachar [Thu, 4 Jan 2018 13:15:40 +0000 (18:45 +0530)]
Fixing sonar qube issues

Fixed major issue and updated license header in RestConstants file.

Change-Id: Ia842bd5728068c769e810475cf1b1dab8e3f12e4
Issue-ID: SDC-343
Signed-off-by: shrikantawachar <shrikant.awachar@amdocs.com>
6 years agoFixed sonar issues - MapDeploymentFlavorEntityToD 83/27383/2
commit | commitdiff | tree
mojahidi [Thu, 4 Jan 2018 12:20:24 +0000 (17:50 +0530)]
Fixed sonar issues - MapDeploymentFlavorEntityToD

Removed commented code in MapDeploymentFlavorEntityToDeploymentFlavorDto

Change-Id: Icc70d1c1bea3f92d3206f283e2aca149f35813ba
Issue-ID: SDC-343
Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
6 years agoFix VspZusammenUtil 13/27413/2
commit | commitdiff | tree
Abhai Singh [Thu, 4 Jan 2018 14:02:47 +0000 (19:32 +0530)]
Fix VspZusammenUtil

Fixed reported sonar issue

Change-Id: I898ebd3f30ce326d9f626611d049ee2a5e9f61bf
Issue-ID: SDC-343
Signed-off-by: Abhai Singh <Abhai.Singh@amdocs.com>
6 years agoFixing sonar qube issues 11/27411/2
commit | commitdiff | tree
shrikantawachar [Thu, 4 Jan 2018 14:01:29 +0000 (19:31 +0530)]
Fixing sonar qube issues

Fixed major issues and updated license header in EchoMapMapping.java.

Change-Id: I9d50522466c2e4ea9e723488deb3a9da4cc98b2c
Issue-ID: SDC-343
Signed-off-by: shrikantawachar <shrikant.awachar@amdocs.com>
6 years agoFix VendorSoftwareProductInfoDaoImpl 09/27409/2
commit | commitdiff | tree
Abhai Singh [Thu, 4 Jan 2018 13:55:16 +0000 (19:25 +0530)]
Fix VendorSoftwareProductInfoDaoImpl

Removed the file since it is not being referenced and is
replaced by VendorSoftwareProductInfoDaoZusammenImpl

Change-Id: Ida3fdb6a46df540c0ee38481609752a44b47b1cd
Issue-ID: SDC-343
Signed-off-by: Abhai Singh <Abhai.Singh@amdocs.com>
6 years agoFix VendorSoftwareProductErrorCodes 05/27405/2
commit | commitdiff | tree
Abhai Singh [Thu, 4 Jan 2018 13:37:11 +0000 (19:07 +0530)]
Fix VendorSoftwareProductErrorCodes

Fixed reported sonar issues

Change-Id: I48dfd9333ec0ce5bb105c13e7fcd648290236bf2
Issue-ID: SDC-343
Signed-off-by: Abhai Singh <Abhai.Singh@amdocs.com>
6 years agoFixing sonar qube issues 93/27393/2
commit | commitdiff | tree
shrikantawachar [Thu, 4 Jan 2018 12:58:06 +0000 (18:28 +0530)]
Fixing sonar qube issues

VersioningAction.java is not used anywhere hence deleting this file.

Change-Id: I0a585734c9b4b9d7e6833450cdfc3f03ac9b49f3
Issue-ID: SDC-343
Signed-off-by: shrikantawachar <shrikant.awachar@amdocs.com>
6 years agoFixed sonar issues - VendorSoftwareProductUtils 95/27295/3
commit | commitdiff | tree
mojahidi [Wed, 3 Jan 2018 14:36:06 +0000 (20:06 +0530)]
Fixed sonar issues - VendorSoftwareProductUtils

Removed unused methods and method parameters

Change-Id: Ie221c5bfd939db74c15db7d12cff9b41059eb86c
Issue-ID: SDC-343
Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
6 years agoFixing sonar qube issues 95/27395/2
commit | commitdiff | tree
shrikantawachar [Thu, 4 Jan 2018 13:03:53 +0000 (18:33 +0530)]
Fixing sonar qube issues

EchoMapping.java is not used anywhere hence deleting it.

Change-Id: Ifb26e29bacdd62d1137184b50b0b83a6fb2896e5
Issue-ID: SDC-343
Signed-off-by: shrikantawachar <shrikant.awachar@amdocs.com>
6 years agoFix ProcessDaoZusammenImpl 85/27385/2
commit | commitdiff | tree
Abhai Singh [Thu, 4 Jan 2018 12:30:25 +0000 (18:00 +0530)]
Fix ProcessDaoZusammenImpl

Fixed reported sonar issues

Change-Id: Id53e3ab1d70e17dd1a7a10cca3c9ee627fef4771
Issue-ID: SDC-343
Signed-off-by: Abhai Singh <Abhai.Singh@amdocs.com>
6 years agoFix QuestionnaireDataServiceImpl 87/27387/2
commit | commitdiff | tree
Abhai Singh [Thu, 4 Jan 2018 12:36:12 +0000 (18:06 +0530)]
Fix QuestionnaireDataServiceImpl

Fixed reported sonar issues

Change-Id: I921dc63d9d6d5f85d0553c005cef27cc5aabe531
Issue-ID: SDC-343
Signed-off-by: Abhai Singh <Abhai.Singh@amdocs.com>
6 years agoFix Sonar Issues 95/26095/7
commit | commitdiff | tree
Aravindhan123 [Tue, 12 Dec 2017 09:25:31 +0000 (14:55 +0530)]
Fix Sonar Issues

Handles translator-core ToscaConverterImpl violations.

Change-Id: I751ffdde851e23a977c6c05fc1fe5551f247a670
Issue-ID: SDC-343
Signed-off-by: Aravindhan123 <Aravindhan.r@amdocs.com>
6 years agoFix OrchestrationTemplateDaoZusammenImpl 81/27381/2
commit | commitdiff | tree
Abhai Singh [Thu, 4 Jan 2018 12:22:04 +0000 (17:52 +0530)]
Fix OrchestrationTemplateDaoZusammenImpl

Fixed reported sonar issues, sonar issue related to
exception handling are skipped as they would be fixed later

Change-Id: Ib83c69b7b2cfd7fc6e719b3678424c18c3e2cb8a
Issue-ID: SDC-343
Signed-off-by: Abhai Singh <Abhai.Singh@amdocs.com>
6 years agoFix OrchestrationTemplateCandidateDaoZusammenImpl 79/27379/2
commit | commitdiff | tree
Abhai Singh [Thu, 4 Jan 2018 11:54:20 +0000 (17:24 +0530)]
Fix OrchestrationTemplateCandidateDaoZusammenImpl

Fixed reported sonar issues, sonar issue related to
exception handling are skipped as they would be fixed later

Change-Id: Ifc28fe4358eb542bcbf666a07bc37d5488df14c7
Issue-ID: SDC-343
Signed-off-by: Abhai Singh <Abhai.Singh@amdocs.com>
6 years agoReplace restful-js with Axios 67/27367/2
commit | commitdiff | tree
ilanap [Thu, 4 Jan 2018 09:34:59 +0000 (11:34 +0200)]
Replace restful-js with Axios

Change-Id: If47c5b7708885e84d632255557543d292f3ccd69
Issue-ID: SDC-869
Signed-off-by: ilanap <ilanap@amdocs.com>
6 years agoFix Sonar NetworkDaoCassandraImpl 43/27343/2
commit | commitdiff | tree
Abhai Singh [Thu, 4 Jan 2018 07:23:23 +0000 (12:53 +0530)]
Fix Sonar NetworkDaoCassandraImpl

Deleted the file since it is not used, also confirmed
with Tali regarding it

Change-Id: I54cd96688f9b8cb7320578d71d8ad13a90b2bef2
Issue-ID: SDC-343
Signed-off-by: Abhai Singh <Abhai.Singh@amdocs.com>
6 years agoFix Sonar NicDaoCassandraImpl 53/27353/2
commit | commitdiff | tree
Abhai Singh [Thu, 4 Jan 2018 08:16:30 +0000 (13:46 +0530)]
Fix Sonar NicDaoCassandraImpl

Deleted the file since it is not used, also confirmed
with Tali regarding it

Change-Id: Iec438220fcdf041ac7e784abdc8af2bef4ccbd9d
Issue-ID: SDC-343
Signed-off-by: Abhai Singh <Abhai.Singh@amdocs.com>
6 years agoFix issue in vendor-license.xml 59/27259/3
commit | commitdiff | tree
sheetalm [Wed, 3 Jan 2018 14:12:55 +0000 (19:42 +0530)]
Fix issue in vendor-license.xml

If MRN is updated in feature group then update all linked EPs and Lkgs
with new different versionUuId. This will generate new version in
vendor-license.xml with updated MRN for EP and Lkgs

Change-Id: Ib05d931397f24b8131471f423ca43af49b98df8b
Issue-ID: SDC-870
Signed-off-by: sheetalm <sheetal.mudholkar@amdocs.com>
6 years agoFix Sonar issues- ComputeDaoZusammenImpl 85/27285/2
commit | commitdiff | tree
Abhai Singh [Wed, 3 Jan 2018 13:40:27 +0000 (19:10 +0530)]
Fix Sonar issues- ComputeDaoZusammenImpl

Fixed reported sonar issue

Change-Id: Ic7f24226dec3320124bf0acd3f70afdec3466163
Issue-ID: SDC-343
Signed-off-by: Abhai Singh <Abhai.Singh@amdocs.com>
6 years agoHeat reupload component dependency issue fix 65/27265/3
commit | commitdiff | tree
ojasdubey [Wed, 3 Jan 2018 12:23:32 +0000 (17:53 +0530)]
Heat reupload component dependency issue fix

Resolved merge conflict

Change-Id: Ib9561aa7d5814c3dd9c6015214d656a2800984a9
Issue-ID: SDC-872
Signed-off-by: ojasdubey <ojas.dubey@amdocs.com>
6 years agoFix Sonar ElementToVSPQuestionnaireConvertor 27/27327/3
commit | commitdiff | tree
Abhai Singh [Thu, 4 Jan 2018 05:41:14 +0000 (11:11 +0530)]
Fix Sonar ElementToVSPQuestionnaireConvertor

Fixed reported sonar issue

Change-Id: Ib1918e43a15f41535a3f5e1cd31340fe430eae61
Issue-ID: SDC-343
Signed-off-by: Abhai Singh <Abhai.Singh@amdocs.com>
6 years agoFix Sonar NicDaoZusammenImpl 55/27355/2
commit | commitdiff | tree
Abhai Singh [Thu, 4 Jan 2018 08:21:14 +0000 (13:51 +0530)]
Fix Sonar NicDaoZusammenImpl

Fixed reported sonar issues

Change-Id: Id0b925a8e01ac6aa40f48f4e9c1efa018b4155b1
Issue-ID: SDC-343
Signed-off-by: Abhai Singh <Abhai.Singh@amdocs.com>
6 years agoFix Sonar NetworkDaoZusammenImpl 51/27351/2
commit | commitdiff | tree
Abhai Singh [Thu, 4 Jan 2018 07:59:43 +0000 (13:29 +0530)]
Fix Sonar NetworkDaoZusammenImpl

Fixed reported sonar issues

Change-Id: I2c401fd6b18a74d74096494ff7b15bc4d53df10e
Issue-ID: SDC-343
Signed-off-by: Abhai Singh <Abhai.Singh@amdocs.com>
6 years agoFixed sonar issues - MapValidationResponseToDto 39/27339/2
commit | commitdiff | tree
mojahidi [Thu, 4 Jan 2018 07:13:22 +0000 (12:43 +0530)]
Fixed sonar issues - MapValidationResponseToDto

Removed commented code

Change-Id: I2dc73201a53947d68031000f80251a6b29798bfb
Issue-ID: SDC-343
Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
6 years agoFixed sonar issues-MapImageRequestDtoToImageEntity 41/27341/2
commit | commitdiff | tree
mojahidi [Thu, 4 Jan 2018 07:21:39 +0000 (12:51 +0530)]
Fixed sonar issues-MapImageRequestDtoToImageEntity

Removed commented code

Change-Id: I6b6b78653936800e76957d638df3574306605696
Issue-ID: SDC-343
Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
6 years agoFix Sonar ManifestCreatorNamingConventionImpl 31/27331/2
commit | commitdiff | tree
Abhai Singh [Thu, 4 Jan 2018 06:21:25 +0000 (11:51 +0530)]
Fix Sonar ManifestCreatorNamingConventionImpl

Fixed reported sonar issue

Change-Id: I723be3b861df1106c3039a1368f4f20fe4acfcd0
Issue-ID: SDC-343
Signed-off-by: Abhai Singh <Abhai.Singh@amdocs.com>
6 years agoFix Sonar ImageDaoZusammenImpl 29/27329/2
commit | commitdiff | tree
Abhai Singh [Thu, 4 Jan 2018 06:16:40 +0000 (11:46 +0530)]
Fix Sonar ImageDaoZusammenImpl

Fixed reported sonar issue

Change-Id: I129fa4cbb5ba09c361663f7259807fca690eff0e
Issue-ID: SDC-343
Signed-off-by: Abhai Singh <Abhai.Singh@amdocs.com>
6 years agoFixed sonar issues - VspItemProperty 25/27325/2
commit | commitdiff | tree
mojahidi [Thu, 4 Jan 2018 05:29:07 +0000 (10:59 +0530)]
Fixed sonar issues - VspItemProperty

Added private constructor

Change-Id: Ic8ba23a009dab76518e9b7e266cc6d56820222b5
Issue-ID: SDC-343
Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
6 years agoFixed sonar issues - ComponentDependenciesImpl 23/27323/2
commit | commitdiff | tree
mojahidi [Thu, 4 Jan 2018 05:24:05 +0000 (10:54 +0530)]
Fixed sonar issues - ComponentDependenciesImpl

Fixed all sonar issues

Change-Id: Iaed4ea9bc7df52bd100d5d118b7212813ae22b76
Issue-ID: SDC-343
Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
6 years agoFix Sonar VendorSoftwareProductInfoDaoZusammenImpl 91/27291/2
commit | commitdiff | tree
Abhai Singh [Wed, 3 Jan 2018 14:12:55 +0000 (19:42 +0530)]
Fix Sonar VendorSoftwareProductInfoDaoZusammenImpl

Fixed reported sonar issue

Change-Id: Ifc827f6e1ac4c10272969e643d10b86171a0d963
Issue-ID: SDC-343
Signed-off-by: Abhai Singh <Abhai.Singh@amdocs.com>
6 years agoFix Sonar issues- ElementToProcessConvertor 89/27289/2
commit | commitdiff | tree
Abhai Singh [Wed, 3 Jan 2018 14:02:13 +0000 (19:32 +0530)]
Fix Sonar issues- ElementToProcessConvertor

Fixed reported sonar issue

Change-Id: I631710a9421e34cf7c26a9316e2e3271bf44f587
Issue-ID: SDC-343
Signed-off-by: Abhai Singh <Abhai.Singh@amdocs.com>
6 years agoFix Sonar issues- DeploymentFlavorDaoZusammenImpl 87/27287/2
commit | commitdiff | tree
Abhai Singh [Wed, 3 Jan 2018 13:54:56 +0000 (19:24 +0530)]
Fix Sonar issues- DeploymentFlavorDaoZusammenImpl

Fixed reported sonar issue

Change-Id: I58f503aa43f0257c263835053bde28442f98a2b5
Issue-ID: SDC-343
Signed-off-by: Abhai Singh <Abhai.Singh@amdocs.com>
6 years agofix failing tests 99/27299/2
commit | commitdiff | tree
talio [Wed, 3 Jan 2018 15:49:51 +0000 (17:49 +0200)]
fix failing tests

fix failing tests in uploadCSARFileTest.java, and changing error messages

Change-Id: Ied1384d87551242d3eb48987990a6e8a72b26916
Issue-ID: SDC-874
Signed-off-by: talio <tali.orenbach@amdocs.com>
6 years agoFix Orch Template Candidate Manager test failures 33/27333/1
commit | commitdiff | tree
talig [Thu, 4 Jan 2018 06:33:48 +0000 (08:33 +0200)]
Fix Orch Template Candidate Manager test failures

Change-Id: Icd5d96b5cd27b3051828b703fde549217341c320
Issue-ID: SDC-860
Signed-off-by: talig <talig@amdocs.com>
6 years agoFix Sonar -ComponentDependencyModelDaoZusammenImpl 83/27283/2
commit | commitdiff | tree
Abhai Singh [Wed, 3 Jan 2018 13:27:21 +0000 (18:57 +0530)]
Fix Sonar -ComponentDependencyModelDaoZusammenImpl

Fixed reported sonar issue

Change-Id: I6c8b86cb54bcc6d21920e9ea806dcd40717c2383
Issue-ID: SDC-343
Signed-off-by: Abhai Singh <Abhai.Singh@amdocs.com>
6 years agoFix Sonar violations - ValidationErrorCodes 61/27261/3
commit | commitdiff | tree
Abhai Singh [Wed, 3 Jan 2018 10:58:47 +0000 (16:28 +0530)]
Fix Sonar violations - ValidationErrorCodes

Removing the files since they are not referenced

Change-Id: Ica5835575222e96abc02132734b1e354d696ae35
Issue-ID: SDC-343
Signed-off-by: Abhai Singh <Abhai.Singh@amdocs.com>
6 years agoFixed sonar issues - VersionedVendorSoftwareProd 95/27095/5
commit | commitdiff | tree
mojahidi [Thu, 28 Dec 2017 12:20:41 +0000 (17:50 +0530)]
Fixed sonar issues - VersionedVendorSoftwareProd

Fixed all sonar issues

Change-Id: Ibf766225a961e11249fbcebe8115b5426f521a83
Issue-ID: SDC-343
Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
6 years agoFix Sonar issues- ComponentDaoZusammenImpl 81/27281/2
commit | commitdiff | tree
Abhai Singh [Wed, 3 Jan 2018 13:19:33 +0000 (18:49 +0530)]
Fix Sonar issues- ComponentDaoZusammenImpl

Fixed reported sonar issue

Change-Id: Ieda1568b4b20cdaaee47534cbfc0c73bfcca393c
Issue-ID: SDC-343
Signed-off-by: Abhai Singh <Abhai.Singh@amdocs.com>
6 years agoFix Sonar - ComponentArtifactDaoZusammenImpl 77/27277/2
commit | commitdiff | tree
Abhai Singh [Wed, 3 Jan 2018 13:05:21 +0000 (18:35 +0530)]
Fix Sonar - ComponentArtifactDaoZusammenImpl

Fixed reported sonar issues

Change-Id: I1d74c641d65d47a7ab810bef94b77ef3a55cd071
Issue-ID: SDC-343
Signed-off-by: Abhai Singh <Abhai.Singh@amdocs.com>
6 years agoComponentMonitoringForSwaggerFileUpload 73/27273/2
commit | commitdiff | tree
mojahidi [Wed, 3 Jan 2018 12:38:10 +0000 (18:08 +0530)]
ComponentMonitoringForSwaggerFileUpload

Deleted unused interface

Change-Id: I039024b7bd77dca735bdd644da657aa05110b5c8
Issue-ID: SDC-343
Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
6 years agodeleted unused interface - ComponentUploads 71/27271/2
commit | commitdiff | tree
mojahidi [Wed, 3 Jan 2018 12:28:37 +0000 (17:58 +0530)]
deleted unused interface - ComponentUploads

Deleted unused interface

Change-Id: I4793c5486c18ed9ff74f9f70fd079dd5a78fb32b
Issue-ID: SDC-343
Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
6 years agoUnit Tests 37/27237/3
commit | commitdiff | tree
ayalaben [Wed, 3 Jan 2018 06:38:27 +0000 (08:38 +0200)]
Unit Tests

Change-Id: I39ee00e80475aa93b0f99a350b56754c31c6e9b6
Issue-ID: SDC-860
Signed-off-by: ayalaben <ayala.benzvi@amdocs.com>
6 years agoFix Sonar violations - ValidationManagerUtil 57/27257/2
commit | commitdiff | tree
Abhai Singh [Wed, 3 Jan 2018 10:46:01 +0000 (16:16 +0530)]
Fix Sonar violations - ValidationManagerUtil

Fixed reported sonar issues by adding private constructor

Change-Id: I544dcdb7385ce8cf750f5f93695460365cc0e78f
Issue-ID: SDC-343
Signed-off-by: Abhai Singh <Abhai.Singh@amdocs.com>
6 years agoselect item from workspace- skipping versions page 19/27219/2
commit | commitdiff | tree
miriame [Tue, 2 Jan 2018 13:35:55 +0000 (15:35 +0200)]
select item from workspace- skipping versions page

Change-Id: Iebd3bb33703c2d47265ba133f7b74ec961ba8b2f
Issue-ID: SDC-864
Signed-off-by: miriame <miriam.eini@amdocs.com>
6 years agofix MIB assignment 11/27211/3
commit | commitdiff | tree
mojahidi [Thu, 28 Dec 2017 13:03:00 +0000 (18:33 +0530)]
fix MIB assignment

Assign mib file to all of the components from the same VFC type

Change-Id: Ia6a1a5a08b7383ec64ace085193b0c8daa399c7f
Issue-ID: SDC-811
Signed-off-by: talio <tali.orenbach@amdocs.com>
6 years agoRemove Zusammen cassandra plugin 15/27215/3
commit | commitdiff | tree
shalomb [Tue, 2 Jan 2018 11:48:40 +0000 (13:48 +0200)]
Remove Zusammen cassandra plugin

Remove Zusammen cassandra plugin
Change dependency
Modify imports

Change-Id: Ice66fdd9f3970961723df476c8d1e38040504189
Issue-ID: SDC-862
Signed-off-by: shalomb <shalomb@amdocs.com>
6 years agoUnit Tests 13/27213/2
commit | commitdiff | tree
ayalaben [Tue, 2 Jan 2018 09:25:39 +0000 (11:25 +0200)]
Unit Tests

Change-Id: I6b863f3762eaad4f17967d77fc5ad64b23ee9d3a
Issue-ID: SDC-860
Signed-off-by: ayalaben <ayala.benzvi@amdocs.com>
6 years agoFixed sonar issues - VersionedVendorSoftwareProduc 03/27103/3
commit | commitdiff | tree
mojahidi [Thu, 28 Dec 2017 13:03:00 +0000 (18:33 +0530)]
Fixed sonar issues - VersionedVendorSoftwareProduc

Fixed all sonar issues except exception handling and newly introduced in collaboration merge

Change-Id: I9d9292411cd9f7ffb32aa284a5d63c86bb01b56d
Issue-ID: SDC-343
Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
6 years agosonar issue fix - exception handling 75/27175/5
commit | commitdiff | tree
shrek2000 [Sun, 31 Dec 2017 08:32:59 +0000 (10:32 +0200)]
sonar issue fix - exception handling

remove exception handling which does nothing to handle the error
Issue-ID: SDC-835

Change-Id: I45e0bc203e15b41f907641bfda130f20e1f00f54
Signed-off-by: shrek2000 <orenkle@amdocs.com>
6 years agoFixing sonar Exception Handling 85/27185/6
commit | commitdiff | tree
avigaffa [Sun, 31 Dec 2017 13:07:39 +0000 (15:07 +0200)]
Fixing sonar Exception Handling

Change-Id: I04eb047973a3f5c07dd9dc410cb13af974e8ded1
Issue-ID: SDC-810
Signed-off-by: avigaffa <avi.gaffa@amdocs.com>
Signed-off-by: vempo <vitaliy.emporopulo@amdocs.com>
6 years agoRemove onboarding BE redundant healers 01/27201/1
commit | commitdiff | tree
talig [Mon, 1 Jan 2018 12:52:01 +0000 (14:52 +0200)]
Remove onboarding BE redundant healers

Change-Id: I6b849608e64f88c6b91b1bc772fdb33aaa7e8245
Issue-ID: SDC-845
Signed-off-by: talig <talig@amdocs.com>
6 years agoFix sonar issues + tests in versioning lib 85/27085/3
commit | commitdiff | tree
talig [Mon, 1 Jan 2018 11:07:47 +0000 (13:07 +0200)]
Fix sonar issues + tests in versioning lib

Change-Id: Ib49288fe49be1e848b9615e548689cdbe0df4fee
Issue-ID: SDC-779
Signed-off-by: talig <talig@amdocs.com>
next
SDC Parent Project Catalog FE and BE