From: Isaac Manuel Raj Date: Fri, 12 Apr 2019 10:31:51 +0000 (+0530) Subject: Code Enhancement (Sonar Fixes) X-Git-Tag: 1.4.0~15^2 X-Git-Url: https://gerrit.onap.org/r/gitweb?a=commitdiff_plain;h=refs%2Fchanges%2F89%2F85189%2F2;p=so%2Flibs.git Code Enhancement (Sonar Fixes) Sonar Issues Fixes Issue-ID: SO-1490 Change-Id: I9759c8ba1d6098e8f2b4eb6da36a676d0ecd4e19 Signed-off-by: Isaac Manuel Raj --- diff --git a/nova-client/src/main/java/com/woorea/openstack/nova/api/extensions/FloatingIpsExtension.java b/nova-client/src/main/java/com/woorea/openstack/nova/api/extensions/FloatingIpsExtension.java index 4b39b2e..d1ae7f4 100644 --- a/nova-client/src/main/java/com/woorea/openstack/nova/api/extensions/FloatingIpsExtension.java +++ b/nova-client/src/main/java/com/woorea/openstack/nova/api/extensions/FloatingIpsExtension.java @@ -28,13 +28,13 @@ import com.woorea.openstack.nova.model.FloatingIp; import com.woorea.openstack.nova.model.FloatingIps; public class FloatingIpsExtension { - + private final OpenStackClient CLIENT; - + public FloatingIpsExtension(OpenStackClient client) { CLIENT = client; } - + public class List extends OpenStackRequest { public List() { @@ -44,40 +44,39 @@ public class FloatingIpsExtension { } public class Allocate extends OpenStackRequest { - + public Allocate(Entity entity) { super(CLIENT, HttpMethod.POST, "/os-floating-ips", entity, FloatingIp.class); } } - + public class Deallocate extends OpenStackRequest { - + public Deallocate(String id) { super(CLIENT, HttpMethod.DELETE, new StringBuffer("/os-floating-ips/").append(id).toString(), null, Void.class); } - + } public List list() { return new List(); } - + public Allocate allocate(String pool) { Entity entity=null; if(pool!=null) { - Map body = new HashMap(); + Map body = new HashMap<>(); body.put("pool", pool); entity=Entity.json(body); } return new Allocate(entity); } - + public Deallocate deallocate(String id) { return new Deallocate(id); } - - - -} + + +}