From: ezhil <ezhrajam@in.ibm.com>
Date: Wed, 26 Dec 2018 11:08:07 +0000 (+0530)
Subject: Fixed sonar issue in ExternalKeyValidator
X-Git-Tag: 0.4.0~8^2
X-Git-Url: https://gerrit.onap.org/r/gitweb?a=commitdiff_plain;h=refs%2Fchanges%2F89%2F75089%2F1;p=ccsdk%2Fapps.git

Fixed sonar issue in ExternalKeyValidator

Fixed major sonar issue
Issue-ID: CCSDK-690
Change-Id: I17abdb751f1a384bd0c63e5b336186eaad945783
Signed-off-by: ezhil <ezhrajam@in.ibm.com>
---

diff --git a/ms/neng/src/main/java/org/onap/ccsdk/apps/ms/neng/core/validator/ExternalKeyValidator.java b/ms/neng/src/main/java/org/onap/ccsdk/apps/ms/neng/core/validator/ExternalKeyValidator.java
index 4b7ec79b..c17158c0 100644
--- a/ms/neng/src/main/java/org/onap/ccsdk/apps/ms/neng/core/validator/ExternalKeyValidator.java
+++ b/ms/neng/src/main/java/org/onap/ccsdk/apps/ms/neng/core/validator/ExternalKeyValidator.java
@@ -4,6 +4,8 @@
  * ================================================================================
  * Copyright (C) 2018 AT&T Intellectual Property. All rights reserved.
  * ================================================================================
+ * Modifications Copyright (C) 2018 IBM.
+ * ================================================================================
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
  * You may obtain a copy of the License at
@@ -36,7 +38,7 @@ public class ExternalKeyValidator {
      * Tells if the given external ID is present in the DB.
      */
     public boolean isPresent(String externalId) {
-        if (genNameRepo.findByExternalId(externalId).size() > 0 || genNameRepo.findByExternalId(externalId).isEmpty() ) {
+        if (!genNameRepo.findByExternalId(externalId).isEmpty() ) {
             return true;
         }
         return false;