From: Abhai Singh <Abhai.Singh@amdocs.com>
Date: Wed, 3 Jan 2018 13:40:27 +0000 (+0530)
Subject: Fix Sonar issues- ComputeDaoZusammenImpl
X-Git-Tag: v1.2.0~498
X-Git-Url: https://gerrit.onap.org/r/gitweb?a=commitdiff_plain;h=refs%2Fchanges%2F85%2F27285%2F2;p=sdc.git

Fix Sonar issues- ComputeDaoZusammenImpl

Fixed reported sonar issue

Change-Id: Ic7f24226dec3320124bf0acd3f70afdec3466163
Issue-ID: SDC-343
Signed-off-by: Abhai Singh <Abhai.Singh@amdocs.com>
---

diff --git a/openecomp-be/lib/openecomp-sdc-vendor-software-product-lib/openecomp-sdc-vendor-software-product-core/src/main/java/org/openecomp/sdc/vendorsoftwareproduct/dao/impl/zusammen/ComputeDaoZusammenImpl.java b/openecomp-be/lib/openecomp-sdc-vendor-software-product-lib/openecomp-sdc-vendor-software-product-core/src/main/java/org/openecomp/sdc/vendorsoftwareproduct/dao/impl/zusammen/ComputeDaoZusammenImpl.java
index 0f92c95294..ad6bc03dda 100644
--- a/openecomp-be/lib/openecomp-sdc-vendor-software-product-lib/openecomp-sdc-vendor-software-product-core/src/main/java/org/openecomp/sdc/vendorsoftwareproduct/dao/impl/zusammen/ComputeDaoZusammenImpl.java
+++ b/openecomp-be/lib/openecomp-sdc-vendor-software-product-lib/openecomp-sdc-vendor-software-product-core/src/main/java/org/openecomp/sdc/vendorsoftwareproduct/dao/impl/zusammen/ComputeDaoZusammenImpl.java
@@ -38,6 +38,7 @@ public class ComputeDaoZusammenImpl implements ComputeDao {
 
   @Override
   public void registerVersioning(String versionableEntityType) {
+    // registerVersioning not implemented for ComputeDaoZusammenImpl
   }
 
   @Override
@@ -52,11 +53,11 @@ public class ComputeDaoZusammenImpl implements ComputeDao {
   private Collection<ComputeEntity> listComputes(SessionContext context,
                                                  ElementContext elementContext,
                                                  ComputeEntity compute) {
-    ElementToComputeConvertor convertor = new ElementToComputeConvertor();
     return zusammenAdaptor
         .listElementsByName(context, elementContext, new Id(compute.getComponentId()),
             ElementType.Computes.name())
-        .stream().map(elementInfo -> convertor.convert(elementInfo))
+        .stream()
+        .map(new ElementToComputeConvertor()::convert)
         .map(computeEntity -> {
           computeEntity.setComponentId(compute.getComponentId());
           computeEntity.setVspId(compute.getVspId());