From: Abhai Singh <Abhai.Singh@amdocs.com>
Date: Tue, 16 Jan 2018 08:39:32 +0000 (+0530)
Subject: Fix Sonar EntitlementPoolZusammenDaoImpl
X-Git-Tag: v1.2.0~431
X-Git-Url: https://gerrit.onap.org/r/gitweb?a=commitdiff_plain;h=refs%2Fchanges%2F77%2F28277%2F1;p=sdc.git

Fix Sonar EntitlementPoolZusammenDaoImpl

Fixed reported sonar issues

Change-Id: I0a6d965a20d1bfe04b8d7ba62e12a830d763cec0
Issue-ID: SDC-343
Signed-off-by: Abhai Singh <Abhai.Singh@amdocs.com>
---

diff --git a/openecomp-be/lib/openecomp-sdc-vendor-license-lib/openecomp-sdc-vendor-license-core/src/main/java/org/openecomp/sdc/vendorlicense/dao/impl/zusammen/EntitlementPoolZusammenDaoImpl.java b/openecomp-be/lib/openecomp-sdc-vendor-license-lib/openecomp-sdc-vendor-license-core/src/main/java/org/openecomp/sdc/vendorlicense/dao/impl/zusammen/EntitlementPoolZusammenDaoImpl.java
index 35182a3502..be073abae5 100644
--- a/openecomp-be/lib/openecomp-sdc-vendor-license-lib/openecomp-sdc-vendor-license-core/src/main/java/org/openecomp/sdc/vendorlicense/dao/impl/zusammen/EntitlementPoolZusammenDaoImpl.java
+++ b/openecomp-be/lib/openecomp-sdc-vendor-license-lib/openecomp-sdc-vendor-license-core/src/main/java/org/openecomp/sdc/vendorlicense/dao/impl/zusammen/EntitlementPoolZusammenDaoImpl.java
@@ -77,7 +77,7 @@ public class EntitlementPoolZusammenDaoImpl implements EntitlementPoolDao {
       if (entitlmentpoolElement.getRelations() == null) {
         entitlmentpoolElement.setRelations(new ArrayList<>());
       }
-      if (epFromDb.get().getRelations() != null && epFromDb.get().getRelations().size() > 0) {
+      if (epFromDb.get().getRelations() != null && !epFromDb.get().getRelations().isEmpty()) {
         entitlmentpoolElement.getRelations().addAll(epFromDb.get().getRelations());
       }
     }
@@ -228,7 +228,7 @@ public class EntitlementPoolZusammenDaoImpl implements EntitlementPoolDao {
     entitlementPoolElement.setInfo(info);
 
     if (entitlementPool.getReferencingFeatureGroups() != null
-        && entitlementPool.getReferencingFeatureGroups().size() > 0) {
+        && !entitlementPool.getReferencingFeatureGroups().isEmpty()) {
       entitlementPoolElement.setRelations(entitlementPool.getReferencingFeatureGroups().stream()
           .map(rel -> VlmZusammenUtil
               .createRelation(RelationType.EntitlmentPoolToReferencingFeatureGroup, rel))