From: Surendra Reddy Katam <SK00524980@techmahindra.com>
Date: Wed, 28 Mar 2018 10:10:56 +0000 (+0530)
Subject: Sonar major issues
X-Git-Tag: v1.1.4~21^2
X-Git-Url: https://gerrit.onap.org/r/gitweb?a=commitdiff_plain;h=refs%2Fchanges%2F73%2F39573%2F1;p=dmaap%2Fmessagerouter%2Fdmaapclient.git

Sonar major issues

 Use isEmpty() to check whether the collection is empty or not
Sonar Link:
https://sonar.onap.org/project/issues?assignees=surendraReddy&id=org.onap.dmaap.messagerouter.dmaapclient%3AdmaapClient&open=AV4-MbQb32hFUzlqc5Zm&resolved=false&severities=MAJOR
Location:
src/main/java/com/att/nsa/mr/client/impl/MRBatchPublisher.java
Line No-322

Change-Id: Ifa4a91a303f49be0c264a9af2498bf70b8056168
Issue-ID: DMAAP-361
Signed-off-by: Surendra Reddy Katam <SK00524980@techmahindra.com>
---

diff --git a/src/main/java/com/att/nsa/mr/client/impl/MRBatchPublisher.java b/src/main/java/com/att/nsa/mr/client/impl/MRBatchPublisher.java
index 4701a1f..cf42907 100644
--- a/src/main/java/com/att/nsa/mr/client/impl/MRBatchPublisher.java
+++ b/src/main/java/com/att/nsa/mr/client/impl/MRBatchPublisher.java
@@ -319,7 +319,7 @@ public class MRBatchPublisher implements MRBatchingPublisher
 			fReadLock.lock ();
 			try
 			{
-				if ( fNextBatch.size () > 0 )
+				if ( fNextBatch.isEmpty() )
 				{
 					final long nowMs = System.currentTimeMillis ();
 					shouldSend = ( force || fNextBatch.size() >= fMaxBatchSize );