From: Andrew Grimberg <agrimberg@linuxfoundation.org>
Date: Wed, 3 May 2017 20:17:08 +0000 (-0400)
Subject: Initial coala delint (scripts)
X-Git-Tag: 1.0.0-Amsterdam~487^2~3
X-Git-Url: https://gerrit.onap.org/r/gitweb?a=commitdiff_plain;h=refs%2Fchanges%2F73%2F3873%2F1;p=ci-management.git

Initial coala delint (scripts)

Initial coala delint for global scripts

Issue: CIMAN-2
Change-Id: Ia1ef0585b8c929ce25aebaa0178b039e0ac6f93e
Signed-off-by: Andrew Grimberg <agrimberg@linuxfoundation.org>
---

diff --git a/scripts/check-unicode.sh b/scripts/check-unicode.sh
index db45f6ac6..931c99fac 100755
--- a/scripts/check-unicode.sh
+++ b/scripts/check-unicode.sh
@@ -13,17 +13,13 @@
 #   Thanh Ha (The Linux Foundation) - Initial implementation
 ##############################################################################
 
-directory="."
-if [ ! -z "$1" ]; then
-    directory="$1"
-fi
+directory=${1:-"."}
 
 echo "Scanning $directory"
-for x in $(find $directory -type f); do
-    if LC_ALL=C grep -q '[^[:print:][:space:]]' "$x"; then
-        echo "file "$x" contains non-ascii characters"
-        exit 1
-    fi
-done
+if LC_ALL=C grep -r '[^[:print:][:space:]]' "$directory"; then
+    echo "Found files containing non-ascii characters."
+    exit 1
+fi
 
 echo "All files are ASCII only"
+