From: ojasdubey <ojas.dubey@amdocs.com>
Date: Wed, 27 Dec 2017 15:00:32 +0000 (+0530)
Subject: Fix Sonar violations - ConfigurationDataSource
X-Git-Tag: v1.2.0~563
X-Git-Url: https://gerrit.onap.org/r/gitweb?a=commitdiff_plain;h=refs%2Fchanges%2F63%2F27063%2F2;p=sdc.git

Fix Sonar violations - ConfigurationDataSource

1. Fixed major sonar violations configuration management core
- ConfigurationDataSource

Change-Id: Iee96111b3051a67d25f99a0ba49e99f4d9290345
Issue-ID: SDC-343
Signed-off-by: ojasdubey <ojas.dubey@amdocs.com>
---

diff --git a/common/openecomp-common-configuration-management/openecomp-configuration-management-core/src/main/java/org/openecomp/config/impl/ConfigurationDataSource.java b/common/openecomp-common-configuration-management/openecomp-configuration-management-core/src/main/java/org/openecomp/config/impl/ConfigurationDataSource.java
index 0cfc96bc7f..a60403e4dc 100644
--- a/common/openecomp-common-configuration-management/openecomp-configuration-management-core/src/main/java/org/openecomp/config/impl/ConfigurationDataSource.java
+++ b/common/openecomp-common-configuration-management/openecomp-configuration-management-core/src/main/java/org/openecomp/config/impl/ConfigurationDataSource.java
@@ -22,11 +22,16 @@ public final class ConfigurationDataSource {
   private static Set<String> validCallers = Collections.unmodifiableSet(new HashSet<>(
       Arrays.asList(ConfigurationUtils.class.getName(), CliConfigurationImpl.class.getName())));
 
+  private ConfigurationDataSource() {
+    //Hide constructor to prevent instantiation using the default implicit constructor
+  }
+
   static {
     try {
       configDBDatasource = initDataSource();
     } catch (Exception exception) {
-      System.err.println("Datasource initialization error. Configuration management will be using in-memory persistence.");
+      System.err.println("Datasource initialization error. Configuration management will be using"
+          + "in-memory persistence.");
     }
   }
 
@@ -83,7 +88,6 @@ public final class ConfigurationDataSource {
       Driver driver = Driver.class.cast(Class.forName(driverClassName).newInstance());
       return driver.acceptsURL(url);
     } catch (Exception exception) {
-      exception.printStackTrace();
       return false;
     }
   }