From: anushadasari <danush10@in.ibm.com>
Date: Wed, 20 Nov 2019 11:13:57 +0000 (+0530)
Subject: Move "*" string literal on left side of string
X-Git-Tag: 2.2.0~20
X-Git-Url: https://gerrit.onap.org/r/gitweb?a=commitdiff_plain;h=refs%2Fchanges%2F59%2F98659%2F1;p=optf%2Fcmso.git

Move "*" string literal on left side of string

It is preferable to place string literals on the left-hand side of an equals() or equalsIgnoreCase() method call.

Issue-ID: OPTFRA-647
Change-Id: Ibd04d10da4e655be44310ec0459f1fdeab791441
Signed-off-by: anushadasari <danush10@in.ibm.com>
---

diff --git a/cmso-service/src/main/java/org/onap/optf/cmso/aaf/AafPerm.java b/cmso-service/src/main/java/org/onap/optf/cmso/aaf/AafPerm.java
index d324f18..b8e7f5b 100755
--- a/cmso-service/src/main/java/org/onap/optf/cmso/aaf/AafPerm.java
+++ b/cmso-service/src/main/java/org/onap/optf/cmso/aaf/AafPerm.java
@@ -90,9 +90,9 @@ public class AafPerm {
      */
     public boolean ok(AafPerm userPerm) {
         if (type.equals(userPerm.getType())) {
-            if (userPerm.getInstance().equals("*") || instance.equals("*") || userPerm.getInstance().equals(instance)) {
+            if ("*".equals(userPerm.getInstance()) || "*".equals(instance) || userPerm.getInstance().equals(instance)) {
                 for (String userAction : userPerm.getActions()) {
-                    if (userAction.equals("*") || actions.contains("*") || actions.contains(userAction)) {
+                    if ("*".equals(userAction) || actions.contains("*") || actions.contains(userAction)) {
                         return true;
                     }
                 }