From: Instrumental <jonathan.gathman@att.com>
Date: Thu, 8 Nov 2018 02:59:18 +0000 (-0600)
Subject: Faulty JUnit
X-Git-Tag: 2.1.7~1
X-Git-Url: https://gerrit.onap.org/r/gitweb?a=commitdiff_plain;h=refs%2Fchanges%2F58%2F72158%2F1;p=aaf%2Fauthz.git

Faulty JUnit

Issue-ID: AAF-617
Change-Id: Ib3060c832d3bc939609b1401db47826a659d6b52
Signed-off-by: Instrumental <jonathan.gathman@att.com>
---

diff --git a/auth/auth-core/src/test/java/org/onap/aaf/auth/env/test/JU_NullTrans.java b/auth/auth-core/src/test/java/org/onap/aaf/auth/env/test/JU_NullTrans.java
index f6c00ad8..f67716fa 100644
--- a/auth/auth-core/src/test/java/org/onap/aaf/auth/env/test/JU_NullTrans.java
+++ b/auth/auth-core/src/test/java/org/onap/aaf/auth/env/test/JU_NullTrans.java
@@ -22,7 +22,9 @@
 
 package org.onap.aaf.auth.env.test;
 
-import static org.junit.Assert.*;
+import static org.mockito.Mockito.mock;
+
+import java.security.Principal;
 
 import javax.servlet.http.HttpServletRequest;
 
@@ -34,7 +36,6 @@ import org.mockito.runners.MockitoJUnitRunner;
 import org.onap.aaf.auth.env.AuthzEnv;
 import org.onap.aaf.auth.env.AuthzTrans;
 import org.onap.aaf.auth.env.NullTrans;
-import org.onap.aaf.auth.env.AuthzTrans.REQD_TYPE;
 import org.onap.aaf.auth.org.Organization;
 import org.onap.aaf.cadi.Permission;
 import org.onap.aaf.misc.env.Decryptor;
@@ -43,12 +44,6 @@ import org.onap.aaf.misc.env.LogTarget;
 import org.onap.aaf.misc.env.Slot;
 import org.onap.aaf.misc.env.TimeTaken;
 
-import static org.mockito.Mockito.mock;
-import static org.mockito.Mockito.when;
-
-import java.security.Principal;
-import java.util.Date;
-
 @RunWith(MockitoJUnitRunner.class)
 public class JU_NullTrans {
     NullTrans nullTrans;
@@ -261,13 +256,14 @@ public class JU_NullTrans {
         Assert.assertFalse(reqd);
         nullTrans.requested(null, true);
     }
-    
-    @Test
-    public void testNow() {
-        Date date = new Date();
-        Assert.assertEquals(date,nullTrans.now());
-        //when(nullTrans.now()).thenReturn(null);
-    }
+
+//  This is very inconsistent, and rather pointless
+//    @Test
+//    public void testNow() {
+//        Date date = new Date();
+//        Assert.assertEquals(date,nullTrans.now());
+//        //when(nullTrans.now()).thenReturn(null);
+//    }