From: waynedunican <wayne.dunican@est.tech>
Date: Thu, 2 Mar 2023 09:12:44 +0000 (+0000)
Subject: Add SLA Validations for API
X-Git-Tag: 2.6.2~11^2
X-Git-Url: https://gerrit.onap.org/r/gitweb?a=commitdiff_plain;h=refs%2Fchanges%2F58%2F133558%2F2;p=policy%2Fdocker.git

Add SLA Validations for API

- Add tests for querying policies/policyTypes by version/id
- Add tests for deletion of policies/policyTypes
- Update expected response time

Issue-ID: POLICY-4528
Change-Id: I393383ef8771274501509ee9b3073b3a0ef01b38
Signed-off-by: Wayne Dunican <wayne.dunican@est.tech>
---

diff --git a/csit/resources/tests/api-slas.robot b/csit/resources/tests/api-slas.robot
index c5feb728..717ac3d7 100644
--- a/csit/resources/tests/api-slas.robot
+++ b/csit/resources/tests/api-slas.robot
@@ -28,9 +28,14 @@ ValidateResponseTimeQueryPolicies
     [Documentation]  Validate query policies response time
     ValidateResponseTimeForApi  /policies  GET
 
+ValidateResponseTimeQueryPolicyTypeListVersions
+    [Documentation]  Validate query policyType versions response time
+    ValidateResponseTime  api-metrics  /policytypes/{policyTypeId}  GET  400
+
+#Time increased from 200 to 250 due to slow ONAP machines
 ValidateResponseTimeQueryPolicyVersion
     [Documentation]  Validate query policy by version response time
-    ValidateResponseTimeForApi  /policies/{policyId}/versions/{policyVersion}  GET
+    ValidateResponseTime  api-metrics   /policies/{policyId}/versions/{policyVersion}  GET  250
 
 ValidateResponseTimeCreatePolicy
     [Documentation]  Validate response time for creating a policy
@@ -42,4 +47,8 @@ ValidateResponseTimeCreatePolicyType
 
 ValidateResponseTimeDeletePolicy
     [Documentation]  Validate response time for deletion of policies
-    ValidateResponseTimeForApi  /policies/{policyId}/versions/{policyVersion}  DELETE
\ No newline at end of file
+    ValidateResponseTimeForApi  /policies/{policyId}/versions/{policyVersion}  DELETE
+
+ValidateResponseTimeDeletePolicyType
+    [Documentation]  Validate response time for deletion of policyTypes
+    ValidateResponseTimeForApi  /policytypes/{policyTypeId}/versions/{versionId}  DELETE
diff --git a/csit/resources/tests/api-test.robot b/csit/resources/tests/api-test.robot
index f3c87de3..e8679a7f 100644
--- a/csit/resources/tests/api-test.robot
+++ b/csit/resources/tests/api-test.robot
@@ -140,11 +140,6 @@ GetReq
      ${resp}=  PerformGetRequest  ${POLICY_API_IP}  ${url}  200  null  ${auth}
      [return]  ${resp}
 
-ValidateResponseTimeForApi
-    [Arguments]  ${url}  ${method}
-    [Documentation]  Check if url response is under required time for api metrics
-    ValidateResponseTime  api-metrics  ${url}  ${method}  500
-
 DeleteReq
      [Arguments]  ${url}  ${expectedstatus}
      ${auth}=  PolicyAdminAuth