From: anushadasari <danush10@in.ibm.com>
Date: Wed, 20 Nov 2019 10:27:35 +0000 (+0530)
Subject: Move "*" string literal on left side of string
X-Git-Tag: 2.2.0~24
X-Git-Url: https://gerrit.onap.org/r/gitweb?a=commitdiff_plain;h=refs%2Fchanges%2F54%2F98654%2F1;p=optf%2Fcmso.git

Move "*" string literal on left side of string

It is preferable to place string literals on the left-hand side of an equals() or equalsIgnoreCase() method call.

Issue-ID: OPTFRA-647
Change-Id: Idd9ac257f96553a00f8a455a48d678adb167a382
Signed-off-by: anushadasari <danush10@in.ibm.com>
---

diff --git a/cmso-optimizer/src/main/java/org/onap/optf/cmso/optimizer/aaf/AafUserRole.java b/cmso-optimizer/src/main/java/org/onap/optf/cmso/optimizer/aaf/AafUserRole.java
index 295221c..cda740f 100755
--- a/cmso-optimizer/src/main/java/org/onap/optf/cmso/optimizer/aaf/AafUserRole.java
+++ b/cmso-optimizer/src/main/java/org/onap/optf/cmso/optimizer/aaf/AafUserRole.java
@@ -158,7 +158,7 @@ public class AafUserRole {
         while (!inNodes.isEmpty() && !matchNodes.isEmpty()) {
             String inNode = inNodes.remove(0);
             String matchNode = matchNodes.get(0);
-            if (matchNode.equals(inNode) || matchNode.equals("*")) {
+            if (matchNode.equals(inNode) || "*".equals(matchNode)) {
                 matchNodes.remove(0);
             } else {
                 if (!matchNode.equals("**")) {
@@ -174,10 +174,10 @@ public class AafUserRole {
 
         // We have incoming nodes remaining, see if we can wildcard them
         if (matchNodes.size() == 1) {
-            if (matchNodes.get(0).equals("**")) {
+            if ("**".equals(matchNodes.get(0))) {
                 return true;
             }
-            if (inNodes.size() == 1 && matchNodes.get(0).equals("*")) {
+            if (inNodes.size() == 1 && "*".equals(matchNodes.get(0))) {
                 return true;
             }
         }