From: Jim Hahn <jrh3@att.com>
Date: Fri, 18 Jun 2021 18:03:38 +0000 (-0400)
Subject: Fix new checkstyle issues in xacml-pdp
X-Git-Tag: 2.5.0~28
X-Git-Url: https://gerrit.onap.org/r/gitweb?a=commitdiff_plain;h=refs%2Fchanges%2F53%2F122053%2F1;p=policy%2Fxacml-pdp.git

Fix new checkstyle issues in xacml-pdp

The new version of checkstyle identified new issues.  Fixed those.

Issue-ID: POLICY-3288
Change-Id: I334e9eb67c9270c4e53b2fb34e576b8bfbf8ec8b
Signed-off-by: Jim Hahn <jrh3@att.com>
---

diff --git a/applications/common/src/main/java/org/onap/policy/pdp/xacml/application/common/std/StdCombinedPolicyResultsTranslator.java b/applications/common/src/main/java/org/onap/policy/pdp/xacml/application/common/std/StdCombinedPolicyResultsTranslator.java
index c22545cd..57560715 100644
--- a/applications/common/src/main/java/org/onap/policy/pdp/xacml/application/common/std/StdCombinedPolicyResultsTranslator.java
+++ b/applications/common/src/main/java/org/onap/policy/pdp/xacml/application/common/std/StdCombinedPolicyResultsTranslator.java
@@ -157,7 +157,7 @@ public class StdCombinedPolicyResultsTranslator extends StdBaseTranslator {
      * scanAdvice - not implemented in this class.
      *
      * @param advice Collection of advice objects
-     * @param DecisionResponse DecisionResponse object
+     * @param decisionResponse DecisionResponse object
      */
     @Override
     protected void scanAdvice(Collection<Advice> advice, DecisionResponse decisionResponse) {
diff --git a/applications/common/src/main/java/org/onap/policy/pdp/xacml/application/common/std/StdMatchableTranslator.java b/applications/common/src/main/java/org/onap/policy/pdp/xacml/application/common/std/StdMatchableTranslator.java
index 1d76d0e3..9d0124bb 100644
--- a/applications/common/src/main/java/org/onap/policy/pdp/xacml/application/common/std/StdMatchableTranslator.java
+++ b/applications/common/src/main/java/org/onap/policy/pdp/xacml/application/common/std/StdMatchableTranslator.java
@@ -167,7 +167,7 @@ public class StdMatchableTranslator  extends StdBaseTranslator implements Matcha
      * contents and their details.
      *
      * @param closestMatches Map holding the current set of highest weight policy types
-     * @param Obligation Obligation object
+     * @param obligation Obligation object
      */
     protected void scanClosestMatchObligation(
             Map<String, Map<Integer, List<Pair<String, Map<String, Object>>>>> closestMatches, Obligation obligation) {
@@ -371,8 +371,8 @@ public class StdMatchableTranslator  extends StdBaseTranslator implements Matcha
      * For generating target type, we scan for matchable properties
      * and use those to build the policy.
      *
-     * @param properties Properties section of policy
-     * @param policyTypes Collection of policy Type to find matchable metadata
+     * @param policy the policy
+     * @param template template containing the policy
      * @return {@code Pair<TargetType, Integer>} Returns a TargetType and a Total Weight of matchables.
      */
     protected Pair<TargetType, Integer> generateTargetType(ToscaPolicy policy, ToscaServiceTemplate template) {