From: ajay priyadarshi <ajay.priyadarshi@ril.com>
Date: Tue, 20 Mar 2018 06:43:32 +0000 (+0530)
Subject: sonar fix:Code smells in emsdriver ftp
X-Git-Tag: v1.1.0~21
X-Git-Url: https://gerrit.onap.org/r/gitweb?a=commitdiff_plain;h=refs%2Fchanges%2F45%2F36945%2F1;p=vfc%2Fnfvo%2Fdriver%2Fems.git

sonar fix:Code smells in emsdriver ftp

commons/ftp/FTPSrv.java
file name: FTPSrv.java

Change-Id: Ie1fdcaa994aead1e0cfcd1945f9ce54599da5315
Issue-ID: VFC-832
Signed-off-by: ajay priyadarshi <ajay.priyadarshi@ril.com>
---

diff --git a/ems/boco/src/main/java/org/onap/vfc/nfvo/emsdriver/commons/ftp/FTPSrv.java b/ems/boco/src/main/java/org/onap/vfc/nfvo/emsdriver/commons/ftp/FTPSrv.java
index 3d470b5..34baa30 100644
--- a/ems/boco/src/main/java/org/onap/vfc/nfvo/emsdriver/commons/ftp/FTPSrv.java
+++ b/ems/boco/src/main/java/org/onap/vfc/nfvo/emsdriver/commons/ftp/FTPSrv.java
@@ -49,7 +49,6 @@ public class FTPSrv implements FTPInterface {
         ftpClientConfig.setServerTimeZoneId(TimeZone.getDefault().getID());
         this.ftpClient.setControlEncoding("GBK");
         this.ftpClient.configure(ftpClientConfig);
-//		ftpClient.setParserFactory(new ExtendsDefaultFTPFileEntryParserFactory());
 
         if (encode != null && encode.length() > 0) {
             ftpClient.setControlEncoding(encode);
@@ -138,7 +137,7 @@ public class FTPSrv implements FTPInterface {
         String currdir = null;
         try {
             currdir = ftpClient.printWorkingDirectory();
-            if (currdir.endsWith("/") == false) {
+            if (!currdir.endsWith("/")) {
                 currdir = currdir + "/";
             }
             FTPFile[] rfileList = null;
@@ -156,8 +155,7 @@ public class FTPSrv implements FTPInterface {
 
     @Override
     public String pwd() throws IOException {
-        String returnValue = ftpClient.printWorkingDirectory();
-        return returnValue;
+        return ftpClient.printWorkingDirectory();
     }
 
 }