From: Surendra Reddy Katam <SK00524980@techmahindra.com>
Date: Thu, 20 Sep 2018 10:18:34 +0000 (+0530)
Subject: Sonar Major issues
X-Git-Tag: 1.1.10~16^2
X-Git-Url: https://gerrit.onap.org/r/gitweb?a=commitdiff_plain;h=refs%2Fchanges%2F43%2F68043%2F1;p=dmaap%2Fmessagerouter%2Fmsgrtr.git

Sonar Major issues

 This block of commented-out lines of code should be removed
Sonar Link:
https://sonar.onap.org/project/issues?assignees=surendraReddy&id=org.onap.dmaap.messagerouter.msgrtr%3Amsgrtr&open=AWU41Wi2wGn37JfbyHxW&resolved=false&severities=MAJOR
Location:
src/main/java/com/att/dmf/mr/service/impl/EventsServiceImpl.java
Line No-L379 L407 L489

Change-Id: I61fe5ce8021366e497b52e887ff2822d137350a2
Issue-ID: DMAAP-805
Signed-off-by: Surendra Reddy Katam <SK00524980@techmahindra.com>
---

diff --git a/src/main/java/com/att/dmf/mr/service/impl/EventsServiceImpl.java b/src/main/java/com/att/dmf/mr/service/impl/EventsServiceImpl.java
index 22b60fe..88c5fd9 100644
--- a/src/main/java/com/att/dmf/mr/service/impl/EventsServiceImpl.java
+++ b/src/main/java/com/att/dmf/mr/service/impl/EventsServiceImpl.java
@@ -376,7 +376,7 @@ public class EventsServiceImpl implements EventsService {
 		String topicNameStd = null;
 
 		// topicNameStd=
-		// ctx.getConfigReader().getSettings().getString("enforced.topic.name.AAF");
+		
 		topicNameStd = com.att.ajsc.beans.PropertiesMapBean.getProperty(CambriaConstants.msgRtr_prop,
 				"enforced.topic.name.AAF");
 		String metricTopicname = com.att.ajsc.filemonitor.AJSCPropertiesMap.getProperty(CambriaConstants.msgRtr_prop,
@@ -404,7 +404,7 @@ public class EventsServiceImpl implements EventsService {
 		if (topicNameEnforced || (user == null && null != ctx.getRequest().getHeader("Authorization")
 				&& !topic.equalsIgnoreCase(metricTopicname))) {
 			// the topic name will be sent by the client
-			// String permission = "com.att.dmaap.mr.topic"+"|"+topic+"|"+"pub";
+		
 			DMaaPAAFAuthenticator aaf = new DMaaPAAFAuthenticatorImpl();
 			String permission = aaf.aafPermissionString(topic, "pub");
 			if (!aaf.aafAuthentication(ctx.getRequest(), permission)) {
@@ -486,7 +486,7 @@ public class EventsServiceImpl implements EventsService {
 		if (null != batchlen)
 			maxEventBatch = Long.parseLong(batchlen);
 		// long maxEventBatch =
-		// ctx.getConfigReader().getSettings().getLong(BATCH_LENGTH, 1024 * 16);
+		
 		final LinkedList<Publisher.message> batch = new LinkedList<>();
 		// final ArrayList<KeyedMessage<String, String>> kms = new
 		// ArrayList<KeyedMessage<String, String>>();