From: Jakub Dudycz <jakub.dudycz@nokia.com>
Date: Tue, 13 Mar 2018 11:06:08 +0000 (+0100)
Subject: StreamHelper unit tests
X-Git-Tag: v1.3.0~174
X-Git-Url: https://gerrit.onap.org/r/gitweb?a=commitdiff_plain;h=refs%2Fchanges%2F43%2F35443%2F9;p=appc.git

StreamHelper unit tests

Improved code coverage

Change-Id: Ie0dcf723e73890aa24b761fb3b46e2739d239040
Issue-ID: APPC-724
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
---

diff --git a/appc-common/src/test/java/org/onap/appc/util/TestStreamHelper.java b/appc-common/src/test/java/org/onap/appc/util/StreamHelperTest.java
similarity index 90%
rename from appc-common/src/test/java/org/onap/appc/util/TestStreamHelper.java
rename to appc-common/src/test/java/org/onap/appc/util/StreamHelperTest.java
index 70ac8a087..42c4bf58b 100644
--- a/appc-common/src/test/java/org/onap/appc/util/TestStreamHelper.java
+++ b/appc-common/src/test/java/org/onap/appc/util/StreamHelperTest.java
@@ -31,7 +31,7 @@ import java.io.ByteArrayInputStream;
 import org.junit.Test;
 import org.onap.appc.util.StreamHelper;
 
-public class TestStreamHelper {
+public class StreamHelperTest {
 
     private static final String text = "Filler text (also placeholder text or dummy text) is text that shares "
         + "some characteristics of a real written text, but is random or otherwise generated. It may be used "
@@ -66,16 +66,22 @@ public class TestStreamHelper {
         + "$%&'()*+,-./0123456789:;<=>?@ABCDEFGHIJKLMNOPQRSTUVWXYZ[\\]^_`abcdefghijk\n";
 
     @Test
-    public void testStreamHelperNullStream() {
+    public void should_return_empty_string_when_given_null_input_stream() {
         assertNotNull(StreamHelper.getStringFromInputStream(null));
         assertEquals("", StreamHelper.getStringFromInputStream(null));
     }
 
     @Test
-    public void testStreamHelperByteArrayStream() {
-        ByteArrayInputStream in = new ByteArrayInputStream(text.getBytes());
+    public void should_return_empty_string_when_given_empty_byte_array() {
+        ByteArrayInputStream emptyInputStream = new ByteArrayInputStream(new byte[0]);
 
-        assertEquals(text, StreamHelper.getStringFromInputStream(in));
+        assertEquals("", StreamHelper.getStringFromInputStream(emptyInputStream));
     }
 
+    @Test
+    public void should_return_string_when_given_byte_array() {
+        ByteArrayInputStream inputStream = new ByteArrayInputStream(text.getBytes());
+
+        assertEquals(text, StreamHelper.getStringFromInputStream(inputStream));
+    }
 }