From: Sindhuri.A <arcot.sindhuri@huawei.com>
Date: Fri, 19 Apr 2019 17:56:15 +0000 (+0530)
Subject: Move String literal to left-hand side of equals
X-Git-Tag: 1.5.2~459^2
X-Git-Url: https://gerrit.onap.org/r/gitweb?a=commitdiff_plain;h=refs%2Fchanges%2F42%2F85842%2F1;p=so.git

Move String literal to left-hand side of equals

Move String literal to left-hand side of equals DSLNodeKey class

Issue-ID: SO-1490

Change-Id: Ie8b1b12aaf38bbb0f1f37a56f375ab4c002d6407
Signed-off-by: Sindhuri.A <arcot.sindhuri@huawei.com>
---

diff --git a/common/src/main/java/org/onap/so/client/graphinventory/entities/DSLNodeKey.java b/common/src/main/java/org/onap/so/client/graphinventory/entities/DSLNodeKey.java
index bf33e8f8d3..f7f5d78604 100644
--- a/common/src/main/java/org/onap/so/client/graphinventory/entities/DSLNodeKey.java
+++ b/common/src/main/java/org/onap/so/client/graphinventory/entities/DSLNodeKey.java
@@ -56,9 +56,9 @@ public class DSLNodeKey implements QueryStep {
         result.append("('").append(keyName).append("', ");
         List<String> temp = new ArrayList<>();
         for (String item : values) {
-            if (item.equals("null")) {
+            if ("null".equals(item)) {
                 temp.add(String.format("' %s '", item));
-            } else if (item.equals("")) {
+            } else if ("".equals(item)) {
                 temp.add("' '");
             } else {
                 temp.add(String.format("'%s'", item));