From: Abhai Singh <Abhai.Singh@amdocs.com>
Date: Thu, 4 Jan 2018 06:16:40 +0000 (+0530)
Subject: Fix Sonar ImageDaoZusammenImpl
X-Git-Tag: v1.2.0~506
X-Git-Url: https://gerrit.onap.org/r/gitweb?a=commitdiff_plain;h=refs%2Fchanges%2F29%2F27329%2F2;p=sdc.git

Fix Sonar ImageDaoZusammenImpl

Fixed reported sonar issue

Change-Id: I129fa4cbb5ba09c361663f7259807fca690eff0e
Issue-ID: SDC-343
Signed-off-by: Abhai Singh <Abhai.Singh@amdocs.com>
---

diff --git a/openecomp-be/lib/openecomp-sdc-vendor-software-product-lib/openecomp-sdc-vendor-software-product-core/src/main/java/org/openecomp/sdc/vendorsoftwareproduct/dao/impl/zusammen/ImageDaoZusammenImpl.java b/openecomp-be/lib/openecomp-sdc-vendor-software-product-lib/openecomp-sdc-vendor-software-product-core/src/main/java/org/openecomp/sdc/vendorsoftwareproduct/dao/impl/zusammen/ImageDaoZusammenImpl.java
index 24ca072b23..d6a56bb612 100644
--- a/openecomp-be/lib/openecomp-sdc-vendor-software-product-lib/openecomp-sdc-vendor-software-product-core/src/main/java/org/openecomp/sdc/vendorsoftwareproduct/dao/impl/zusammen/ImageDaoZusammenImpl.java
+++ b/openecomp-be/lib/openecomp-sdc-vendor-software-product-lib/openecomp-sdc-vendor-software-product-core/src/main/java/org/openecomp/sdc/vendorsoftwareproduct/dao/impl/zusammen/ImageDaoZusammenImpl.java
@@ -38,6 +38,7 @@ public class ImageDaoZusammenImpl implements ImageDao {
 
   @Override
   public void registerVersioning(String versionableEntityType) {
+    // registerVersioning not implemented for ImageDaoZusammenImpl
   }
 
   @Override
@@ -51,11 +52,10 @@ public class ImageDaoZusammenImpl implements ImageDao {
 
   private Collection<ImageEntity> listImages(SessionContext context,
                                              ElementContext elementContext, ImageEntity image) {
-    ElementToImageConvertor convertor = new ElementToImageConvertor();
     return zusammenAdaptor
         .listElementsByName(context, elementContext, new Id(image.getComponentId()),
             ElementType.Images.name())
-        .stream().map(convertor::convert)
+        .stream().map(new ElementToImageConvertor()::convert)
         .map(imageEntity -> {
           imageEntity.setComponentId(image.getComponentId());
           imageEntity.setVspId(image.getVspId());
@@ -137,9 +137,9 @@ public class ImageDaoZusammenImpl implements ImageDao {
         null, ElementType.Images.name());
 
     if (elementOptional.isPresent()) {
-      Element ImagesElement = elementOptional.get();
-      Collection<Element> Images = ImagesElement.getSubElements();
-      Images.forEach(image -> {
+      Element imagesElement = elementOptional.get();
+      Collection<Element> images = imagesElement.getSubElements();
+      images.forEach(image -> {
         ZusammenElement imageZusammenElement = buildElement(image.getElementId(), Action.DELETE);
         zusammenAdaptor.saveElement(context, elementContext, imageZusammenElement, "Delete image " +
             "with id " + image.getElementId());