From: burdziak Date: Mon, 8 Jul 2019 13:17:33 +0000 (+0200) Subject: Fix sonar issues in LogRegistry X-Git-Tag: 3.0.0~170^2 X-Git-Url: https://gerrit.onap.org/r/gitweb?a=commitdiff_plain;h=refs%2Fchanges%2F23%2F91023%2F1;p=portal%2Fsdk.git Fix sonar issues in LogRegistry Change-Id: I0aeaed5291a5c1c8fd7f4ccacbd78f6974c5e8e0 Issue-ID: PORTAL-523 Signed-off-by: burdziak --- diff --git a/ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/scheduler/LogRegistry.java b/ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/scheduler/LogRegistry.java index 5c80b916..93c814d0 100644 --- a/ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/scheduler/LogRegistry.java +++ b/ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/scheduler/LogRegistry.java @@ -52,24 +52,19 @@ import org.springframework.stereotype.Component; @DependsOn({ "systemProperties" }) public class LogRegistry extends CronRegistry { - private static final String groupName = "AppGroup"; - private static final String jobName = "LogJob"; - private static final String triggerName = "LogTrigger"; + private static final String GROUP_NAME = "AppGroup"; + private static final String JOB_NAME = "LogJob"; + private static final String TRIGGER_NAME = "LogTrigger"; - // @Autowired - // private SystemProperties systemProperties; - - // @Bean public JobDetailFactoryBean jobDetailFactoryBean() { - Map map = new HashMap(); + Map map = new HashMap<>(); map.put("units", "bytes"); - return jobDetailFactoryBean(groupName, jobName, LogJob.class, map); + return jobDetailFactoryBean(GROUP_NAME, JOB_NAME, LogJob.class, map); } - // @Bean public CronTriggerFactoryBean cronTriggerFactoryBean() throws ParseException { // "0 * * * * ? * - return cronTriggerFactoryBean(groupName, triggerName, SystemProperties.getProperty(SystemProperties.LOG_CRON)); + return cronTriggerFactoryBean(GROUP_NAME, TRIGGER_NAME, SystemProperties.getProperty(SystemProperties.LOG_CRON)); } }