From: vasraz <vasyl.razinkov@est.tech>
Date: Mon, 12 Jun 2023 11:43:59 +0000 (+0100)
Subject: Improve error handling for user-created Policies
X-Git-Tag: 1.13.1~21
X-Git-Url: https://gerrit.onap.org/r/gitweb?a=commitdiff_plain;h=refs%2Fchanges%2F16%2F134816%2F1;p=sdc.git

Improve error handling for user-created Policies

Signed-off-by: Vasyl Razinkov <vasyl.razinkov@est.tech>
Change-Id: I86bf83584da186d03a3e54c3839280b10df71939
Issue-ID: SDC-4531
---

diff --git a/catalog-be/src/main/java/org/openecomp/sdc/be/components/validation/PolicyUtils.java b/catalog-be/src/main/java/org/openecomp/sdc/be/components/validation/PolicyUtils.java
index b1bc10b10a..7494e75259 100644
--- a/catalog-be/src/main/java/org/openecomp/sdc/be/components/validation/PolicyUtils.java
+++ b/catalog-be/src/main/java/org/openecomp/sdc/be/components/validation/PolicyUtils.java
@@ -131,9 +131,9 @@ public class PolicyUtils {
         try {
             int beginIndex = policyName.lastIndexOf(GROUP_POLICY_NAME_DELIMETER) + GROUP_POLICY_NAME_DELIMETER.length();
             String counterStr = policyName.substring(beginIndex, endIndex);
-            counter = Integer.valueOf(counterStr) + 1;
+            counter = Integer.parseInt(counterStr) + 1;
         } catch (NumberFormatException | IndexOutOfBoundsException e) {
-            log.error("#extractNextPolicyCounter - An error occurred when attempting to extract counter from policy name [{}]. ", policyName, e);
+            log.warn("#extractNextPolicyCounter - Cannot extract counter from policy name [{}]. ", policyName, e);
         }
         return counter;
     }
@@ -160,13 +160,7 @@ public class PolicyUtils {
     }
 
     private static boolean isUpdatedField(String oldField, String newField) {
-        boolean isUpdatedField = false;
-        if (isEmpty(oldField) && isNotEmpty(newField)) {
-            isUpdatedField = true;
-        } else if (isNotEmpty(oldField) && isNotEmpty(newField) && !oldField.equals(newField)) {
-            isUpdatedField = true;
-        }
-        return isUpdatedField;
+        return (isEmpty(oldField) && isNotEmpty(newField)) || (isNotEmpty(oldField) && isNotEmpty(newField) && !oldField.equals(newField));
     }
 
     private static void logImmutableFieldUpdateWarning(String oldValue, String newValue, JsonPresentationFields field) {