From: Surendra Reddy Katam Date: Mon, 10 Sep 2018 10:42:20 +0000 (+0530) Subject: Sonar Major issues X-Git-Tag: 1.1.8~8 X-Git-Url: https://gerrit.onap.org/r/gitweb?a=commitdiff_plain;h=refs%2Fchanges%2F07%2F65507%2F1;p=dmaap%2Fmessagerouter%2Fmsgrtr.git Sonar Major issues This block of commented-out lines of code should be removed Sonar Link: https://sonar.onap.org/project/issues?assignees=surendraReddy&id=org.onap.dmaap.messagerouter.msgrtr%3Amsgrtr&resolved=false&severities=MAJOR Location: src/main/java/com/att/dmf/mr/service/impl/TopicServiceImpl.java Line No- L276 L619 L630 Change-Id: I697b1e3503fc1fe80e501ace74782c272faefc10 Issue-ID: DMAAP-763 Signed-off-by: Surendra Reddy Katam --- diff --git a/src/main/java/com/att/dmf/mr/service/impl/TopicServiceImpl.java b/src/main/java/com/att/dmf/mr/service/impl/TopicServiceImpl.java index 3a707c4..571f004 100644 --- a/src/main/java/com/att/dmf/mr/service/impl/TopicServiceImpl.java +++ b/src/main/java/com/att/dmf/mr/service/impl/TopicServiceImpl.java @@ -273,7 +273,7 @@ public class TopicServiceImpl implements TopicService { */ - //key="admin"; + //LOGGER.info("key ==================== " + key); } @@ -616,7 +616,7 @@ public class TopicServiceImpl implements TopicService { // //// String permission = - // DMaaPAAFAuthenticator aaf = new DMaaPAAFAuthenticatorImpl(); + // String permission = aaf.aafPermissionString(topicName, "manage"); // if(!aaf.aafAuthentication(dmaapContext.getRequest(), permission)) // { @@ -627,7 +627,7 @@ public class TopicServiceImpl implements TopicService { // DMaaPResponseCode.ACCESS_NOT_PERMITTED.getResponseCode(), // errorMessages.getNotPermitted1()+" - // LOGGER.info(errRes); + // throw new DMaaPAccessDeniedException(errRes); // } // }