From: Taka Cho <takamune.cho@att.com>
Date: Fri, 26 Jun 2020 15:47:18 +0000 (-0400)
Subject: controlloop m2 sonar fix
X-Git-Tag: 1.7.0~9
X-Git-Url: https://gerrit.onap.org/r/gitweb?a=commitdiff_plain;h=refs%2Fchanges%2F06%2F109606%2F4;p=policy%2Fdrools-applications.git

controlloop m2 sonar fix

- remove some unused statement
- remove unnecessary check

Issue-ID: POLICY-2616
Change-Id: Ieb2c898a3c6ad7210642aef990b43c9a01fc15b3
Signed-off-by: Taka Cho <takamune.cho@att.com>
---

diff --git a/controlloop/m2/util/src/main/java/org/onap/policy/util/DroolsSessionCommonSerializable.java b/controlloop/m2/util/src/main/java/org/onap/policy/util/DroolsSessionCommonSerializable.java
index 0834026a0..c76a8c244 100644
--- a/controlloop/m2/util/src/main/java/org/onap/policy/util/DroolsSessionCommonSerializable.java
+++ b/controlloop/m2/util/src/main/java/org/onap/policy/util/DroolsSessionCommonSerializable.java
@@ -108,14 +108,13 @@ public class DroolsSessionCommonSerializable implements Serializable {
         if (session != null) {
             // we found the 'PolicySession' -- now, look for the adjunct
             Object adj = session.getAdjunct(Adjunct.class);
-            if (adj == null || !(adj instanceof Adjunct)) {
+            if (!(adj instanceof Adjunct)) {
                 // adjunct does not exist, or has the wrong type -- create it
                 adjunct = new Adjunct();
                 session.setAdjunct(Adjunct.class, adjunct);
             } else {
                 // found the adjunct -- return it
                 adjunct = (Adjunct) adj;
-                //adjunct = Adjunct.class.cast(adj);
             }
         }
         return adjunct;