From: Kanagaraj Manickam k00365106 <kanagaraj.manickam@huawei.com>
Date: Thu, 30 Nov 2017 23:32:29 +0000 (+0530)
Subject: Optimze invalid params check
X-Git-Tag: 1.0.0-Amsterdam^0
X-Git-Url: https://gerrit.onap.org/r/gitweb?a=commitdiff_plain;h=refs%2Fchanges%2F01%2F25301%2F1;p=cli.git

Optimze invalid params check

Issue-ID: CLI-83

Change-Id: I163251d99ff1cfaf3cbc20cf397cbab0b5d9a264
Signed-off-by: Kanagaraj Manickam k00365106 <kanagaraj.manickam@huawei.com>
---

diff --git a/framework/src/main/java/org/onap/cli/fw/utils/OnapCommandUtils.java b/framework/src/main/java/org/onap/cli/fw/utils/OnapCommandUtils.java
index 77d50171..4a340dab 100644
--- a/framework/src/main/java/org/onap/cli/fw/utils/OnapCommandUtils.java
+++ b/framework/src/main/java/org/onap/cli/fw/utils/OnapCommandUtils.java
@@ -218,7 +218,7 @@ public class OnapCommandUtils {
     private static InputStream loadSchemaFromFile(String schemaLocation) throws OnapCommandInvalidSchema {
         File schemaFile = new File(schemaLocation);
         try {
-            FileInputStream inputFileStream = new FileInputStream(schemaFile);
+            FileInputStream inputFileStream = new FileInputStream(schemaFile);  // NOSONAR
             if (!schemaFile.isFile()) {
                 throw new OnapCommandInvalidSchema(schemaFile.getName(), SCHEMA_FILE_NOT_EXIST);
             }
@@ -294,15 +294,14 @@ public class OnapCommandUtils {
                 }
             }
 
-            List<String> invalidExclude = excludeAuthParams.stream().filter(includeParams::contains)
+            List<String> invalidParams = excludeAuthParams.stream().filter(includeParams::contains)
                     .collect(Collectors.toList());
 
-            List<String> invalidInclude = includeAuthParams.stream().filter(excludeParams::contains)
-                    .filter(p->!includeParams.contains(p)).collect(Collectors.toList());
+            invalidParams.addAll(includeAuthParams.stream().filter(excludeParams::contains)
+                    .filter(p->!includeParams.contains(p)).collect(Collectors.toList()));
 
-            if (!invalidExclude.isEmpty() || !invalidInclude.isEmpty()) {
-                throw new OnapCommandInvalidDefaultParameter(Stream.concat(invalidExclude.stream(), invalidInclude.stream())
-                        .collect(Collectors.toList()));
+            if (!invalidParams.isEmpty()) {
+                throw new OnapCommandInvalidDefaultParameter(invalidParams);
             }