From: Driptaroop Das <driptaroop.das@in.ibm.com>
Date: Thu, 31 Jan 2019 19:44:43 +0000 (+0530)
Subject: MusicHealthCheck.java - Multiple Sonar Fixes
X-Git-Tag: 2.5.8~22^2
X-Git-Url: https://gerrit.onap.org/r/gitweb?a=commitdiff_plain;h=fb745184ca27f81f270884023a10dd2219a526c1;hp=7a6ad9831c7009f85ad881a695529fdc0246c3a6;p=music.git

MusicHealthCheck.java - Multiple Sonar Fixes

MusicHealthCheck.java - Multiple Sonar Fixes

Issue-ID: MUSIC-302
Change-Id: I8e9b8be0d35b5a8d3042ffe056b4d29c5bb7888e
Signed-off-by: Driptaroop Das <driptaroop.das@in.ibm.com>
---

diff --git a/src/main/java/org/onap/music/eelf/healthcheck/MusicHealthCheck.java b/src/main/java/org/onap/music/eelf/healthcheck/MusicHealthCheck.java
index 93c44468..7cff9d30 100644
--- a/src/main/java/org/onap/music/eelf/healthcheck/MusicHealthCheck.java
+++ b/src/main/java/org/onap/music/eelf/healthcheck/MusicHealthCheck.java
@@ -83,20 +83,12 @@ public class MusicHealthCheck {
     }
 
     private Boolean getAdminKeySpace(String consistency) throws MusicServiceException {
-
-
         PreparedQueryObject pQuery = new PreparedQueryObject();
         pQuery.appendQueryString("insert into admin.healthcheck (id) values (?)");
         pQuery.addValue(UUID.randomUUID());
-            ResultType rs = MusicCore.nonKeyRelatedPut(pQuery, consistency);
-            logger.info(rs.toString());
-            if (rs != null) {
-                return Boolean.TRUE;
-            } else {
-                return Boolean.FALSE;
-            }
-
-
+        ResultType rs = MusicCore.nonKeyRelatedPut(pQuery, consistency);
+        logger.info(rs.toString());
+        return null != rs;
     }
     
     private boolean createKeyspace() {
@@ -110,10 +102,7 @@ public class MusicHealthCheck {
             e.printStackTrace();
             logger.error("Error", e);
         }
-        if(rs != null && rs.getResult().toLowerCase().contains("success"))
-            return true;
-        else
-            return false;
+        return rs != null && rs.getResult().toLowerCase().contains("success");
     }
 
     public String getZookeeperStatus() {