From: Pawel Wieczorek <p.wieczorek2@samsung.com>
Date: Wed, 24 Jul 2019 12:19:46 +0000 (+0200)
Subject: k8s: Change virtual environment utility scripts privilege requirements
X-Git-Tag: 6.0.0-ONAP~431
X-Git-Url: https://gerrit.onap.org/r/gitweb?a=commitdiff_plain;h=f8a1ad0768dde0c3babc035b173dc3b87079a7d6;p=integration.git

k8s: Change virtual environment utility scripts privilege requirements

This patch also extends in-file comment on scripts' requirements and
suggested usage.

Issue-ID: SECCOM-235
Change-Id: I0dddbad79fb3392ffe35c3e06d4006cd499d9923
Signed-off-by: Pawel Wieczorek <p.wieczorek2@samsung.com>
---

diff --git a/test/security/k8s/tools/casablanca/get_ranchercli.sh b/test/security/k8s/tools/casablanca/get_ranchercli.sh
index 76d5594b6..8ffbc5f58 100755
--- a/test/security/k8s/tools/casablanca/get_ranchercli.sh
+++ b/test/security/k8s/tools/casablanca/get_ranchercli.sh
@@ -1,5 +1,23 @@
 #!/usr/bin/env bash
 
+#
+# @file        test/security/k8s/tools/casablanca/get_ranchercli.sh
+# @author      Pawel Wieczorek <p.wieczorek2@samsung.com>
+# @brief       Utility for obtaining Rancher CLI tool
+#
+
+# Dependencies:
+#     wget
+#     tar
+#     coreutils
+#
+# Privileges:
+# Script expects to be run with administrative privileges for accessing /usr/local/bin
+#
+# Usage:
+# # ./get_ranchercli.sh [VERSION [ARCH [SYSTEM]]]
+#
+
 # Constants
 DEFAULT_VERSION='v0.6.12'
 DEFAULT_ARCH='amd64'
@@ -20,8 +38,7 @@ wget "$URL"
 tar xf "$ARCHIVE"
 
 # Installation
-echo '# Privilege elevation needed to move Rancher CLI binary to /usr/local/bin'
-sudo mv "${DIRECTORY}/rancher" /usr/local/bin/
+mv "${DIRECTORY}/rancher" /usr/local/bin/
 
 # Cleanup
 rmdir "$DIRECTORY"
diff --git a/test/security/k8s/tools/dublin/get_rke.sh b/test/security/k8s/tools/dublin/get_rke.sh
index ffa5c707e..63ef8c77e 100755
--- a/test/security/k8s/tools/dublin/get_rke.sh
+++ b/test/security/k8s/tools/dublin/get_rke.sh
@@ -1,5 +1,22 @@
 #!/usr/bin/env bash
 
+#
+# @file        test/security/k8s/tools/dublin/get_rke.sh
+# @author      Pawel Wieczorek <p.wieczorek2@samsung.com>
+# @brief       Utility for obtaining RKE tool
+#
+
+# Dependencies:
+#     wget
+#     coreutils
+#
+# Privileges:
+# Script expects to be run with administrative privileges for accessing /usr/local/bin
+#
+# Usage:
+# # ./get_rke.sh [VERSION [ARCH [SYSTEM]]]
+#
+
 # Constants
 DEFAULT_VERSION='v0.2.1'
 DEFAULT_ARCH='amd64'
@@ -19,5 +36,4 @@ wget "$URL"
 chmod +x "${BINARY}"
 
 # Installation
-echo '# Privilege elevation needed to move RKE binary to /usr/local/bin'
-sudo mv "${BINARY}" "/usr/local/bin/${BINARY%%_*}" # this also renames binary to "rke"
+mv "${BINARY}" "/usr/local/bin/${BINARY%%_*}" # this also renames binary to "rke"