From: mark.j.leonard <mark.j.leonard@gmail.com>
Date: Tue, 12 Mar 2019 12:39:57 +0000 (+0000)
Subject: Fix Sonar vulnerability for SystemProperty enum
X-Git-Tag: 1.4.0~7
X-Git-Url: https://gerrit.onap.org/r/gitweb?a=commitdiff_plain;h=f4f3d47609349f511ff6ff1a8589ab5cc181d92c;p=aai%2Fvalidation.git

Fix Sonar vulnerability for SystemProperty enum

Sonar wrongly identifies the public set() method as a setter for the
enum and logs a violation (enums should not be mutable).
Change the access level modifier (to make it not public) as lowering the
visibility suppresses the Sonar false positive.

Change-Id: Ic3e5ade0410a7702a89e22fd72b6fbe4d8db0dc4
Issue-ID: AAI-2057
Signed-off-by: mark.j.leonard <mark.j.leonard@gmail.com>
---

diff --git a/src/main/java/org/onap/aai/validation/ValidationServiceApplication.java b/src/main/java/org/onap/aai/validation/ValidationServiceApplication.java
index 5db497d..52cb339 100644
--- a/src/main/java/org/onap/aai/validation/ValidationServiceApplication.java
+++ b/src/main/java/org/onap/aai/validation/ValidationServiceApplication.java
@@ -72,7 +72,7 @@ public class ValidationServiceApplication extends SpringBootServletInitializer {
             return StringUtils.decrypt(propertyValue);
         }
 
-        public void set(String propertyValue) {
+        protected void set(String propertyValue) {
             System.setProperty(propertyName, propertyValue);
         }
     }