From: Michal Zegan <m.zegan@samsung.com>
Date: Wed, 22 May 2019 13:52:37 +0000 (+0200)
Subject: Make molecule tests for certificates independent from docker role
X-Git-Tag: 6.0.0-ONAP~177^2
X-Git-Url: https://gerrit.onap.org/r/gitweb?a=commitdiff_plain;h=f2b9a04b5bc1f8c22cba4ba587f0526306d92ac8;p=oom%2Foffline-installer.git

Make molecule tests for certificates independent from docker role

Currently molecule tests for certificates role call the
docker role just to make one handler available.
It actually breaks best practices of unit testing,
the docker role shouldn't be called nor tested in
unit test of certificates role.
This commit makes certificates role independent by just
creating fake handlers.

Change-Id: Iec7934c7c1f4e9b37ff523e1d86a3beaaa88bdcf
Issue-ID: OOM-1864
Signed-off-by: Michal Zegan <m.zegan@samsung.com>
---

diff --git a/ansible/roles/certificates/molecule/default/playbook.yml b/ansible/roles/certificates/molecule/default/playbook.yml
index 5dcd42ee..13583ebb 100644
--- a/ansible/roles/certificates/molecule/default/playbook.yml
+++ b/ansible/roles/certificates/molecule/default/playbook.yml
@@ -1,14 +1,17 @@
 ---
 - name: Infra
   hosts: infrastructure
+  handlers:
+    - name: Restart Docker
+      debug: msg="Docker restart called"
   roles:
     - certificates
-    - docker  # docker role needed here just because of docker restart handler
 
 - name: Kube
   hosts: kubernetes
-  roles:
-    - docker  # docker role needed here just because of docker restart handler
+  handlers:
+    - name: Restart Docker
+      debug: msg="Docker restart called"
   tasks:
     - include_role:
         name: certificates
diff --git a/ansible/roles/certificates/molecule/default/prepare.yml b/ansible/roles/certificates/molecule/default/prepare.yml
deleted file mode 100644
index 8df759c9..00000000
--- a/ansible/roles/certificates/molecule/default/prepare.yml
+++ /dev/null
@@ -1,5 +0,0 @@
----
-- name: Prepare infra
-  hosts: all
-  roles:
-    - prepare-docker