From: Pamela Dragosh <pdragosh@research.att.com>
Date: Tue, 13 Mar 2018 12:08:36 +0000 (+0000)
Subject: Merge "Sonar Major"
X-Git-Tag: v1.2.0~67
X-Git-Url: https://gerrit.onap.org/r/gitweb?a=commitdiff_plain;h=eff3339eafcc4cb46b983ff1a7681ff8a4117d39;hp=cbd2227c7b6adfa878eb97b6f6a85b73bf1d1a75;p=policy%2Fengine.git

Merge "Sonar Major"
---

diff --git a/POLICY-SDK-APP/src/main/java/org/onap/policy/controller/CreateFirewallController.java b/POLICY-SDK-APP/src/main/java/org/onap/policy/controller/CreateFirewallController.java
index 7001aa9a8..3e24dc7c4 100644
--- a/POLICY-SDK-APP/src/main/java/org/onap/policy/controller/CreateFirewallController.java
+++ b/POLICY-SDK-APP/src/main/java/org/onap/policy/controller/CreateFirewallController.java
@@ -344,7 +344,7 @@ public class CreateFirewallController extends RestrictedBaseController {
 				jpaTermList = (TermList) tmList.get(0);
 				if (jpaTermList != null){				
 					ruleSrcList= jpaTermList.getSrcIPList();	
-					if ((ruleSrcList!= null) && (!ruleSrcList.isEmpty()) && !ruleSrcList.equals("null")){
+					if ((ruleSrcList!= null) && (!ruleSrcList.isEmpty()) && !"null".equals(ruleSrcList)){
 						displayString.append("Source IP List: " + jpaTermList.getSrcIPList());
 						displayString.append(" ; \t\n");
 						for(String srcList:ruleSrcList.split(",")){