From: sebdet <sebastien.determe@intl.att.com>
Date: Thu, 23 Apr 2020 13:17:59 +0000 (+0200)
Subject: Fix bugs reported by sonar
X-Git-Tag: 6.0.0~11^2~99^2
X-Git-Url: https://gerrit.onap.org/r/gitweb?a=commitdiff_plain;h=e7c9326c63077634c5aa68940f5c24677177c9d6;p=policy%2Fclamp.git

Fix bugs reported by sonar

Fix bugs reported by sonar as critical, major, ...

Issue-ID: CLAMP-841
Signed-off-by: sebdet <sebastien.determe@intl.att.com>
Change-Id: Id525d532d4f405216da44f95503e06e172458e70
---

diff --git a/ui-react/src/components/dialogs/ManageDictionaries/ManageDictionaries.js b/ui-react/src/components/dialogs/ManageDictionaries/ManageDictionaries.js
index 2af1b7ce4..71477ae0c 100644
--- a/ui-react/src/components/dialogs/ManageDictionaries/ManageDictionaries.js
+++ b/ui-react/src/components/dialogs/ManageDictionaries/ManageDictionaries.js
@@ -88,11 +88,13 @@ function SubDict(props) {
 	const {onChange} = props;
 	const subDicts = [];
 	subDicts.push('Default');
-	for(var item in dictList) {
-		if(dictList[item].secondLevelDictionary === 1) {
-			subDicts.push(dictList[item].name);
-		}
-	};
+	if (dictList != "undefined"  && dictList.length > 0) {
+        for(var item in dictList) {
+            if(dictList[item].secondLevelDictionary === 1) {
+                subDicts.push(dictList[item].name);
+            }
+        };
+	}
 	subDicts.push('');
  	var optionItems = subDicts.map(
 		(item) => <option key={item}>{item}</option>