From: SwapnilPathak <SP00494485@techmahindra.com>
Date: Wed, 20 Sep 2017 12:00:07 +0000 (+0530)
Subject: Fix for Sonar major issues
X-Git-Tag: v1.1.0~68^2
X-Git-Url: https://gerrit.onap.org/r/gitweb?a=commitdiff_plain;h=e367918747050eb3c989038d52dd80ad096ad3ce;p=policy%2Fdrools-applications.git

Fix for Sonar major issues

Move the String literal on left side of string comparison.

Issue-ID: POLICY-249
Change-Id: I8086a6fc1dc24719c3ffd3785a12c086ab555ae9
Signed-off-by: SwapnilPathak <SP00494485@techmahindra.com>
---

diff --git a/controlloop/common/model-impl/events/src/main/java/org/onap/policy/controlloop/ControlLoopEventStatus.java b/controlloop/common/model-impl/events/src/main/java/org/onap/policy/controlloop/ControlLoopEventStatus.java
index f74b626cb..c51fe3980 100644
--- a/controlloop/common/model-impl/events/src/main/java/org/onap/policy/controlloop/ControlLoopEventStatus.java
+++ b/controlloop/common/model-impl/events/src/main/java/org/onap/policy/controlloop/ControlLoopEventStatus.java
@@ -45,7 +45,7 @@ public enum ControlLoopEventStatus {
 		//
 		// In case DCAE uses the old abatement
 		//
-		if (status.equalsIgnoreCase("abatement")) {
+		if ("abatement".equalsIgnoreCase(status)) {
 			return ABATED;
 		}
 		return null;