From: Thomas Nelson <nelson24@att.com>
Date: Wed, 20 Feb 2019 18:55:43 +0000 (+0000)
Subject: Merge "MusicHealthCheck.java - Multiple Sonar Fixes"
X-Git-Tag: 2.5.8~22
X-Git-Url: https://gerrit.onap.org/r/gitweb?a=commitdiff_plain;h=d5fc44114502279cd20a65a420e18f03b205c9ad;p=music.git

Merge "MusicHealthCheck.java - Multiple Sonar Fixes"
---

d5fc44114502279cd20a65a420e18f03b205c9ad
diff --cc src/main/java/org/onap/music/eelf/healthcheck/MusicHealthCheck.java
index 3e962a02,7cff9d30..1f9fe5ba
--- a/src/main/java/org/onap/music/eelf/healthcheck/MusicHealthCheck.java
+++ b/src/main/java/org/onap/music/eelf/healthcheck/MusicHealthCheck.java
@@@ -106,12 -98,11 +98,9 @@@ public class MusicHealthCheck 
          try {
              rs = MusicCore.nonKeyRelatedPut(pQuery, ConsistencyLevel.ONE.toString());
          } catch (MusicServiceException e) {
 -            // TODO Auto-generated catch block
 -            e.printStackTrace();
 -            logger.error("Error", e);
 +            logger.error(EELFLoggerDelegate.errorLogger, e.getMessage(),AppMessages.UNKNOWNERROR, ErrorSeverity.ERROR, ErrorTypes.UNKNOWN);
          }
-         if(rs != null && rs.getResult().toLowerCase().contains("success"))
-             return true;
-         else
-             return false;
+         return rs != null && rs.getResult().toLowerCase().contains("success");
      }
  
      public String getZookeeperStatus() {