From: Remigiusz Janeczek <remigiusz.janeczek@nokia.com>
Date: Thu, 23 Jul 2020 11:00:25 +0000 (+0200)
Subject: Add log when file is skipped because it was already published
X-Git-Tag: 1.4.2~4^2
X-Git-Url: https://gerrit.onap.org/r/gitweb?a=commitdiff_plain;h=cfc1a64f0ec5e29ea11dd769bb7ef560f5491202;p=dcaegen2%2Fcollectors%2Fdatafile.git

Add log when file is skipped because it was already published

Issue-ID: DCAEGEN2-2366
Signed-off-by: Remigiusz Janeczek <remigiusz.janeczek@nokia.com>
Change-Id: I913b887833e412dd9c0093936a9231d37f63e7d1
---

diff --git a/datafile-app-server/src/main/java/org/onap/dcaegen2/collectors/datafile/tasks/ScheduledTasks.java b/datafile-app-server/src/main/java/org/onap/dcaegen2/collectors/datafile/tasks/ScheduledTasks.java
index de45da31..42a6fea3 100644
--- a/datafile-app-server/src/main/java/org/onap/dcaegen2/collectors/datafile/tasks/ScheduledTasks.java
+++ b/datafile-app-server/src/main/java/org/onap/dcaegen2/collectors/datafile/tasks/ScheduledTasks.java
@@ -220,17 +220,26 @@ public class ScheduledTasks {
 
     private boolean shouldBePublished(FileDataWithContext fileData) {
         Path localFilePath = fileData.fileData.getLocalFilePath();
-        if (publishedFilesCache.put(localFilePath) == null) {
-            try {
-                return !createPublishedChecker().isFilePublished(fileData.fileData.name(),
+        boolean shouldBePublished = (publishedFilesCache.put(localFilePath) == null);
+        if (shouldBePublished) {
+            shouldBePublished = checkIfFileIsNotPublishedInDataRouter(fileData);
+        }
+
+        if (!shouldBePublished) {
+            logger.debug("File: {} is being processed or was already published. Skipping.", fileData.fileData.name());
+        }
+        return shouldBePublished;
+    }
+
+    private boolean checkIfFileIsNotPublishedInDataRouter(FileDataWithContext fileData) {
+        boolean isNotPublished = true;
+        try {
+            isNotPublished = !createPublishedChecker().isFilePublished(fileData.fileData.name(),
                     fileData.fileData.messageMetaData().changeIdentifier(), fileData.context);
-            } catch (DatafileTaskException e) {
-                logger.error("Cannot check if a file {} is published", fileData.fileData.name(), e);
-                return true; // Publish it then
-            }
-        } else {
-            return false;
+        } catch (DatafileTaskException e) {
+            logger.error("Cannot check if a file {} is published", fileData.fileData.name(), e);
         }
+        return isNotPublished;
     }
 
     private Mono<FilePublishInformation> fetchFile(FileDataWithContext fileData) {