From: niamhcore <niamh.core@est.tech>
Date: Thu, 9 Sep 2021 12:16:41 +0000 (+0100)
Subject: Fix Sonar Qube Violations
X-Git-Tag: 2.0.0~5
X-Git-Url: https://gerrit.onap.org/r/gitweb?a=commitdiff_plain;h=cf65fe273c30292cacdd23b90bc7851b4f9edb3f;p=cps.git

Fix Sonar Qube Violations

Issue-ID: CPS-475
Signed-off-by: niamhcore <niamh.core@est.tech>
Change-Id: Ib8a763545e04c32c493994772f355fd3b4616098
---

diff --git a/cps-ncmp-service/src/main/java/org/onap/cps/ncmp/api/impl/NetworkCmProxyDataServiceImpl.java b/cps-ncmp-service/src/main/java/org/onap/cps/ncmp/api/impl/NetworkCmProxyDataServiceImpl.java
index 871d8806bf..9ac5fd590f 100755
--- a/cps-ncmp-service/src/main/java/org/onap/cps/ncmp/api/impl/NetworkCmProxyDataServiceImpl.java
+++ b/cps-ncmp-service/src/main/java/org/onap/cps/ncmp/api/impl/NetworkCmProxyDataServiceImpl.java
@@ -248,7 +248,7 @@ public class NetworkCmProxyDataServiceImpl implements NetworkCmProxyDataService
 
     private Map<String, String> getCmHandlePropertiesAsMap(final Collection<DataNode> cmHandlePropertiesList) {
         if (cmHandlePropertiesList == null || cmHandlePropertiesList.isEmpty()) {
-            return null;
+            return Collections.emptyMap();
         }
         final Map<String, String> cmHandlePropertiesMap = new LinkedHashMap<>();
         for (final var node: cmHandlePropertiesList) {