From: danielhanrahan <daniel.hanrahan@est.tech>
Date: Sun, 9 Feb 2025 21:53:34 +0000 (+0000)
Subject: Optimize SQL for fetching descendant fragments
X-Git-Tag: 3.6.2~29
X-Git-Url: https://gerrit.onap.org/r/gitweb?a=commitdiff_plain;h=caefa82d856b21a4b018c175e6ddf808cea69003;p=cps.git

Optimize SQL for fetching descendant fragments

This removes the INNER JOIN from the SQL query, giving
better performance when fetching smaller batches.

Issue-ID: CPS-2712
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: I40ec9b7b54c285cc29fd8188c23eb00b4442c75f
---

diff --git a/cps-ri/src/main/java/org/onap/cps/ri/repository/FragmentPrefetchRepository.java b/cps-ri/src/main/java/org/onap/cps/ri/repository/FragmentPrefetchRepository.java
index 87d7697df4..75853319da 100644
--- a/cps-ri/src/main/java/org/onap/cps/ri/repository/FragmentPrefetchRepository.java
+++ b/cps-ri/src/main/java/org/onap/cps/ri/repository/FragmentPrefetchRepository.java
@@ -1,6 +1,6 @@
 /*
  * ============LICENSE_START=======================================================
- * Copyright (C) 2023 Nordix Foundation.
+ * Copyright (C) 2023 OpenInfra Foundation Europe. All rights reserved.
  * ================================================================================
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
diff --git a/cps-ri/src/main/java/org/onap/cps/ri/repository/FragmentPrefetchRepositoryImpl.java b/cps-ri/src/main/java/org/onap/cps/ri/repository/FragmentPrefetchRepositoryImpl.java
index 6b95213a13..decd864611 100644
--- a/cps-ri/src/main/java/org/onap/cps/ri/repository/FragmentPrefetchRepositoryImpl.java
+++ b/cps-ri/src/main/java/org/onap/cps/ri/repository/FragmentPrefetchRepositoryImpl.java
@@ -1,6 +1,6 @@
 /*
  * ============LICENSE_START=======================================================
- * Copyright (C) 2023 Nordix Foundation.
+ * Copyright (C) 2023-2025 OpenInfra Foundation Europe. All rights reserved.
  * ================================================================================
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -52,8 +52,7 @@ public class FragmentPrefetchRepositoryImpl implements FragmentPrefetchRepositor
             return proxiedFragmentEntities;
         }
 
-        final List<Long> fragmentEntityIds = proxiedFragmentEntities.stream()
-                .map(FragmentEntity::getId).collect(Collectors.toList());
+        final List<Long> fragmentEntityIds = proxiedFragmentEntities.stream().map(FragmentEntity::getId).toList();
 
         final Map<Long, AnchorEntity> anchorEntityPerId = proxiedFragmentEntities.stream()
                 .map(FragmentEntity::getAnchor)
@@ -69,19 +68,20 @@ public class FragmentPrefetchRepositoryImpl implements FragmentPrefetchRepositor
             final Collection<Long> fragmentEntityIds,
             final Map<Long, AnchorEntity> anchorEntityPerId,
             final int maxDepth) {
-        final String sql
-                = "WITH RECURSIVE parent_search AS ("
-                + "    SELECT id, 0 AS depth "
-                + "    FROM fragment "
-                + "    WHERE id = ANY (?) "
-                + "  UNION "
-                + "    SELECT child.id, depth + 1 "
-                + "    FROM fragment child INNER JOIN parent_search parent ON child.parent_id = parent.id"
-                + "    WHERE depth < ?"
-                + ") "
-                + "SELECT fragment.id, anchor_id AS anchorId, xpath, parent_id AS parentId, "
-                + "       CAST(attributes AS TEXT) AS attributes "
-                + "FROM fragment INNER JOIN parent_search ON fragment.id = parent_search.id";
+        final String sql = """
+                WITH RECURSIVE fragment_hierarchy AS (
+                    SELECT id, anchor_id, xpath, parent_id, attributes, 0 AS depth
+                    FROM fragment
+                    WHERE id = ANY(?)
+                  UNION
+                    SELECT child.id, child.anchor_id, child.xpath, child.parent_id, child.attributes, depth + 1
+                    FROM fragment child
+                    INNER JOIN fragment_hierarchy parent ON child.parent_id = parent.id
+                    WHERE depth < ?
+                )
+                SELECT id, anchor_id AS anchorId, xpath, parent_id AS parentId, attributes
+                FROM fragment_hierarchy;
+                """;
 
         final PreparedStatementSetter preparedStatementSetter = preparedStatement -> {
             final Connection connection = preparedStatement.getConnection();