From: Jim Hahn <jrh3@att.com>
Date: Wed, 13 Nov 2019 18:05:58 +0000 (-0500)
Subject: Remove duplicate dao object
X-Git-Tag: 2.2.0~31
X-Git-Url: https://gerrit.onap.org/r/gitweb?a=commitdiff_plain;h=bf3f7a8af2db33cd22d2e8dbc455549298538e6a;p=policy%2Fmodels.git

Remove duplicate dao object

Code was creating the DAO object twice - removed the extra line.
Note: this properly doesn't fix the race condition, but it should fix
a memory leak.

Change-Id: I5f5c6002d42f9bb0525d1b5013b1300e80264645
Issue-ID: POLICY-1832
Signed-off-by: Jim Hahn <jrh3@att.com>
---

diff --git a/models-provider/src/main/java/org/onap/policy/models/provider/impl/DatabasePolicyModelsProviderImpl.java b/models-provider/src/main/java/org/onap/policy/models/provider/impl/DatabasePolicyModelsProviderImpl.java
index 565eb9afc..9971454bd 100644
--- a/models-provider/src/main/java/org/onap/policy/models/provider/impl/DatabasePolicyModelsProviderImpl.java
+++ b/models-provider/src/main/java/org/onap/policy/models/provider/impl/DatabasePolicyModelsProviderImpl.java
@@ -111,7 +111,6 @@ public class DatabasePolicyModelsProviderImpl implements PolicyModelsProvider {
 
         daoParameters.setJdbcProperties(jdbcProperties);
 
-        pfDao = new PfDaoFactory().createPfDao(daoParameters);
         try {
             pfDao = new PfDaoFactory().createPfDao(daoParameters);
             pfDao.init(daoParameters);