From: Piyush Garg <piyush.garg1@amdocs.com>
Date: Mon, 17 Sep 2018 02:46:56 +0000 (+0530)
Subject: Fixed sonar code smell
X-Git-Tag: 1.3.0~19^2
X-Git-Url: https://gerrit.onap.org/r/gitweb?a=commitdiff_plain;h=be6ee845ae7e6a8a2c2e67fed03f38c8c6ec292e;p=policy%2Fdrools-applications.git

Fixed sonar code smell

removed unused method parameter aaiResponseWrapper from
constructDeleteRequest

Change-Id: Ie434130b040732ed4e656c5592fff5b049695d29
Issue-ID: POLICY-1079
Signed-off-by: Piyush Garg <piyush.garg1@amdocs.com>
---

diff --git a/controlloop/common/actors/actor.so/src/main/java/org/onap/policy/controlloop/actor/so/SOActorServiceProvider.java b/controlloop/common/actors/actor.so/src/main/java/org/onap/policy/controlloop/actor/so/SOActorServiceProvider.java
index 5285d54bd..f7df1826c 100644
--- a/controlloop/common/actors/actor.so/src/main/java/org/onap/policy/controlloop/actor/so/SOActorServiceProvider.java
+++ b/controlloop/common/actors/actor.so/src/main/java/org/onap/policy/controlloop/actor/so/SOActorServiceProvider.java
@@ -169,7 +169,7 @@ public class SOActorServiceProvider implements Actor {
             return constructCreateRequest(aaiResponseWrapper, policy, tenantItem, vnfItem, vnfServiceItem,
                     vfModuleItem);
         } else if (RECIPE_VF_MODULE_DELETE.equals(policy.getRecipe())) {
-            return constructDeleteRequest(aaiResponseWrapper, tenantItem, vnfItem, vnfServiceItem, vfModuleItem);
+            return constructDeleteRequest(tenantItem, vnfItem, vnfServiceItem, vfModuleItem);
         } else {
             return null;
         }
@@ -290,16 +290,14 @@ public class SOActorServiceProvider implements Actor {
     /**
      * Construct SO request to delete vf-module
      *
-     * @param aaiResponseWrapper the AAI response containing the VF modules
      * @param tenantItem         tenant item from A&AI named-query response
      * @param vnfItem            vnf item from A&AI named-query response
      * @param vnfServiceItem     vnf service item from A&AI named-query response
      * @param vfModuleItem       vf module item from A&AI named-query response
      * @return SO delete vf-module request
      */
-    private SORequest constructDeleteRequest(AaiNqResponseWrapper aaiResponseWrapper, AaiNqInventoryResponseItem
-            tenantItem, AaiNqInventoryResponseItem vnfItem, AaiNqInventoryResponseItem vnfServiceItem,
-                                             AaiNqInventoryResponseItem vfModuleItem) {
+    private SORequest constructDeleteRequest(AaiNqInventoryResponseItem tenantItem, AaiNqInventoryResponseItem
+            vnfItem, AaiNqInventoryResponseItem vnfServiceItem, AaiNqInventoryResponseItem vfModuleItem) {
         SORequest request = new SORequest();
         request.setOperationType(SoOperationType.DELETE_VF_MODULE);
         request.setRequestDetails(new SORequestDetails());