From: Arundathi Patil <arundpil@in.ibm.com>
Date: Fri, 30 Nov 2018 09:56:32 +0000 (+0530)
Subject: Sonar fix: ModelType.java
X-Git-Tag: 0.4.2~160^2~79^2
X-Git-Url: https://gerrit.onap.org/r/gitweb?a=commitdiff_plain;h=b74bd11d41816545b64f190e111a7eba6312b445;p=ccsdk%2Fcds.git

Sonar fix: ModelType.java

Fixed sonar issues/code-smells across this file.

Issue-ID: CCSDK-771
Change-Id: I9a36c9b5a955cfa027de3a2c002634ac1755d68d
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
---

diff --git a/ms/controllerblueprints/modules/service/src/main/java/org/onap/ccsdk/apps/controllerblueprints/service/domain/ModelType.java b/ms/controllerblueprints/modules/service/src/main/java/org/onap/ccsdk/apps/controllerblueprints/service/domain/ModelType.java
index d8fea60e5..33c7ae42b 100644
--- a/ms/controllerblueprints/modules/service/src/main/java/org/onap/ccsdk/apps/controllerblueprints/service/domain/ModelType.java
+++ b/ms/controllerblueprints/modules/service/src/main/java/org/onap/ccsdk/apps/controllerblueprints/service/domain/ModelType.java
@@ -84,7 +84,7 @@ public class ModelType implements Serializable {
 
     @Override
     public String toString() {
-        String buffer = "[" + ", modelName = " + modelName +
+        return "[" + ", modelName = " + modelName +
                 ", derivedFrom = " + derivedFrom +
                 ", definitionType = " + definitionType +
                 ", description = " + description +
@@ -93,7 +93,6 @@ public class ModelType implements Serializable {
                 ", updatedBy = " + updatedBy +
                 ", tags = " + tags +
                 "]";
-        return buffer;
     }
 
     public String getModelName() {