From: brunomilitzer <bruno.militzer@est.tech>
Date: Thu, 30 Sep 2021 16:36:44 +0000 (+0100)
Subject: Fixed Service Template Parsing
X-Git-Tag: 6.1.3~7
X-Git-Url: https://gerrit.onap.org/r/gitweb?a=commitdiff_plain;h=b4f25510c8e71554cbbecf1cf1d9c21326d2d249;p=policy%2Fclamp.git

Fixed Service Template Parsing

Issue-Id: POLICY-3691
Change-Id: Ie04711cd01e4140b0842e8d0d4ffbbe8e1b83361
Signed-off-by: brunomilitzer <bruno.militzer@est.tech>
---

diff --git a/runtime-controlloop/src/main/java/org/onap/policy/clamp/controlloop/runtime/commissioning/CommissioningProvider.java b/runtime-controlloop/src/main/java/org/onap/policy/clamp/controlloop/runtime/commissioning/CommissioningProvider.java
index 72c153b6d..d055ba266 100644
--- a/runtime-controlloop/src/main/java/org/onap/policy/clamp/controlloop/runtime/commissioning/CommissioningProvider.java
+++ b/runtime-controlloop/src/main/java/org/onap/policy/clamp/controlloop/runtime/commissioning/CommissioningProvider.java
@@ -262,11 +262,19 @@ public class CommissioningProvider {
      * @return the tosca service template
      * @throws PfModelException on errors getting tosca service template
      */
-    public String getToscaServiceTemplateReduced(String name, String version) throws PfModelException {
+    public String getToscaServiceTemplateReduced(String name, String version)
+        throws PfModelException {
 
         var serviceTemplateList = serviceTemplateProvider.getServiceTemplateList(name, version);
 
-        ToscaServiceTemplate fullTemplate = filterToscaNodeTemplateInstance(serviceTemplateList).get(0);
+        List<ToscaServiceTemplate> filteredServiceTemplateList = filterToscaNodeTemplateInstance(
+            serviceTemplateList);
+
+        if (filteredServiceTemplateList.isEmpty()) {
+            throw new PfModelException(Status.BAD_REQUEST, "Invalid Service Template");
+        }
+
+        ToscaServiceTemplate fullTemplate = filteredServiceTemplateList.get(0);
 
         var template = new HashMap<String, Object>();
         template.put("tosca_definitions_version", fullTemplate.getToscaDefinitionsVersion());