From: Sandeep J <sandeejh@in.ibm.com>
Date: Mon, 3 Dec 2018 10:26:38 +0000 (+0530)
Subject: fixed sonar issues in SpringServiceImpl.java
X-Git-Tag: 0.4.0~56^2
X-Git-Url: https://gerrit.onap.org/r/gitweb?a=commitdiff_plain;h=b1001d9cd888f9947145ca7fc17698791b95a0e5;p=ccsdk%2Fapps.git

fixed sonar issues in SpringServiceImpl.java

fixed sonar issues

Issue-ID: CCSDK-525
Change-Id: Id14d83d0b8c38feec837f3135dfd61458f10e77d
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
---

diff --git a/ms/neng/src/main/java/org/onap/ccsdk/apps/ms/neng/core/service/SpringServiceImpl.java b/ms/neng/src/main/java/org/onap/ccsdk/apps/ms/neng/core/service/SpringServiceImpl.java
index 01c8324d..c5cabe51 100644
--- a/ms/neng/src/main/java/org/onap/ccsdk/apps/ms/neng/core/service/SpringServiceImpl.java
+++ b/ms/neng/src/main/java/org/onap/ccsdk/apps/ms/neng/core/service/SpringServiceImpl.java
@@ -115,7 +115,7 @@ public class SpringServiceImpl implements SpringService {
             List<Map<String, String>> allElements = new ArrayList<>();
             Map<String, Map<String, ?>> policyCache = new HashMap<>();
             List<Map<String, String>> generatedNames = new ArrayList<>();
-            List<String> earlierNamingTypes = new ArrayList<String>();
+            List<String> earlierNamingTypes = new ArrayList<>();
             validateRequest(request);
             if (request.getElements() != null && !request.getElements().isEmpty()) {
                 allElements.addAll(request.getElements());
@@ -226,6 +226,7 @@ public class SpringServiceImpl implements SpringService {
     }
 
     void validateRequest(NameGenRequest request) throws Exception {
+    	// this method does nothing
     }
 
     private PolicyFinder findPolicyFinderImpl(NameGenRequest request) {