From: Magnusen, Drew (dm741q) Date: Mon, 31 Jul 2017 17:51:51 +0000 (-0500) Subject: [POLICY-134] Fixed bug in PolicyLogger. X-Git-Tag: v1.1.0~20^2 X-Git-Url: https://gerrit.onap.org/r/gitweb?a=commitdiff_plain;h=9c1eba1933eb84398b1cfa88199953fea935d691;p=policy%2Fcommon.git [POLICY-134] Fixed bug in PolicyLogger. PolicyLogger.info(Object arg0) calls itself recursively until it eventually causes a stack overflow error. Fix is to call debugLogger.info(MessageCodes, String) from within PolicyLogger.info(Object). Additionally, PolicyLogger.info(String arg0) was removed as debugLogger.info(MessageCodes, String) can be called directly. Change-Id: Id141027b544efa06b79f54a6726843b2a47481b9 Signed-off-by: Magnusen, Drew (dm741q) --- diff --git a/common-logging/src/main/java/org/onap/policy/common/logging/eelf/PolicyLogger.java b/common-logging/src/main/java/org/onap/policy/common/logging/eelf/PolicyLogger.java index d0cc9c1e..7507c9ea 100644 --- a/common-logging/src/main/java/org/onap/policy/common/logging/eelf/PolicyLogger.java +++ b/common-logging/src/main/java/org/onap/policy/common/logging/eelf/PolicyLogger.java @@ -366,14 +366,6 @@ public class PolicyLogger { debugLogger.info(MessageCodes.GENERAL_INFO, arg0); } - /** - * Records only one String message without its class name passed in - * @param arg0 - */ - public static void info(String arg0) { - MDC.put(CLASS_NAME, ""); - debugLogger.info(MessageCodes.GENERAL_INFO, arg0); - } /** * Records only one String message @@ -381,7 +373,7 @@ public class PolicyLogger { */ public static void info(Object arg0) { MDC.put(CLASS_NAME, ""); - info(arg0); + debugLogger.info(MessageCodes.GENERAL_INFO, String.valueOf(arg0)); } /**