From: Surendra Reddy Katam <SK00524980@techmahindra.com>
Date: Wed, 28 Mar 2018 07:08:36 +0000 (+0530)
Subject: Sonar major issues
X-Git-Tag: v1.1.4~22
X-Git-Url: https://gerrit.onap.org/r/gitweb?a=commitdiff_plain;h=8da3d7e089d1a8d4bd89715fa5c61b94e39459b3;p=dmaap%2Fmessagerouter%2Fdmaapclient.git

Sonar major issues

 Use isEmpty() to check whether the collection is empty or not
Sonar Link:
https://sonar.onap.org/project/issues?assignees=surendraReddy&id=org.onap.dmaap.messagerouter.dmaapclient%3AdmaapClient&open=AV4-MbPA32hFUzlqc5WZ&resolved=false&severities=MAJOR
Location:
src/main/java/com/att/nsa/mr/client/MRClientBuilders.java
Line No-238

Change-Id: If5b14b4e2fe6964f4a02f980525b6bc1c8f95fdb
Issue-ID: DMAAP-360
Signed-off-by: Surendra Reddy Katam <SK00524980@techmahindra.com>
---

diff --git a/src/main/java/com/att/nsa/mr/client/MRClientBuilders.java b/src/main/java/com/att/nsa/mr/client/MRClientBuilders.java
index 177fd30..c7707f1 100644
--- a/src/main/java/com/att/nsa/mr/client/MRClientBuilders.java
+++ b/src/main/java/com/att/nsa/mr/client/MRClientBuilders.java
@@ -235,7 +235,7 @@ public class MRClientBuilders
 		 */
 		public MRBatchingPublisher build ()
 		{
-			if ( fHosts == null || fHosts.size() == 0 || fTopic == null )
+			if ( fHosts == null || fHosts.isEmpty() || fTopic == null )
 			{
 				throw new IllegalArgumentException ( "You must provide at least one host and a topic name." );
 			}