From: Sunder Tattavarada <statta@research.att.com>
Date: Wed, 29 Apr 2020 19:39:33 +0000 (+0000)
Subject: Merge "Sonar - Major blocker issue fix"
X-Git-Tag: 3.4.0~89
X-Git-Url: https://gerrit.onap.org/r/gitweb?a=commitdiff_plain;h=884a4ec238b7ef68e209addea9890d9c166cb702;hp=013c0393a92ef0c1475a97a112a78cd9ff1b5fc4;p=portal.git

Merge "Sonar - Major blocker issue fix"
---

diff --git a/ecomp-portal-BE-common/src/main/java/org/onap/portalapp/portal/controller/RolesApprovalSystemController.java b/ecomp-portal-BE-common/src/main/java/org/onap/portalapp/portal/controller/RolesApprovalSystemController.java
index 5562caac..487cc4d5 100644
--- a/ecomp-portal-BE-common/src/main/java/org/onap/portalapp/portal/controller/RolesApprovalSystemController.java
+++ b/ecomp-portal-BE-common/src/main/java/org/onap/portalapp/portal/controller/RolesApprovalSystemController.java
@@ -219,9 +219,9 @@ public class RolesApprovalSystemController implements BasicAuthenticationControl
 	 *             If any field is missing.
 	 */
 	private void validateExtSystemUser(ExternalSystemUser extSysUser, boolean rolesRequired) throws Exception {
-		if (extSysUser.getLoginId() == null || extSysUser.getLoginId() == "")
+		if (extSysUser.getLoginId() == null || extSysUser.getLoginId().equals(""))
 			throw new Exception("Request has no login ID");
-		if (extSysUser.getApplicationName() == null || extSysUser.getApplicationName() == "")
+		if (extSysUser.getApplicationName() == null || extSysUser.getApplicationName().equals(""))
 			throw new Exception("Request has no application name");
 		if (extSysUser.getMyloginrequestId() == null)
 			throw new Exception("Request has no request ID");