From: burdziak Date: Tue, 16 Apr 2019 11:53:43 +0000 (+0200) Subject: Fix sonar issues in RaptorObject X-Git-Tag: 3.0.0~205^2 X-Git-Url: https://gerrit.onap.org/r/gitweb?a=commitdiff_plain;h=842d970675f5f0d69ceee98052ce582a510fc467;p=portal%2Fsdk.git Fix sonar issues in RaptorObject Change-Id: I146a5f6fbc51d320e3d93dc17f133d4e687e8a1f Issue-ID: PORTAL-523 Signed-off-by: burdziak --- diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/RaptorObject.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/RaptorObject.java index 8b968cc8..fd5fdba1 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/RaptorObject.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/RaptorObject.java @@ -44,7 +44,7 @@ public class RaptorObject extends java.lang.Object { } protected String nvl(String s, String sDefault) { - return nvl(s).equals("") ? sDefault : s; + return nvl(s).isEmpty() ? sDefault : s; } protected static String nvls(String s) { @@ -52,11 +52,11 @@ public class RaptorObject extends java.lang.Object { } protected static String nvls(String s, String sDefault) { - return nvls(s).equals("") ? sDefault : s; + return nvls(s).isEmpty() ? sDefault : s; } protected boolean getFlagInBoolean(String s) { - return nvl(s).toUpperCase().startsWith("Y") || nvl(s).toLowerCase().equals("true"); + return nvl(s).toUpperCase().startsWith("Y") || "true".equalsIgnoreCase(nvl(s)); } } // RaptorObject