From: Toine Siebelink Date: Wed, 13 Dec 2023 09:56:49 +0000 (+0000) Subject: Merge "Clean up CSIT Test" X-Git-Tag: 3.4.1~14 X-Git-Url: https://gerrit.onap.org/r/gitweb?a=commitdiff_plain;h=7e94b26a666907cc97d692b8dda8364bb0a0ef45;hp=14d37304d8b83efc099ba19d6f3e7d5d53fead29;p=cps.git Merge "Clean up CSIT Test" --- diff --git a/cps-dependencies/pom.xml b/cps-dependencies/pom.xml index 0e76d7e31..660364eb7 100755 --- a/cps-dependencies/pom.xml +++ b/cps-dependencies/pom.xml @@ -140,7 +140,7 @@ com.google.guava guava - 31.1-jre + 32.1.3-jre com.hazelcast diff --git a/cps-ncmp-service/src/main/java/org/onap/cps/ncmp/api/impl/trustlevel/dmiavailability/DmiPluginWatchDog.java b/cps-ncmp-service/src/main/java/org/onap/cps/ncmp/api/impl/trustlevel/dmiavailability/DmiPluginWatchDog.java index 6a272f1c6..6ae7ff3d4 100644 --- a/cps-ncmp-service/src/main/java/org/onap/cps/ncmp/api/impl/trustlevel/dmiavailability/DmiPluginWatchDog.java +++ b/cps-ncmp-service/src/main/java/org/onap/cps/ncmp/api/impl/trustlevel/dmiavailability/DmiPluginWatchDog.java @@ -47,7 +47,7 @@ public class DmiPluginWatchDog { * the resulting trust level wil be stored in the relevant cache. * The @fixedDelayString is the time interval, in milliseconds, between consecutive checks. */ - @Scheduled(fixedDelayString = "${ncmp.timers.trust-evel.dmi-availability-watchdog-ms:30000}") + @Scheduled(fixedDelayString = "${ncmp.timers.trust-level.dmi-availability-watchdog-ms:30000}") public void checkDmiAvailability() { trustLevelPerDmiPlugin.entrySet().forEach(entry -> { final TrustLevel newDmiTrustLevel; diff --git a/cps-ncmp-service/src/test/groovy/org/onap/cps/ncmp/api/impl/NetworkCmProxyDataServiceImplRegistrationSpec.groovy b/cps-ncmp-service/src/test/groovy/org/onap/cps/ncmp/api/impl/NetworkCmProxyDataServiceImplRegistrationSpec.groovy index 97693a415..51b00d143 100644 --- a/cps-ncmp-service/src/test/groovy/org/onap/cps/ncmp/api/impl/NetworkCmProxyDataServiceImplRegistrationSpec.groovy +++ b/cps-ncmp-service/src/test/groovy/org/onap/cps/ncmp/api/impl/NetworkCmProxyDataServiceImplRegistrationSpec.groovy @@ -221,9 +221,9 @@ class NetworkCmProxyDataServiceImplRegistrationSpec extends Specification { where: scenario | dmiProperties | publicProperties || expectedDmiProperties | expectedPublicProperties 'with dmi & public properties' | ['dmi-key': 'dmi-value'] | ['public-key': 'public-value'] || '[{"name":"dmi-key","value":"dmi-value"}]' | '[{"name":"public-key","value":"public-value"}]' - 'with only public properties' | [:] | ['public-key': 'public-value'] || '[]' | '[{"name":"public-key","value":"public-value"}]' - 'with only dmi properties' | ['dmi-key': 'dmi-value'] | [:] || '[{"name":"dmi-key","value":"dmi-value"}]' | '[]' - 'without dmi & public properties' | [:] | [:] || '[]' | '[]' + 'with only public properties' | [:] | ['public-key': 'public-value'] || [:] | '[{"name":"public-key","value":"public-value"}]' + 'with only dmi properties' | ['dmi-key': 'dmi-value'] | [:] || '[{"name":"dmi-key","value":"dmi-value"}]' | [:] + 'without dmi & public properties' | [:] | [:] || [:] | [:] } def 'Add CM-Handle to trustLevelPerCmHandle Successfully with: #scenario.'() { diff --git a/csit/tests/cps-data/cps-data.robot b/csit/tests/cps-data/cps-data.robot index 0e3dfabdd..f506b2801 100644 --- a/csit/tests/cps-data/cps-data.robot +++ b/csit/tests/cps-data/cps-data.robot @@ -57,7 +57,12 @@ Get Updated Data Node by XPath ${response}= Get On Session CPS_URL ${uri} params=${params} headers=${headers} expected_status=200 ${responseJson}= Set Variable ${response.json()['tree:nest']} Should Be Equal As Strings ${responseJson['name']} Bigger - Should Be Equal As Strings ${responseJson['birds']} ['Falcon', 'Eagle', 'Pigeon'] + ${length_birds}= Get Length ${responseJson['birds']} + Should Be Equal As Integers ${length_birds} 3 + ${expected_list}= Create List Pigeon Falcon Eagle + FOR ${item_to_check} IN @{expected_list} + Should Contain ${responseJson['birds']} ${item_to_check} + END Get Data Node by XPath ${uri}= Set Variable ${basePath}/v1/dataspaces/${dataspaceName}/anchors/${anchorName}/node diff --git a/integration-test/src/test/groovy/org/onap/cps/integration/functional/CpsAdminServiceIntegrationSpec.groovy b/integration-test/src/test/groovy/org/onap/cps/integration/functional/CpsAdminServiceIntegrationSpec.groovy index bdd894c31..f8eca6199 100644 --- a/integration-test/src/test/groovy/org/onap/cps/integration/functional/CpsAdminServiceIntegrationSpec.groovy +++ b/integration-test/src/test/groovy/org/onap/cps/integration/functional/CpsAdminServiceIntegrationSpec.groovy @@ -174,7 +174,8 @@ class CpsAdminServiceIntegrationSpec extends CpsIntegrationSpecBase { def updatedTreeJsonData = readResourceDataFile('tree/updated-test-tree.json') cpsDataService.updateNodeLeaves(GENERAL_TEST_DATASPACE, "anchor4", "/test-tree/branch[@name='left']", updatedTreeJsonData, OffsetDateTime.now()) then: 'updated tree data node can be retrieved by its normalized xpath' - def birdsName = cpsDataService.getDataNodes(GENERAL_TEST_DATASPACE, 'anchor4',"/test-tree/branch[@name='left']/nest", FetchDescendantsOption.DIRECT_CHILDREN_ONLY)[0].leaves['birds'] - assert birdsName as String == '[Raven, Night Owl, Crow]' + def birdsName = cpsDataService.getDataNodes(GENERAL_TEST_DATASPACE, 'anchor4',"/test-tree/branch[@name='left']/nest", FetchDescendantsOption.DIRECT_CHILDREN_ONLY)[0].leaves['birds'] as List + assert birdsName.size() == 3 + assert birdsName.containsAll('Night Owl', 'Raven', 'Crow') } }