From: shashikanth <shashikanth.vh@huawei.com>
Date: Tue, 26 Sep 2017 12:19:38 +0000 (+0530)
Subject: Fixed string literal comparision issue
X-Git-Tag: v1.1.0~259^2
X-Git-Url: https://gerrit.onap.org/r/gitweb?a=commitdiff_plain;h=7cb31a0da72f61c7599b6086bfae345d9c81008b;p=so.git

Fixed string literal comparision issue

Fix major sonar issues in so module
https://sonar.onap.org/component_issues?id=org.openecomp.so%3Aso#resolved=false|severities=BLOCKER%2CMAJOR|rules=squid%3AS1132%2Csquid%3AS1143

Move the "default" string literal on the left side of this string comparison.

Issue-Id: APPC-186
Change-Id: I5d503e08331a867b2871dee7acfe74112228bf16
Signed-off-by: shashikanth.vh <shashikanth.vh@huawei.com>
---

diff --git a/adapters/mso-adapter-utils/src/main/java/org/openecomp/mso/cloud/CloudConfig.java b/adapters/mso-adapter-utils/src/main/java/org/openecomp/mso/cloud/CloudConfig.java
index eac76c74a5..3ba2ae25db 100644
--- a/adapters/mso-adapter-utils/src/main/java/org/openecomp/mso/cloud/CloudConfig.java
+++ b/adapters/mso-adapter-utils/src/main/java/org/openecomp/mso/cloud/CloudConfig.java
@@ -135,7 +135,7 @@ public class CloudConfig {
                     if (version == null || version.equals(cs.getAic_version())) {
                         return cs;
                     }
-                } else if (cs.getId().equalsIgnoreCase("default")) {
+                } else if ("default".equalsIgnoreCase(cs.getId())) {
                     // save it off in case we need it
                     defaultCloudSite = cs.clone();
                 }