From: SwapnilPathak <SP00494485@techmahindra.com>
Date: Fri, 15 Sep 2017 05:54:06 +0000 (+0530)
Subject: Sonar Major
X-Git-Tag: v1.1.0~38
X-Git-Url: https://gerrit.onap.org/r/gitweb?a=commitdiff_plain;h=7ca599cb444c3896beb9318c90a460adb1f276b9;p=policy%2Fdrools-pdp.git

Sonar Major

Move the string literal on the left side of this string comparison.

Change-Id: I8086a6fc1dc24719c3ffd3785a12c086ab453ae7
Issue-ID: POLICY-230
Signed-off-by: SwapnilPathak <SP00494485@techmahindra.com>
---

diff --git a/policy-endpoints/src/main/java/org/onap/policy/drools/event/comm/bus/internal/BusConsumer.java b/policy-endpoints/src/main/java/org/onap/policy/drools/event/comm/bus/internal/BusConsumer.java
index c4155b77..8171c35d 100644
--- a/policy-endpoints/src/main/java/org/onap/policy/drools/event/comm/bus/internal/BusConsumer.java
+++ b/policy-endpoints/src/main/java/org/onap/policy/drools/event/comm/bus/internal/BusConsumer.java
@@ -310,7 +310,7 @@ public interface BusConsumer {
           consumerInstance, fetchTimeout, fetchLimit, useHttps);
 
       // super constructor sets servers = {""} if empty to avoid errors when using DME2
-      if ((servers.size() == 1 && servers.get(0).equals("")) || (servers == null)
+      if ((servers.size() == 1 && ("".equals(servers.get(0)))) || (servers == null)
           || (servers.isEmpty())) {
         throw new IllegalArgumentException("Must provide at least one host for HTTP AAF");
       }