From: Sandeep J <sandeejh@in.ibm.com>
Date: Tue, 11 Dec 2018 11:40:13 +0000 (+0530)
Subject: fixed sonar issues in ConfigModelService.java
X-Git-Tag: 0.4.0~36^2
X-Git-Url: https://gerrit.onap.org/r/gitweb?a=commitdiff_plain;h=7a09c652717e7253417bcba2bccb72f0c0da5cb9;p=ccsdk%2Fapps.git

fixed sonar issues in ConfigModelService.java

fixed sonar issues

Issue-ID: CCSDK-552
Change-Id: Iab02d1cee2b0cb9e182f9d4af839000307ec99bf
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
---

diff --git a/ms/controllerblueprints/modules/service/src/main/java/org/onap/ccsdk/apps/controllerblueprints/service/ConfigModelService.java b/ms/controllerblueprints/modules/service/src/main/java/org/onap/ccsdk/apps/controllerblueprints/service/ConfigModelService.java
index a2f653c6..b2fff26e 100644
--- a/ms/controllerblueprints/modules/service/src/main/java/org/onap/ccsdk/apps/controllerblueprints/service/ConfigModelService.java
+++ b/ms/controllerblueprints/modules/service/src/main/java/org/onap/ccsdk/apps/controllerblueprints/service/ConfigModelService.java
@@ -55,6 +55,7 @@ public class ConfigModelService {
     private ConfigModelRepository configModelRepository;
     private ConfigModelContentRepository configModelContentRepository;
     private ConfigModelCreateService configModelCreateService;
+    private static final String CONFIG_MODEL_ID_FAILURE_MSG= "failed to get config model id(%d) from repo";
 
     /**
      * This is a ConfigModelService constructor.
@@ -174,7 +175,7 @@ public class ConfigModelService {
         if (dbConfigModel.isPresent()) {
             configModel = dbConfigModel.get();
         } else {
-            throw new BluePrintException(String.format("failed to get config model id(%d) from repo", id));
+            throw new BluePrintException(String.format(CONFIG_MODEL_ID_FAILURE_MSG, id));
         }
 
         return configModel;
@@ -232,7 +233,7 @@ public class ConfigModelService {
                 }
             }
         } else {
-            throw new BluePrintException(String.format("failed to get config model id(%d) from repo", id));
+            throw new BluePrintException(String.format(CONFIG_MODEL_ID_FAILURE_MSG, id));
         }
 
         return cloneConfigModel;
@@ -252,7 +253,7 @@ public class ConfigModelService {
             configModelContentRepository.deleteByConfigModel(dbConfigModel.get());
             configModelRepository.delete(dbConfigModel.get());
         } else {
-            throw new BluePrintException(String.format("failed to get config model id(%d) from repo", id));
+            throw new BluePrintException(String.format(CONFIG_MODEL_ID_FAILURE_MSG, id));
         }
     }