From: fkrzywka Date: Tue, 5 Jun 2018 12:51:36 +0000 (+0200) Subject: Duplicate code removal X-Git-Tag: 1.0.0~103 X-Git-Url: https://gerrit.onap.org/r/gitweb?a=commitdiff_plain;h=763b680bea3f5c14e70453845d7670f7ae691e87;p=dcaegen2%2Fcollectors%2Fhv-ves.git Duplicate code removal Change-Id: Iee19bce0ba18746d0570337c5317ccdd63552d56 Signed-off-by: fkrzywka Issue-ID: DCAEGEN2-601 --- diff --git a/hv-collector-core/src/main/kotlin/org/onap/dcae/collectors/veshv/impl/VesHvCollector.kt b/hv-collector-core/src/main/kotlin/org/onap/dcae/collectors/veshv/impl/VesHvCollector.kt index b0f877f0..9cade1cc 100644 --- a/hv-collector-core/src/main/kotlin/org/onap/dcae/collectors/veshv/impl/VesHvCollector.kt +++ b/hv-collector-core/src/main/kotlin/org/onap/dcae/collectors/veshv/impl/VesHvCollector.kt @@ -59,13 +59,7 @@ internal class VesHvCollector( return valid } - private fun findRoute(msg: VesMessage): Mono { - val routedMessage = router.findDestination(msg) - return if (routedMessage == null) - Mono.empty() - else - Mono.just(routedMessage) - } + private fun findRoute(msg: VesMessage): Mono = omitWhenNull(msg, router::findDestination) private fun releaseMemory(msg: VesMessage) { msg.rawMessage.release() @@ -73,8 +67,7 @@ internal class VesHvCollector( - private fun omitWhenNull(input: ByteBuf, mapper: (ByteBuf) -> T?): Mono = - Mono.justOrEmpty(mapper(input)) + private fun omitWhenNull(input: T, mapper: (T) -> V?): Mono = Mono.justOrEmpty(mapper(input)) private fun releaseWhenNull(input: ByteBuf, mapper: (ByteBuf) -> T?): Mono { val result = mapper(input)